You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by jo...@gmail.com on 2010/03/19 00:42:21 UTC
Remove normalizeProtocol method from RequestPipeline interface
(issue645041)
Reviewers: shindig.remailer_gmail.com,
Description:
It's only used by DefaultRequestPipeline as an implementation detail.
Please review this at http://codereview.appspot.com/645041/show
Affected files:
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/RequestPipeline.java
Index:
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/RequestPipeline.java
===================================================================
---
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/RequestPipeline.java
(revision 922057)
+++
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/RequestPipeline.java
(working copy)
@@ -35,10 +35,4 @@
* TODO: This should throw a custom exception type.
*/
HttpResponse execute(HttpRequest request) throws GadgetException;
-
- /**
- * Normalize the request protocol. Typically this would restrict the
allowed
- * protocols to http/https but containers may support other protocols
- */
- void normalizeProtocol(HttpRequest request) throws GadgetException;
}
\ No newline at end of file
Index:
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java
===================================================================
---
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java
(revision 922057)
+++
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java
(working copy)
@@ -120,7 +120,7 @@
return fetchedResponse;
}
- public void normalizeProtocol(HttpRequest request) throws
GadgetException {
+ private void normalizeProtocol(HttpRequest request) throws
GadgetException {
// Normalize the protocol part of the URI
if (request.getUri().getScheme()== null) {
throw new GadgetException(GadgetException.Code.INVALID_PARAMETER,