[GitHub] [iceberg] stevenzwu commented on a diff in pull request #7798: API: add StructTransform base class for PartitionKey and SortKey. add SortOrderComparators

["stevenzwu (via GitHub)" <gi...@apache.org>]

stevenzwu commented on code in PR #7798:
URL: https://github.com/apache/iceberg/pull/7798#discussion_r1222252549


##########
api/src/main/java/org/apache/iceberg/PartitionKey.java:
##########
@@ -18,72 +18,32 @@
  */
 package org.apache.iceberg;
 
-import java.io.Serializable;
-import java.lang.reflect.Array;
-import java.util.Arrays;
 import java.util.List;
-import java.util.function.Function;
-import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
-import org.apache.iceberg.util.SerializableFunction;
+import java.util.stream.Collectors;
 
 /**
  * A struct of partition values.
  *
  * <p>Instances of this class can produce partition values from a data row passed to {@link
  * #partition(StructLike)}.
  */
-public class PartitionKey implements StructLike, Serializable {
+public class PartitionKey extends StructTransform {

Review Comment:
   A lot of code has been moved to the non-public `StructTransform` class so that it can be reused for the new `SortKey` class



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org