[GitHub] [spark] grundprinzip commented on a diff in pull request #39294: [SPARK-41537] Github Workflow Check for Breaking Changes in Spark Connect Proto

[GitBox <gi...@apache.org>]

grundprinzip commented on code in PR #39294:
URL: https://github.com/apache/spark/pull/39294#discussion_r1059628374


##########
.github/workflows/build_and_test.yml:
##########
@@ -494,6 +495,43 @@ jobs:
         name: test-results-sparkr--8-${{ inputs.hadoop }}-hive2.3
         path: "**/target/test-reports/*.xml"
 
+  proto-breaking-changes-check:
+    needs: [precondition, infra-image]

Review Comment:
   I can try without, my assumption was since this is very close to the Python build the `infra-image` is actually needed to make sure the environment is consistent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org