You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "liaoxin01 (via GitHub)" <gi...@apache.org> on 2023/11/23 09:48:23 UTC
[PR] [chore](merge-on-write) disable rowid conversion check for mow table by default [doris]
liaoxin01 opened a new pull request, #27482:
URL: https://github.com/apache/doris/pull/27482
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
Disable rowid conversion check for mow table by default，because it may cause the table meta lock to be held for too long. Only enable it in the testing environment.
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](merge-on-write) disable rowid conversion check for mow table by default [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27482:
URL: https://github.com/apache/doris/pull/27482#issuecomment-1824095986
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](merge-on-write) disable rowid conversion check for mow table by default [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27482:
URL: https://github.com/apache/doris/pull/27482#issuecomment-1824537087
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.82 seconds
stream load tsv: 568 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.5 seconds inserted 10000000 Rows, about 350K ops/s
storage size: 17099035299 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](merge-on-write) disable rowid conversion check for mow table by default [doris]
Posted by "liaoxin01 (via GitHub)" <gi...@apache.org>.
liaoxin01 commented on PR #27482:
URL: https://github.com/apache/doris/pull/27482#issuecomment-1824087752
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](merge-on-write) disable rowid conversion check for mow table by default [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27482:
URL: https://github.com/apache/doris/pull/27482#issuecomment-1824282161
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](merge-on-write) disable rowid conversion check for mow table by default [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27482:
URL: https://github.com/apache/doris/pull/27482#issuecomment-1824282218
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](merge-on-write) disable rowid conversion check for mow table by default [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon commented on PR #27482:
URL: https://github.com/apache/doris/pull/27482#issuecomment-1824350734
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](merge-on-write) disable rowid conversion check for mow table by default [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27482:
URL: https://github.com/apache/doris/pull/27482#issuecomment-1824546643
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 5e3ca36f07f31e11f680056fa1effd1d92f7d096, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4927 4663 4646 4646
q2 355 158 159 158
q3 2036 1930 1961 1930
q4 1395 1282 1263 1263
q5 3974 3960 4038 3960
q6 250 125 128 125
q7 1443 882 872 872
q8 2785 2812 2786 2786
q9 9663 9455 9437 9437
q10 3463 3537 3512 3512
q11 382 258 234 234
q12 431 288 293 288
q13 4581 3798 3807 3798
q14 325 290 289 289
q15 585 528 522 522
q16 669 591 594 591
q17 1138 976 926 926
q18 7816 7460 7313 7313
q19 1671 1675 1683 1675
q20 527 287 301 287
q21 4425 3953 3966 3953
q22 469 374 368 368
Total cold run time: 53310 ms
Total hot run time: 48933 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4616 4613 4606 4606
q2 332 229 274 229
q3 4024 4009 4033 4009
q4 2705 2693 2698 2693
q5 9665 9683 9750 9683
q6 246 121 120 120
q7 3036 2460 2482 2460
q8 4461 4477 4485 4477
q9 12990 12772 12824 12772
q10 4093 4170 4194 4170
q11 858 648 689 648
q12 968 805 803 803
q13 4299 3582 3536 3536
q14 383 343 358 343
q15 582 528 520 520
q16 731 684 668 668
q17 3828 3876 3894 3876
q18 9518 9171 9087 9087
q19 1822 1819 1769 1769
q20 2421 2086 2078 2078
q21 8830 8450 8709 8450
q22 869 796 826 796
Total cold run time: 81277 ms
Total hot run time: 77793 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](merge-on-write) disable rowid conversion check for mow table by default [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon merged PR #27482:
URL: https://github.com/apache/doris/pull/27482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org