You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "jesusch (via GitHub)" <gi...@apache.org> on 2025/03/24 13:22:54 UTC

[PR] [CELEBORN-1926] updated helmChart to allow different nodeSelector and tolerations for master and worker nodes [celeborn]

jesusch opened a new pull request, #3170:
URL: https://github.com/apache/celeborn/pull/3170

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   support different master/worker nodeSelector and tolerations
   
   ### Why are the changes needed?
   
   add possibility to run master and worker on different nodeGroups
   
   ### Does this PR introduce _any_ user-facing change?
   
   updated helmChart values
   
   ### How was this patch tested?
   
   tested on our k8s cluster


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1926] updated helmChart to allow different nodeSelector and tolerations for master and worker nodes [celeborn]

Posted by "ChenYi015 (via GitHub)" <gi...@apache.org>.
ChenYi015 commented on PR #3170:
URL: https://github.com/apache/celeborn/pull/3170#issuecomment-2772097273

   > @ChenYi015 appreciated. Do you need help splitting those up?
   
   Thanks for your help, I can make it by myself. 
   
   >  as [CELEBORN-1900](https://issues.apache.org/jira/browse/CELEBORN-1900) is now on main we should also use the following image https://hub.docker.com/r/apache/celeborn
   
   Hopefully we can publish the helm chart, by using the official container image.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1926] updated helmChart to allow different nodeSelector and tolerations for master and worker nodes [celeborn]

Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on PR #3170:
URL: https://github.com/apache/celeborn/pull/3170#issuecomment-2868874964

   > This PR can be closed for the features has already been implemented by [CELEBORN-1955](https://issues.apache.org/jira/projects/CELEBORN/issues/CELEBORN-1955) and [CELEBORN-1962](https://issues.apache.org/jira/projects/CELEBORN/issues/CELEBORN-1962). Now one can configure nodeSelector/tolerations by `master.nodeSelector`/`worker.nodeSelector` and `master.tolerations`/`worker.tolerations`.
   
   Thanks @jesusch,  based on the reasons above, I will close this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1926] updated helmChart to allow different nodeSelector and tolerations for master and worker nodes [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #3170:
URL: https://github.com/apache/celeborn/pull/3170#issuecomment-2750599042

   @jesusch, please fix the failure of integration tests for CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1926] updated helmChart to allow different nodeSelector and tolerations for master and worker nodes [celeborn]

Posted by "ChenYi015 (via GitHub)" <gi...@apache.org>.
ChenYi015 commented on PR #3170:
URL: https://github.com/apache/celeborn/pull/3170#issuecomment-2817929804

   This PR can be closed for the features has already been implemented by [CELEBORN-1955](https://issues.apache.org/jira/projects/CELEBORN/issues/CELEBORN-1955) and  [CELEBORN-1962](https://issues.apache.org/jira/projects/CELEBORN/issues/CELEBORN-1962). Now one can configure nodeSelector/tolerations by `master.nodeSelector`/`worker.nodeSelector` and `master.tolerations`/`worker.tolerations`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1926] updated helmChart to allow different nodeSelector and tolerations for master and worker nodes [celeborn]

Posted by "jesusch (via GitHub)" <gi...@apache.org>.
jesusch commented on PR #3170:
URL: https://github.com/apache/celeborn/pull/3170#issuecomment-2766350285

   @ChenYi015 appreciated. Do you need help splitting those up?
   as CELEBORN-1900 is now on main we should also use the following image
   https://hub.docker.com/r/apache/celeborn


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1926] updated helmChart to allow different nodeSelector and tolerations for master and worker nodes [celeborn]

Posted by "jesusch (via GitHub)" <gi...@apache.org>.
jesusch commented on PR #3170:
URL: https://github.com/apache/celeborn/pull/3170#issuecomment-2752385475

   @SteNicholas pushed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1926] updated helmChart to allow different nodeSelector and tolerations for master and worker nodes [celeborn]

Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong closed pull request #3170: [CELEBORN-1926] updated helmChart to allow different nodeSelector and tolerations for master and worker nodes
URL: https://github.com/apache/celeborn/pull/3170


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1926] updated helmChart to allow different nodeSelector and tolerations for master and worker nodes [celeborn]

Posted by "ChenYi015 (via GitHub)" <gi...@apache.org>.
ChenYi015 commented on PR #3170:
URL: https://github.com/apache/celeborn/pull/3170#issuecomment-2765330498

   Hi @SteNicholas @jesusch I have a closed PR #2654 should fix this and currently I am working on splitting this PR into several samller ones. And I want to unify the values naming, e.g. valued related to master will be prefixed with `master.` (e.g. `master.replicas`, `master.nodeSelector` and `master.tolerations`) and values related to worker will be prefixed with `worker.` (e.g. `worker.replicas`, `worker.nodeSelector` and `worker.tolerations`).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org