[GitHub] [arrow] jorisvandenbossche commented on pull request #34797: GH-34796: [C++] Add FromTensor, ToTensor and strides methods to FixedShapeTensorArray

["jorisvandenbossche (via GitHub)" <gi...@apache.org>]

jorisvandenbossche commented on PR #34797:
URL: https://github.com/apache/arrow/pull/34797#issuecomment-1497050447

   In my last review of #8510 before splitting it (https://github.com/apache/arrow/pull/8510#pullrequestreview-1360738892), I still had some comments/questions on the FromTensor/ToTensor implementation. I am assuming that nothing fundamentally changed here (just split off what was at that point in that PR?). 
   Can you take a look at those comments and respond to them? Especially the comments about the resulting shape of FromTensor (https://github.com/apache/arrow/pull/8510#discussion_r1150406865, https://github.com/apache/arrow/pull/8510#discussion_r1150413305; you answered then that this was resolved because of permutation `shape_`, but that's no longer the case). It might be that you addressed those comments, but that's hard to see if you don't explicitly explain what you changed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org