[GitHub] [arrow-ballista] thinkharderdev commented on a diff in pull request #687: Add ShuffleWriter trait

["thinkharderdev (via GitHub)" <gi...@apache.org>]

thinkharderdev commented on code in PR #687:
URL: https://github.com/apache/arrow-ballista/pull/687#discussion_r1118642954


##########
ballista/core/src/execution_plans/shuffle_writer.rs:
##########
@@ -288,6 +305,22 @@ impl ShuffleWriterExec {
     }
 }
 
+#[async_trait]
+impl ShuffleWriter for ShuffleWriterExec {

Review Comment:
   This seems inverted to me. Shouldn't `ShuffleWriterExec` have a `Arc<dyn ShuffleWriter>` instead of impl the trait? 
   
   I know this is a step toward the pluggable execution engine, but also thinking about how this fits with allowing for different shuffle methods (write to disk, write to object store, stream to network, etc.) and seems like we would need a second layer of indirection for that. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org