[GitHub] [flink] snuyanzin commented on a change in pull request #17542: [FLINK-17782] Add array,map,row types support for parquet row writer

[GitBox <gi...@apache.org>]

snuyanzin commented on a change in pull request #17542:
URL: https://github.com/apache/flink/pull/17542#discussion_r735575324



##########
File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java
##########
@@ -126,13 +134,27 @@ private FieldWriter createWriter(LogicalType t, Type type) {
                     throw new UnsupportedOperationException("Unsupported type: " + type);
             }
         } else {
-            throw new IllegalArgumentException("Unsupported  data type: " + t);
+            GroupType groupType = type.asGroupType();
+            LogicalTypeAnnotation logicalType = type.getLogicalTypeAnnotation();
+
+            if (t instanceof ArrayType
+                    && logicalType instanceof LogicalTypeAnnotation.ListLogicalTypeAnnotation) {
+                return new ArrayWriter(((ArrayType) t).getElementType(), groupType);
+            } else if (t instanceof MapType
+                    && logicalType instanceof LogicalTypeAnnotation.MapLogicalTypeAnnotation) {
+                return new MapWriter(
+                        ((MapType) t).getKeyType(), ((MapType) t).getValueType(), groupType);
+            } else {
+                return new RowWriter(t, groupType);

Review comment:
       As far as I know there is also MultisetType, should it be treated here as Row?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org