You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/28 04:50:48 UTC
[GitHub] [arrow] vibhatha opened a new pull request #12727: Minor: [C++] Remove Internal lib usage in examples
vibhatha opened a new pull request #12727:
URL: https://github.com/apache/arrow/pull/12727
Following up with another PR, realizing the internal library usage is not relevant to execution context creation. Noted that two previous examples have the same usage. Adding this minor modification to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12727: Minor: [C++] Remove Internal lib usage in examples
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12727:
URL: https://github.com/apache/arrow/pull/12727#issuecomment-1080186209
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12727: MINOR: [C++] Remove Internal lib usage in examples
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12727:
URL: https://github.com/apache/arrow/pull/12727#issuecomment-1080611428
Benchmark runs are scheduled for baseline = a2a18e951e8d038138c6f1f8c1597826805afb4c and contender = 57841a7c0ce9a4c48a9cafbc4df3f90c569ec581. 57841a7c0ce9a4c48a9cafbc4df3f90c569ec581 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5f82740dc52a423dac319d33c2a3d477...8f108edc13114154bacc1984f8e1ac84/)
[Finished :arrow_down:0.21% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/31a7ba498c484016b8175d74c4735b89...70771b8838ac4d7fb4caa283419f58f3/)
[Failed :arrow_down:0.0% :arrow_up:0.36%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/68c74a31a4024942b766be2ba0432058...73af60897d874c579e3af6d3c975ace1/)
[Finished :arrow_down:0.13% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4df378cc5fde4a86965ed6d65d63168e...dd862a05f13e4661a129e36708a6a9f6/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12727: MINOR: [C++] Remove Internal lib usage in examples
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12727:
URL: https://github.com/apache/arrow/pull/12727#issuecomment-1080611428
Benchmark runs are scheduled for baseline = a2a18e951e8d038138c6f1f8c1597826805afb4c and contender = 57841a7c0ce9a4c48a9cafbc4df3f90c569ec581. 57841a7c0ce9a4c48a9cafbc4df3f90c569ec581 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5f82740dc52a423dac319d33c2a3d477...8f108edc13114154bacc1984f8e1ac84/)
[Finished :arrow_down:0.21% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/31a7ba498c484016b8175d74c4735b89...70771b8838ac4d7fb4caa283419f58f3/)
[Failed :arrow_down:0.0% :arrow_up:0.36%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/68c74a31a4024942b766be2ba0432058...73af60897d874c579e3af6d3c975ace1/)
[Finished :arrow_down:0.13% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4df378cc5fde4a86965ed6d65d63168e...dd862a05f13e4661a129e36708a6a9f6/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12727: MINOR: [C++] Remove Internal lib usage in examples
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12727:
URL: https://github.com/apache/arrow/pull/12727#issuecomment-1080611428
Benchmark runs are scheduled for baseline = a2a18e951e8d038138c6f1f8c1597826805afb4c and contender = 57841a7c0ce9a4c48a9cafbc4df3f90c569ec581. 57841a7c0ce9a4c48a9cafbc4df3f90c569ec581 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5f82740dc52a423dac319d33c2a3d477...8f108edc13114154bacc1984f8e1ac84/)
[Finished :arrow_down:0.21% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/31a7ba498c484016b8175d74c4735b89...70771b8838ac4d7fb4caa283419f58f3/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/68c74a31a4024942b766be2ba0432058...73af60897d874c579e3af6d3c975ace1/)
[Finished :arrow_down:0.13% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4df378cc5fde4a86965ed6d65d63168e...dd862a05f13e4661a129e36708a6a9f6/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12727: MINOR: [C++] Remove Internal lib usage in examples
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12727:
URL: https://github.com/apache/arrow/pull/12727#issuecomment-1080611428
Benchmark runs are scheduled for baseline = a2a18e951e8d038138c6f1f8c1597826805afb4c and contender = 57841a7c0ce9a4c48a9cafbc4df3f90c569ec581. 57841a7c0ce9a4c48a9cafbc4df3f90c569ec581 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5f82740dc52a423dac319d33c2a3d477...8f108edc13114154bacc1984f8e1ac84/)
[Finished :arrow_down:0.21% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/31a7ba498c484016b8175d74c4735b89...70771b8838ac4d7fb4caa283419f58f3/)
[Failed :arrow_down:4.64% :arrow_up:1.79% :warning: Contender and baseline run contexts do not match] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/68c74a31a4024942b766be2ba0432058...73af60897d874c579e3af6d3c975ace1/)
[Finished :arrow_down:0.13% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4df378cc5fde4a86965ed6d65d63168e...dd862a05f13e4661a129e36708a6a9f6/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #12727: MINOR: [C++] Remove Internal lib usage in examples
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #12727:
URL: https://github.com/apache/arrow/pull/12727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12727: MINOR: [C++] Remove Internal lib usage in examples
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12727:
URL: https://github.com/apache/arrow/pull/12727#issuecomment-1080611428
Benchmark runs are scheduled for baseline = a2a18e951e8d038138c6f1f8c1597826805afb4c and contender = 57841a7c0ce9a4c48a9cafbc4df3f90c569ec581. 57841a7c0ce9a4c48a9cafbc4df3f90c569ec581 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5f82740dc52a423dac319d33c2a3d477...8f108edc13114154bacc1984f8e1ac84/)
[Finished :arrow_down:0.21% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/31a7ba498c484016b8175d74c4735b89...70771b8838ac4d7fb4caa283419f58f3/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/68c74a31a4024942b766be2ba0432058...73af60897d874c579e3af6d3c975ace1/)
[Finished :arrow_down:0.13% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4df378cc5fde4a86965ed6d65d63168e...dd862a05f13e4661a129e36708a6a9f6/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12727: MINOR: [C++] Remove Internal lib usage in examples
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12727:
URL: https://github.com/apache/arrow/pull/12727#issuecomment-1080611428
Benchmark runs are scheduled for baseline = a2a18e951e8d038138c6f1f8c1597826805afb4c and contender = 57841a7c0ce9a4c48a9cafbc4df3f90c569ec581. 57841a7c0ce9a4c48a9cafbc4df3f90c569ec581 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5f82740dc52a423dac319d33c2a3d477...8f108edc13114154bacc1984f8e1ac84/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/31a7ba498c484016b8175d74c4735b89...70771b8838ac4d7fb4caa283419f58f3/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/68c74a31a4024942b766be2ba0432058...73af60897d874c579e3af6d3c975ace1/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4df378cc5fde4a86965ed6d65d63168e...dd862a05f13e4661a129e36708a6a9f6/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org