[GitHub] [spark] zsxwing commented on a change in pull request #23784: [SPARK-26870][SQL] Move to_avro/from_avro into functions object due to Java compatibility

[GitBox <gi...@apache.org>]

zsxwing commented on a change in pull request #23784: [SPARK-26870][SQL] Move to_avro/from_avro into functions object due to Java compatibility
URL: https://github.com/apache/spark/pull/23784#discussion_r379174414
 
 

 ##########
 File path: external/avro/src/main/scala/org/apache/spark/sql/avro/package.scala
 ##########
 @@ -34,30 +32,11 @@ package object avro {
    * @since 2.4.0
    */
   @Experimental
+  @deprecated("Please use 'org.apache.spark.sql.avro.functions.from_avro' instead.", "3.0.0")
   def from_avro(
       data: Column,
-      jsonFormatSchema: String): Column = {
-    new Column(AvroDataToCatalyst(data.expr, jsonFormatSchema, Map.empty))
-  }
-
-  /**
-   * Converts a binary column of avro format into its corresponding catalyst value. The specified
-   * schema must match the read data, otherwise the behavior is undefined: it may fail or return
-   * arbitrary result.
-   *
-   * @param data the binary column.
-   * @param jsonFormatSchema the avro schema in JSON string format.
-   * @param options options to control how the Avro record is parsed.
-   *
-   * @since 3.0.0
-   */
-  @Experimental
-  def from_avro(
 
 Review comment:
   @HyukjinKwon why did you remove this method directly rather than deprecating it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org