You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "mikelui (via GitHub)" <gi...@apache.org> on 2023/08/27 03:03:11 UTC

[GitHub] [arrow] mikelui commented on issue #37404: [C++][Python] Expose additional Cython wrap/unwrap helpers

mikelui commented on issue #37404:
URL: https://github.com/apache/arrow/issues/37404#issuecomment-1694556329

   One discussion point is RecordBatchWriter. It's implemented as: 
   
   https://github.com/apache/arrow/blob/c9bfca5ec40d30b6ae974953e2f8b12690227be2/python/pyarrow/ipc.pxi#L465-L470
   
   The internals (a single `shared_ptr<RecordBatchWriter>`) are exactly the same as RecordBatchReader, except it's name does not follow convention, and would not play nicely with existing macros. One simple path forward is to make a new Cython `RecordBatchWriter(_CRecordBatchWriter)` and then make other types inherit from that:
   
   https://github.com/apache/arrow/blob/c9bfca5ec40d30b6ae974953e2f8b12690227be2/python/pyarrow/ipc.pxi#L551-L554


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org