[jira] [Comment Edited] (CALCITE-3009) Duplicate test cases in the .xml file

["Chunwei Lei (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821691#comment-16821691 ] 

Chunwei Lei edited comment on CALCITE-3009 at 4/19/19 6:27 AM:
---------------------------------------------------------------

Update the PR including:
 * Add a {{validate}} method to check all test cases when loading the document
 * Change the commit message to "Duplicate test cases in the .xml file"

[~julianhyde] Please review the PR again when you are free.


was (Author: chunwei lei):
Update the PR including:
 * Add a {{validate}} method to check all test cases when loading the document
 * Change the commit message to "Duplicate test cases in the .xml file"

> Duplicate test cases in the .xml file
> -------------------------------------
>
>                 Key: CALCITE-3009
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3009
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.19.0
>            Reporter: Chunwei Lei
>            Assignee: Chunwei Lei
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> There are duplicate keys for {{testProjectCorrelateTranspose}} in  RelOptRulesTest.xml[1][2]. We should add a test to make it fail when having duplicate keys in a {{.xml}} file.
>  
> [1] [https://github.com/apache/calcite/blob/master/core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml#L9226]
> [2] [https://github.com/apache/calcite/blob/master/core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml#L9253]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)