You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joe Smith <ya...@gmail.com> on 2014/09/04 12:50:40 UTC
Review Request 25337: Preserve executor HealthCheckerThread name
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian Wickman.
Bugs: AURORA-682
https://issues.apache.org/jira/browse/AURORA-682
Repository: aurora
Description
-------
Preserve executor HealthCheckerThread name
Diffs
-----
src/main/python/apache/aurora/executor/common/health_checker.py 603fff35b839c6f53d9379ec047d7d8135a1c65b
src/test/python/apache/aurora/executor/common/test_health_checker.py 490d4c8b5c434f9d6f032d931e35c483b3a5b676
Diff: https://reviews.apache.org/r/25337/diff/
Testing
-------
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants ./src/test/python/apache/aurora/executor/common:health_checker
Build operating on top level addresses: set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/executor/common/BUILD, health_checker)])
==================================================================== test session starts =====================================================================
platform darwin -- Python 2.7.8 -- py-1.4.23 -- pytest-2.6.1
plugins: cov, timeout
collected 4 items
src/test/python/apache/aurora/executor/common/test_health_checker.py ....
================================================================== 4 passed in 1.54 seconds ==================================================================
src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
Tests in vagrant image
Thanks,
Joe Smith
Re: Review Request 25337: Preserve executor HealthCheckerThread name
Posted by Joe Smith <ya...@gmail.com>.
> On Sept. 4, 2014, 5:39 p.m., Zameer Manji wrote:
> > src/test/python/apache/aurora/executor/test_thermos_executor.py, line 395
> > <https://reviews.apache.org/r/25337/diff/2/?file=679158#file679158line395>
> >
> > I don't think this is supposed to be here.
whew, still pass.
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52387
-----------------------------------------------------------
On Sept. 4, 2014, 5:43 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25337/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2014, 5:43 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian Wickman.
>
>
> Bugs: AURORA-682
> https://issues.apache.org/jira/browse/AURORA-682
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Preserve executor HealthCheckerThread name
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/health_checker.py 603fff35b839c6f53d9379ec047d7d8135a1c65b
> src/test/python/apache/aurora/executor/common/BUILD 3229facf40070929adabb57fef667ab11bf3d1ec
> src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION
> src/test/python/apache/aurora/executor/common/test_health_checker.py 490d4c8b5c434f9d6f032d931e35c483b3a5b676
> src/test/python/apache/aurora/executor/common/test_task_info.py 344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632
>
> Diff: https://reviews.apache.org/r/25337/diff/
>
>
> Testing
> -------
>
> ###STILL RUNNING E2E TESTS
>
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/isort-run
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/checkstyle-check
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants ./src/test/python/apache/aurora/executor:all
> src.test.python.apache.aurora.executor.common.announcer ..... SUCCESS
> src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
> src.test.python.apache.aurora.executor.common.executor_timeout ..... SUCCESS
> src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
> src.test.python.apache.aurora.executor.gc_executor ..... SUCCESS
> src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
> src.test.python.apache.aurora.executor.thermos_executor ..... SUCCESS
> src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 25337: Preserve executor HealthCheckerThread name
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52387
-----------------------------------------------------------
src/test/python/apache/aurora/executor/test_thermos_executor.py
<https://reviews.apache.org/r/25337/#comment91167>
I don't think this is supposed to be here.
- Zameer Manji
On Sept. 4, 2014, 5:24 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25337/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2014, 5:24 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian Wickman.
>
>
> Bugs: AURORA-682
> https://issues.apache.org/jira/browse/AURORA-682
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Preserve executor HealthCheckerThread name
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/health_checker.py 603fff35b839c6f53d9379ec047d7d8135a1c65b
> src/test/python/apache/aurora/executor/common/BUILD 3229facf40070929adabb57fef667ab11bf3d1ec
> src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION
> src/test/python/apache/aurora/executor/common/test_health_checker.py 490d4c8b5c434f9d6f032d931e35c483b3a5b676
> src/test/python/apache/aurora/executor/common/test_task_info.py 344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632
> src/test/python/apache/aurora/executor/test_thermos_executor.py f6ca4dfd0fd262361709361c48c93799837e0a54
>
> Diff: https://reviews.apache.org/r/25337/diff/
>
>
> Testing
> -------
>
> ###STILL RUNNING E2E TESTS
>
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/isort-run
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/checkstyle-check
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants ./src/test/python/apache/aurora/executor:all
> src.test.python.apache.aurora.executor.common.announcer ..... SUCCESS
> src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
> src.test.python.apache.aurora.executor.common.executor_timeout ..... SUCCESS
> src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
> src.test.python.apache.aurora.executor.gc_executor ..... SUCCESS
> src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
> src.test.python.apache.aurora.executor.thermos_executor ..... SUCCESS
> src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 25337: Preserve executor HealthCheckerThread name
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/
-----------------------------------------------------------
(Updated Sept. 5, 2014, 9:32 a.m.)
Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian Wickman.
Changes
-------
Checkstyle
Bugs: AURORA-682
https://issues.apache.org/jira/browse/AURORA-682
Repository: aurora
Description
-------
Preserve executor HealthCheckerThread name
Diffs (updated)
-----
src/main/python/apache/aurora/executor/common/health_checker.py 603fff35b839c6f53d9379ec047d7d8135a1c65b
src/test/python/apache/aurora/executor/common/BUILD 3229facf40070929adabb57fef667ab11bf3d1ec
src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION
src/test/python/apache/aurora/executor/common/test_health_checker.py 490d4c8b5c434f9d6f032d931e35c483b3a5b676
src/test/python/apache/aurora/executor/common/test_task_info.py 344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632
Diff: https://reviews.apache.org/r/25337/diff/
Testing
-------
###STILL RUNNING E2E TESTS
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/isort-run
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/checkstyle-check
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants ./src/test/python/apache/aurora/executor:all
src.test.python.apache.aurora.executor.common.announcer ..... SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_timeout ..... SUCCESS
src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.gc_executor ..... SUCCESS
src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_executor ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
Thanks,
Joe Smith
Re: Review Request 25337: Preserve executor HealthCheckerThread name
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52465
-----------------------------------------------------------
Ship it!
awesome joe. thanks for doing this.
- Brian Wickman
On Sept. 5, 2014, 3 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25337/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2014, 3 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian Wickman.
>
>
> Bugs: AURORA-682
> https://issues.apache.org/jira/browse/AURORA-682
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Preserve executor HealthCheckerThread name
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/health_checker.py 603fff35b839c6f53d9379ec047d7d8135a1c65b
> src/test/python/apache/aurora/executor/common/BUILD 3229facf40070929adabb57fef667ab11bf3d1ec
> src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION
> src/test/python/apache/aurora/executor/common/test_health_checker.py 490d4c8b5c434f9d6f032d931e35c483b3a5b676
> src/test/python/apache/aurora/executor/common/test_task_info.py 344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632
>
> Diff: https://reviews.apache.org/r/25337/diff/
>
>
> Testing
> -------
>
> ###STILL RUNNING E2E TESTS
>
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/isort-run
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/checkstyle-check
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants ./src/test/python/apache/aurora/executor:all
> src.test.python.apache.aurora.executor.common.announcer ..... SUCCESS
> src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
> src.test.python.apache.aurora.executor.common.executor_timeout ..... SUCCESS
> src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
> src.test.python.apache.aurora.executor.gc_executor ..... SUCCESS
> src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
> src.test.python.apache.aurora.executor.thermos_executor ..... SUCCESS
> src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 25337: Preserve executor HealthCheckerThread name
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/
-----------------------------------------------------------
(Updated Sept. 4, 2014, 8 p.m.)
Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian Wickman.
Changes
-------
dRob's suggestions
Bugs: AURORA-682
https://issues.apache.org/jira/browse/AURORA-682
Repository: aurora
Description
-------
Preserve executor HealthCheckerThread name
Diffs (updated)
-----
src/main/python/apache/aurora/executor/common/health_checker.py 603fff35b839c6f53d9379ec047d7d8135a1c65b
src/test/python/apache/aurora/executor/common/BUILD 3229facf40070929adabb57fef667ab11bf3d1ec
src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION
src/test/python/apache/aurora/executor/common/test_health_checker.py 490d4c8b5c434f9d6f032d931e35c483b3a5b676
src/test/python/apache/aurora/executor/common/test_task_info.py 344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632
Diff: https://reviews.apache.org/r/25337/diff/
Testing
-------
###STILL RUNNING E2E TESTS
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/isort-run
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/checkstyle-check
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants ./src/test/python/apache/aurora/executor:all
src.test.python.apache.aurora.executor.common.announcer ..... SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_timeout ..... SUCCESS
src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.gc_executor ..... SUCCESS
src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_executor ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
Thanks,
Joe Smith
Re: Review Request 25337: Preserve executor HealthCheckerThread name
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52397
-----------------------------------------------------------
Ship it!
lgtm.
- David McLaughlin
On Sept. 5, 2014, 1:20 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25337/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2014, 1:20 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian Wickman.
>
>
> Bugs: AURORA-682
> https://issues.apache.org/jira/browse/AURORA-682
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Preserve executor HealthCheckerThread name
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/health_checker.py 603fff35b839c6f53d9379ec047d7d8135a1c65b
> src/test/python/apache/aurora/executor/common/BUILD 3229facf40070929adabb57fef667ab11bf3d1ec
> src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION
> src/test/python/apache/aurora/executor/common/test_health_checker.py 490d4c8b5c434f9d6f032d931e35c483b3a5b676
> src/test/python/apache/aurora/executor/common/test_task_info.py 344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632
>
> Diff: https://reviews.apache.org/r/25337/diff/
>
>
> Testing
> -------
>
> ###STILL RUNNING E2E TESTS
>
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/isort-run
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/checkstyle-check
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants ./src/test/python/apache/aurora/executor:all
> src.test.python.apache.aurora.executor.common.announcer ..... SUCCESS
> src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
> src.test.python.apache.aurora.executor.common.executor_timeout ..... SUCCESS
> src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
> src.test.python.apache.aurora.executor.gc_executor ..... SUCCESS
> src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
> src.test.python.apache.aurora.executor.thermos_executor ..... SUCCESS
> src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 25337: Preserve executor HealthCheckerThread name
Posted by Joe Smith <ya...@gmail.com>.
> On Sept. 4, 2014, 6:23 p.m., David Robinson wrote:
> > src/test/python/apache/aurora/executor/common/test_health_checker.py, line 60
> > <https://reviews.apache.org/r/25337/diff/3/?file=679164#file679164line60>
> >
> > Why do you need to cast num_calls?
leftover from the previous test (I believe), thanks
> On Sept. 4, 2014, 6:23 p.m., David Robinson wrote:
> > src/main/python/apache/aurora/executor/common/health_checker.py, lines 28-30
> > <https://reviews.apache.org/r/25337/diff/3/?file=679161#file679161line28>
> >
> > Docstring, one variable per line so the style is consistent, and perhaps change the order so it's consistent with HealthChecker()? eg, s/ initial_interval_secs, interval_secs/ interval_secs, initial_interval_secs/ and update the caller to match.
Let me know if this is what you had in mind!
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52395
-----------------------------------------------------------
On Sept. 4, 2014, 8 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25337/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2014, 8 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian Wickman.
>
>
> Bugs: AURORA-682
> https://issues.apache.org/jira/browse/AURORA-682
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Preserve executor HealthCheckerThread name
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/health_checker.py 603fff35b839c6f53d9379ec047d7d8135a1c65b
> src/test/python/apache/aurora/executor/common/BUILD 3229facf40070929adabb57fef667ab11bf3d1ec
> src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION
> src/test/python/apache/aurora/executor/common/test_health_checker.py 490d4c8b5c434f9d6f032d931e35c483b3a5b676
> src/test/python/apache/aurora/executor/common/test_task_info.py 344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632
>
> Diff: https://reviews.apache.org/r/25337/diff/
>
>
> Testing
> -------
>
> ###STILL RUNNING E2E TESTS
>
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/isort-run
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/checkstyle-check
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants ./src/test/python/apache/aurora/executor:all
> src.test.python.apache.aurora.executor.common.announcer ..... SUCCESS
> src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
> src.test.python.apache.aurora.executor.common.executor_timeout ..... SUCCESS
> src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
> src.test.python.apache.aurora.executor.gc_executor ..... SUCCESS
> src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
> src.test.python.apache.aurora.executor.thermos_executor ..... SUCCESS
> src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 25337: Preserve executor HealthCheckerThread name
Posted by David Robinson <dr...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52395
-----------------------------------------------------------
Ship it!
src/main/python/apache/aurora/executor/common/health_checker.py
<https://reviews.apache.org/r/25337/#comment91188>
Docstring, one variable per line so the style is consistent, and perhaps change the order so it's consistent with HealthChecker()? eg, s/ initial_interval_secs, interval_secs/ interval_secs, initial_interval_secs/ and update the caller to match.
src/test/python/apache/aurora/executor/common/test_health_checker.py
<https://reviews.apache.org/r/25337/#comment91190>
Why do you need to cast num_calls?
- David Robinson
On Sept. 5, 2014, 1:20 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25337/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2014, 1:20 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian Wickman.
>
>
> Bugs: AURORA-682
> https://issues.apache.org/jira/browse/AURORA-682
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Preserve executor HealthCheckerThread name
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/health_checker.py 603fff35b839c6f53d9379ec047d7d8135a1c65b
> src/test/python/apache/aurora/executor/common/BUILD 3229facf40070929adabb57fef667ab11bf3d1ec
> src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION
> src/test/python/apache/aurora/executor/common/test_health_checker.py 490d4c8b5c434f9d6f032d931e35c483b3a5b676
> src/test/python/apache/aurora/executor/common/test_task_info.py 344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632
>
> Diff: https://reviews.apache.org/r/25337/diff/
>
>
> Testing
> -------
>
> ###STILL RUNNING E2E TESTS
>
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/isort-run
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/checkstyle-check
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants ./src/test/python/apache/aurora/executor:all
> src.test.python.apache.aurora.executor.common.announcer ..... SUCCESS
> src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
> src.test.python.apache.aurora.executor.common.executor_timeout ..... SUCCESS
> src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
> src.test.python.apache.aurora.executor.gc_executor ..... SUCCESS
> src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
> src.test.python.apache.aurora.executor.thermos_executor ..... SUCCESS
> src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 25337: Preserve executor HealthCheckerThread name
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/
-----------------------------------------------------------
(Updated Sept. 4, 2014, 6:20 p.m.)
Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian Wickman.
Changes
-------
Wickman's suggestions
Bugs: AURORA-682
https://issues.apache.org/jira/browse/AURORA-682
Repository: aurora
Description
-------
Preserve executor HealthCheckerThread name
Diffs (updated)
-----
src/main/python/apache/aurora/executor/common/health_checker.py 603fff35b839c6f53d9379ec047d7d8135a1c65b
src/test/python/apache/aurora/executor/common/BUILD 3229facf40070929adabb57fef667ab11bf3d1ec
src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION
src/test/python/apache/aurora/executor/common/test_health_checker.py 490d4c8b5c434f9d6f032d931e35c483b3a5b676
src/test/python/apache/aurora/executor/common/test_task_info.py 344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632
Diff: https://reviews.apache.org/r/25337/diff/
Testing
-------
###STILL RUNNING E2E TESTS
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/isort-run
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/checkstyle-check
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants ./src/test/python/apache/aurora/executor:all
src.test.python.apache.aurora.executor.common.announcer ..... SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_timeout ..... SUCCESS
src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.gc_executor ..... SUCCESS
src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_executor ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
Thanks,
Joe Smith
Re: Review Request 25337: Preserve executor HealthCheckerThread name
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52393
-----------------------------------------------------------
Ship it!
LGTM mod HttpSignaler mocking.
- Maxim Khutornenko
On Sept. 5, 2014, 12:43 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25337/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2014, 12:43 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian Wickman.
>
>
> Bugs: AURORA-682
> https://issues.apache.org/jira/browse/AURORA-682
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Preserve executor HealthCheckerThread name
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/health_checker.py 603fff35b839c6f53d9379ec047d7d8135a1c65b
> src/test/python/apache/aurora/executor/common/BUILD 3229facf40070929adabb57fef667ab11bf3d1ec
> src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION
> src/test/python/apache/aurora/executor/common/test_health_checker.py 490d4c8b5c434f9d6f032d931e35c483b3a5b676
> src/test/python/apache/aurora/executor/common/test_task_info.py 344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632
>
> Diff: https://reviews.apache.org/r/25337/diff/
>
>
> Testing
> -------
>
> ###STILL RUNNING E2E TESTS
>
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/isort-run
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/checkstyle-check
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants ./src/test/python/apache/aurora/executor:all
> src.test.python.apache.aurora.executor.common.announcer ..... SUCCESS
> src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
> src.test.python.apache.aurora.executor.common.executor_timeout ..... SUCCESS
> src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
> src.test.python.apache.aurora.executor.gc_executor ..... SUCCESS
> src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
> src.test.python.apache.aurora.executor.thermos_executor ..... SUCCESS
> src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 25337: Preserve executor HealthCheckerThread name
Posted by Joe Smith <ya...@gmail.com>.
> On Sept. 4, 2014, 5:50 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/executor/common/health_checker.py, lines 131-132
> > <https://reviews.apache.org/r/25337/diff/2/?file=679153#file679153line131>
> >
> > make _healthy and _reason non-private
done
> On Sept. 4, 2014, 5:50 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/executor/common/health_checker.py, line 136
> > <https://reviews.apache.org/r/25337/diff/2/?file=679153#file679153line136>
> >
> > super(HealthChecker, self).start()
done
> On Sept. 4, 2014, 5:50 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/executor/common/health_checker.py, line 141
> > <https://reviews.apache.org/r/25337/diff/2/?file=679153#file679153line141>
> >
> > think you'll need an extra newline here for checkstyle to not complain
done
> On Sept. 4, 2014, 5:50 p.m., Brian Wickman wrote:
> > src/test/python/apache/aurora/executor/common/test_health_checker.py, line 188
> > <https://reviews.apache.org/r/25337/diff/2/?file=679156#file679156line188>
> >
> > the + is superfluous
done
> On Sept. 4, 2014, 5:50 p.m., Brian Wickman wrote:
> > src/test/python/apache/aurora/executor/test_thermos_executor.py, line 395
> > <https://reviews.apache.org/r/25337/diff/2/?file=679158#file679158line395>
> >
> > derp?
should be updated already, thanks
> On Sept. 4, 2014, 5:50 p.m., Brian Wickman wrote:
> > src/test/python/apache/aurora/executor/common/test_health_checker.py, line 171
> > <https://reviews.apache.org/r/25337/diff/2/?file=679156#file679156line171>
> >
> > all of these attributes should likely be public or read-only properties of private attributes
done
> On Sept. 4, 2014, 5:50 p.m., Brian Wickman wrote:
> > src/test/python/apache/aurora/executor/common/test_health_checker.py, line 158
> > <https://reviews.apache.org/r/25337/diff/2/?file=679156#file679156line158>
> >
> > please obtain an ephemeral port here instead. who is to say that port 9001 is not running a service that accepts the health check protocol? or at the very least, create a mock HttpSignaler
mocked
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52389
-----------------------------------------------------------
On Sept. 4, 2014, 6:20 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25337/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2014, 6:20 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian Wickman.
>
>
> Bugs: AURORA-682
> https://issues.apache.org/jira/browse/AURORA-682
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Preserve executor HealthCheckerThread name
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/health_checker.py 603fff35b839c6f53d9379ec047d7d8135a1c65b
> src/test/python/apache/aurora/executor/common/BUILD 3229facf40070929adabb57fef667ab11bf3d1ec
> src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION
> src/test/python/apache/aurora/executor/common/test_health_checker.py 490d4c8b5c434f9d6f032d931e35c483b3a5b676
> src/test/python/apache/aurora/executor/common/test_task_info.py 344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632
>
> Diff: https://reviews.apache.org/r/25337/diff/
>
>
> Testing
> -------
>
> ###STILL RUNNING E2E TESTS
>
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/isort-run
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/checkstyle-check
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants ./src/test/python/apache/aurora/executor:all
> src.test.python.apache.aurora.executor.common.announcer ..... SUCCESS
> src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
> src.test.python.apache.aurora.executor.common.executor_timeout ..... SUCCESS
> src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
> src.test.python.apache.aurora.executor.gc_executor ..... SUCCESS
> src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
> src.test.python.apache.aurora.executor.thermos_executor ..... SUCCESS
> src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 25337: Preserve executor HealthCheckerThread name
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52389
-----------------------------------------------------------
\m/
src/main/python/apache/aurora/executor/common/health_checker.py
<https://reviews.apache.org/r/25337/#comment91170>
make _healthy and _reason non-private
src/main/python/apache/aurora/executor/common/health_checker.py
<https://reviews.apache.org/r/25337/#comment91171>
super(HealthChecker, self).start()
src/main/python/apache/aurora/executor/common/health_checker.py
<https://reviews.apache.org/r/25337/#comment91172>
think you'll need an extra newline here for checkstyle to not complain
src/test/python/apache/aurora/executor/common/test_health_checker.py
<https://reviews.apache.org/r/25337/#comment91174>
please obtain an ephemeral port here instead. who is to say that port 9001 is not running a service that accepts the health check protocol? or at the very least, create a mock HttpSignaler
src/test/python/apache/aurora/executor/common/test_health_checker.py
<https://reviews.apache.org/r/25337/#comment91175>
all of these attributes should likely be public or read-only properties of private attributes
src/test/python/apache/aurora/executor/common/test_health_checker.py
<https://reviews.apache.org/r/25337/#comment91173>
the + is superfluous
src/test/python/apache/aurora/executor/test_thermos_executor.py
<https://reviews.apache.org/r/25337/#comment91176>
derp?
- Brian Wickman
On Sept. 5, 2014, 12:43 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25337/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2014, 12:43 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian Wickman.
>
>
> Bugs: AURORA-682
> https://issues.apache.org/jira/browse/AURORA-682
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Preserve executor HealthCheckerThread name
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/health_checker.py 603fff35b839c6f53d9379ec047d7d8135a1c65b
> src/test/python/apache/aurora/executor/common/BUILD 3229facf40070929adabb57fef667ab11bf3d1ec
> src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION
> src/test/python/apache/aurora/executor/common/test_health_checker.py 490d4c8b5c434f9d6f032d931e35c483b3a5b676
> src/test/python/apache/aurora/executor/common/test_task_info.py 344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632
>
> Diff: https://reviews.apache.org/r/25337/diff/
>
>
> Testing
> -------
>
> ###STILL RUNNING E2E TESTS
>
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/isort-run
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/checkstyle-check
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants ./src/test/python/apache/aurora/executor:all
> src.test.python.apache.aurora.executor.common.announcer ..... SUCCESS
> src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
> src.test.python.apache.aurora.executor.common.executor_timeout ..... SUCCESS
> src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
> src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS
> src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
> src.test.python.apache.aurora.executor.gc_executor ..... SUCCESS
> src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
> src.test.python.apache.aurora.executor.thermos_executor ..... SUCCESS
> src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 25337: Preserve executor HealthCheckerThread name
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/
-----------------------------------------------------------
(Updated Sept. 4, 2014, 5:43 p.m.)
Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian Wickman.
Changes
-------
Great catch Zameer!
[tw-172-25-20-192 aurora (yasumoto/fix_health_checker_name)]$ ./pants ./src/test/python/apache/aurora/executor:thermos_executor
Build operating on top level addresses: set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/executor/BUILD, thermos_executor)])
==================================================================================================================================================== test session starts =====================================================================================================================================================
platform darwin -- Python 2.7.8 -- py-1.4.23 -- pytest-2.6.1
plugins: cov, timeout
collected 15 items
src/test/python/apache/aurora/executor/test_thermos_executor.py ...............
================================================================================================================================================= 15 passed in 38.03 seconds =================================================================================================================================================
src.test.python.apache.aurora.executor.thermos_executor ..... SUCCESS
Bugs: AURORA-682
https://issues.apache.org/jira/browse/AURORA-682
Repository: aurora
Description
-------
Preserve executor HealthCheckerThread name
Diffs (updated)
-----
src/main/python/apache/aurora/executor/common/health_checker.py 603fff35b839c6f53d9379ec047d7d8135a1c65b
src/test/python/apache/aurora/executor/common/BUILD 3229facf40070929adabb57fef667ab11bf3d1ec
src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION
src/test/python/apache/aurora/executor/common/test_health_checker.py 490d4c8b5c434f9d6f032d931e35c483b3a5b676
src/test/python/apache/aurora/executor/common/test_task_info.py 344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632
Diff: https://reviews.apache.org/r/25337/diff/
Testing
-------
###STILL RUNNING E2E TESTS
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/isort-run
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/checkstyle-check
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants ./src/test/python/apache/aurora/executor:all
src.test.python.apache.aurora.executor.common.announcer ..... SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_timeout ..... SUCCESS
src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.gc_executor ..... SUCCESS
src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_executor ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
Thanks,
Joe Smith
Re: Review Request 25337: Preserve executor HealthCheckerThread name
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/
-----------------------------------------------------------
(Updated Sept. 4, 2014, 5:24 p.m.)
Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian Wickman.
Bugs: AURORA-682
https://issues.apache.org/jira/browse/AURORA-682
Repository: aurora
Description
-------
Preserve executor HealthCheckerThread name
Diffs (updated)
-----
src/main/python/apache/aurora/executor/common/health_checker.py 603fff35b839c6f53d9379ec047d7d8135a1c65b
src/test/python/apache/aurora/executor/common/BUILD 3229facf40070929adabb57fef667ab11bf3d1ec
src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION
src/test/python/apache/aurora/executor/common/test_health_checker.py 490d4c8b5c434f9d6f032d931e35c483b3a5b676
src/test/python/apache/aurora/executor/common/test_task_info.py 344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632
src/test/python/apache/aurora/executor/test_thermos_executor.py f6ca4dfd0fd262361709361c48c93799837e0a54
Diff: https://reviews.apache.org/r/25337/diff/
Testing (updated)
-------
###STILL RUNNING E2E TESTS
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/isort-run
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/checkstyle-check
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants ./src/test/python/apache/aurora/executor:all
src.test.python.apache.aurora.executor.common.announcer ..... SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_timeout ..... SUCCESS
src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.gc_executor ..... SUCCESS
src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_executor ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
Thanks,
Joe Smith
Re: Review Request 25337: Preserve executor HealthCheckerThread name
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52332
-----------------------------------------------------------
Discussed offline but it probably makes sense to not do any status checkers subclassed directly from threading.Thread. instead, the threads should be attributes on the health checkers and started when .start() is called.
- Brian Wickman
On Sept. 4, 2014, 10:50 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25337/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2014, 10:50 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian Wickman.
>
>
> Bugs: AURORA-682
> https://issues.apache.org/jira/browse/AURORA-682
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Preserve executor HealthCheckerThread name
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/health_checker.py 603fff35b839c6f53d9379ec047d7d8135a1c65b
> src/test/python/apache/aurora/executor/common/test_health_checker.py 490d4c8b5c434f9d6f032d931e35c483b3a5b676
>
> Diff: https://reviews.apache.org/r/25337/diff/
>
>
> Testing
> -------
>
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants ./src/test/python/apache/aurora/executor/common:health_checker
> Build operating on top level addresses: set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/executor/common/BUILD, health_checker)])
> ==================================================================== test session starts =====================================================================
> platform darwin -- Python 2.7.8 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 4 items
>
> src/test/python/apache/aurora/executor/common/test_health_checker.py ....
>
> ================================================================== 4 passed in 1.54 seconds ==================================================================
> src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
>
> Tests in vagrant image
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 25337: Preserve executor HealthCheckerThread name
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52318
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Sept. 4, 2014, 3:50 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25337/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2014, 3:50 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian Wickman.
>
>
> Bugs: AURORA-682
> https://issues.apache.org/jira/browse/AURORA-682
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Preserve executor HealthCheckerThread name
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/health_checker.py 603fff35b839c6f53d9379ec047d7d8135a1c65b
> src/test/python/apache/aurora/executor/common/test_health_checker.py 490d4c8b5c434f9d6f032d931e35c483b3a5b676
>
> Diff: https://reviews.apache.org/r/25337/diff/
>
>
> Testing
> -------
>
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants ./src/test/python/apache/aurora/executor/common:health_checker
> Build operating on top level addresses: set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/executor/common/BUILD, health_checker)])
> ==================================================================== test session starts =====================================================================
> platform darwin -- Python 2.7.8 -- py-1.4.23 -- pytest-2.6.1
> plugins: cov, timeout
> collected 4 items
>
> src/test/python/apache/aurora/executor/common/test_health_checker.py ....
>
> ================================================================== 4 passed in 1.54 seconds ==================================================================
> src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
>
> Tests in vagrant image
>
>
> Thanks,
>
> Joe Smith
>
>