You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2017/05/26 10:28:34 UTC
Review Request 59605: Use glog for logging in executors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59605/
-----------------------------------------------------------
Review request for mesos and Alexander Rukletsov.
Bugs: MESOS-6961
https://issues.apache.org/jira/browse/MESOS-6961
Repository: mesos
Description
-------
Use glog for logging in executors.
Diffs
-----
src/docker/executor.cpp 464a74859e0f477ec2e5525a5fc726ea420a00a2
src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574
src/launcher/executor.cpp 9ac3c3d84c0ec47954c5c72228ad0b8795ff3eec
Diff: https://reviews.apache.org/r/59605/diff/1/
Testing
-------
1. make check (mac os x 10.12, fedora 25)
2. jenkins: https://jenkins.mesosphere.com/service/jenkins/job/mesos/job/Mesos_CI-build/1087/
3. I've modified NoTaskKillingCapability from command_executor_tests.cpp to launch command "sleep 0.1" (as well as "sleep 0"),
then to wait for a task completion. The test was launched in an endless loop:
GLOG_v=1 ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter="HTTPCommandExecutor/CommandExecutorTest.NoTaskKillingCapability/0" --verbose
I've run this test multiple times for a while both on mac os and linux (gru1.hw.ca1.mesosphere.com).
Race condition problem described in a jira ticket wasn't reproduced.
Thanks,
Andrei Budnik
Re: Review Request 59605: Use glog for logging in executors.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59605/#review176192
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59605]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 26, 2017, 10:28 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59605/
> -----------------------------------------------------------
>
> (Updated May 26, 2017, 10:28 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-6961
> https://issues.apache.org/jira/browse/MESOS-6961
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Use glog for logging in executors.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp 464a74859e0f477ec2e5525a5fc726ea420a00a2
> src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574
> src/launcher/executor.cpp 9ac3c3d84c0ec47954c5c72228ad0b8795ff3eec
>
>
> Diff: https://reviews.apache.org/r/59605/diff/1/
>
>
> Testing
> -------
>
> 1. make check (mac os x 10.12, fedora 25)
> 2. jenkins: https://jenkins.mesosphere.com/service/jenkins/job/mesos/job/Mesos_CI-build/1087/
>
> 3. I've modified NoTaskKillingCapability from command_executor_tests.cpp to launch command "sleep 0.1" (as well as "sleep 0"),
> then to wait for a task completion. The test was launched in an endless loop:
>
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter="HTTPCommandExecutor/CommandExecutorTest.NoTaskKillingCapability/0" --verbose
>
> I've run this test multiple times for a while both on mac os and linux (gru1.hw.ca1.mesosphere.com).
> Race condition problem described in a jira ticket wasn't reproduced.
>
>
> Thanks,
>
> Andrei Budnik
>
>