You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/01/22 00:15:26 UTC
Review Request 17161: Update all dependencies coming from twitter commons.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17161/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Repository: aurora
Description
-------
Update all dependencies coming from twitter commons.
Diffs
-----
build.gradle 00cabb00b81b320ef2c474da759281b3fda24967
Diff: https://reviews.apache.org/r/17161/diff/
Testing
-------
./gradlew build
I also inspected the output of ./gradlew dependencies to verify that there are no new dependency conflicts.
Thanks,
Bill Farner
Re: Review Request 17161: Update all dependencies coming from twitter
commons and upgrade to guava 15
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17161/#review32457
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Jan. 21, 2014, 11:18 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17161/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2014, 11:18 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Stale twitter-commons dependencies were preventing us from upgrading to the latest guava. This update cleanly moves us forward without dependency conflict.
>
>
> Diffs
> -----
>
> build.gradle 00cabb00b81b320ef2c474da759281b3fda24967
>
> Diff: https://reviews.apache.org/r/17161/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
> I also inspected the output of ./gradlew dependencies to verify that there are no new dependency conflicts.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 17161: Update all dependencies coming from twitter
commons and upgrade to guava 15
Posted by Bill Farner <wf...@apache.org>.
> On Jan. 21, 2014, 11:32 p.m., Kevin Sweeney wrote:
> > Thanks for taking care of this Bill.
> >
> > Aside: this seems to warrant a linked ticket (reference it on the first line of your commit so that jenkins will comment).
> reference it on the first line of your commit
I didn't realize this was wired up yet, cool! Do you mean to say that the first line of the summary/description?
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17161/#review32441
-----------------------------------------------------------
On Jan. 21, 2014, 11:18 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17161/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2014, 11:18 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Stale twitter-commons dependencies were preventing us from upgrading to the latest guava. This update cleanly moves us forward without dependency conflict.
>
>
> Diffs
> -----
>
> build.gradle 00cabb00b81b320ef2c474da759281b3fda24967
>
> Diff: https://reviews.apache.org/r/17161/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
> I also inspected the output of ./gradlew dependencies to verify that there are no new dependency conflicts.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 17161: Update all dependencies coming from twitter
commons and upgrade to guava 15
Posted by Jake Farrell <jf...@apache.org>.
> On Jan. 21, 2014, 11:32 p.m., Kevin Sweeney wrote:
> > Thanks for taking care of this Bill.
> >
> > Aside: this seems to warrant a linked ticket (reference it on the first line of your commit so that jenkins will comment).
>
> Bill Farner wrote:
> > reference it on the first line of your commit
>
> I didn't realize this was wired up yet, cool! Do you mean to say that the first line of the summary/description?
yes, commits with the first line of
AURORA-XXX: <description>
will get picked up by jenkins after running the ci build from a scm change and jenkins will comment back the success of that build on the jira ticket.
- Jake
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17161/#review32441
-----------------------------------------------------------
On Jan. 21, 2014, 11:18 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17161/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2014, 11:18 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Stale twitter-commons dependencies were preventing us from upgrading to the latest guava. This update cleanly moves us forward without dependency conflict.
>
>
> Diffs
> -----
>
> build.gradle 00cabb00b81b320ef2c474da759281b3fda24967
>
> Diff: https://reviews.apache.org/r/17161/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
> I also inspected the output of ./gradlew dependencies to verify that there are no new dependency conflicts.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 17161: Update all dependencies coming from twitter
commons and upgrade to guava 15
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17161/#review32441
-----------------------------------------------------------
Ship it!
Thanks for taking care of this Bill.
Aside: this seems to warrant a linked ticket (reference it on the first line of your commit so that jenkins will comment).
- Kevin Sweeney
On Jan. 21, 2014, 3:18 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17161/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2014, 3:18 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Stale twitter-commons dependencies were preventing us from upgrading to the latest guava. This update cleanly moves us forward without dependency conflict.
>
>
> Diffs
> -----
>
> build.gradle 00cabb00b81b320ef2c474da759281b3fda24967
>
> Diff: https://reviews.apache.org/r/17161/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
> I also inspected the output of ./gradlew dependencies to verify that there are no new dependency conflicts.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 17161: Update all dependencies coming from twitter
commons and upgrade to guava 15
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17161/
-----------------------------------------------------------
(Updated Jan. 22, 2014, 7:08 p.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Bugs: AURORA-75
https://issues.apache.org/jira/browse/AURORA-75
Repository: aurora
Description
-------
Stale twitter-commons dependencies were preventing us from upgrading to the latest guava. This update cleanly moves us forward without dependency conflict.
Diffs
-----
build.gradle 00cabb00b81b320ef2c474da759281b3fda24967
Diff: https://reviews.apache.org/r/17161/diff/
Testing
-------
./gradlew build
I also inspected the output of ./gradlew dependencies to verify that there are no new dependency conflicts.
Thanks,
Bill Farner
Re: Review Request 17161: Update all dependencies coming from twitter
commons and upgrade to guava 15
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17161/
-----------------------------------------------------------
(Updated Jan. 21, 2014, 11:18 p.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Summary (updated)
-----------------
Update all dependencies coming from twitter commons and upgrade to guava 15
Repository: aurora
Description (updated)
-------
Stale twitter-commons dependencies were preventing us from upgrading to the latest guava. This update cleanly moves us forward without dependency conflict.
Diffs
-----
build.gradle 00cabb00b81b320ef2c474da759281b3fda24967
Diff: https://reviews.apache.org/r/17161/diff/
Testing
-------
./gradlew build
I also inspected the output of ./gradlew dependencies to verify that there are no new dependency conflicts.
Thanks,
Bill Farner