You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "assignUser (via GitHub)" <gi...@apache.org> on 2023/09/29 03:17:32 UTC
[GitHub] [arrow] assignUser opened a new pull request, #37946: MINOR: [CI] Fix crossbow badge url
assignUser opened a new pull request, #37946:
URL: https://github.com/apache/arrow/pull/37946
Github has changed the badge url so all crossbow badges where showing up as grey.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on a diff in pull request #37946: MINOR: [CI][Dev] Fix crossbow badge url
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #37946:
URL: https://github.com/apache/arrow/pull/37946#discussion_r1341124796
##########
dev/archery/archery/crossbow/reports.py:
##########
@@ -284,7 +284,7 @@ class CommentReport(Report):
'github': _markdown_badge.format(
title='Github Actions',
badge=(
- 'https://github.com/{repo}/workflows/Crossbow/'
+ 'https://github.com/{repo}/actions/workflows/crossbow.yml/'
'badge.svg?branch={branch}'
Review Comment:
ok, it works if I use the correct URL: https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-635103f8ad-github-wheel-macos-mojave-cp312-amd64, my bad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on a diff in pull request #37946: MINOR: [CI][Dev] Fix crossbow badge url
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #37946:
URL: https://github.com/apache/arrow/pull/37946#discussion_r1341121386
##########
dev/archery/archery/crossbow/reports.py:
##########
@@ -284,7 +284,7 @@ class CommentReport(Report):
'github': _markdown_badge.format(
title='Github Actions',
badge=(
- 'https://github.com/{repo}/workflows/Crossbow/'
+ 'https://github.com/{repo}/actions/workflows/crossbow.yml/'
'badge.svg?branch={branch}'
Review Comment:
I am not entirely sure this will work as when I update this:
https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-635103f8ad-github-wheel-macos-mojave-cp312-amd64
to this:
https://github.com/ursacomputing/crossbow/workflows/crossbow.yml/badge.svg?branch=actions-635103f8ad-github-wheel-macos-mojave-cp312-amd64
it fails to load the badge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #37946: MINOR: [CI][Dev] Fix crossbow badge url
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #37946:
URL: https://github.com/apache/arrow/pull/37946#discussion_r1341787848
##########
dev/archery/archery/crossbow/reports.py:
##########
@@ -284,7 +284,7 @@ class CommentReport(Report):
'github': _markdown_badge.format(
title='Github Actions',
badge=(
- 'https://github.com/{repo}/workflows/Crossbow/'
+ 'https://github.com/{repo}/actions/workflows/crossbow.yml/'
'badge.svg?branch={branch}'
Review Comment:
Oh, sorry!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #37946: MINOR: [CI][Dev] Fix crossbow badge url
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #37946:
URL: https://github.com/apache/arrow/pull/37946#issuecomment-1741488925
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit c703b874417d1165b8afc0a42265d5513d5786d7.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/17267843810) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on a diff in pull request #37946: MINOR: [CI][Dev] Fix crossbow badge url
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #37946:
URL: https://github.com/apache/arrow/pull/37946#discussion_r1341122546
##########
dev/archery/archery/crossbow/reports.py:
##########
@@ -284,7 +284,7 @@ class CommentReport(Report):
'github': _markdown_badge.format(
title='Github Actions',
badge=(
- 'https://github.com/{repo}/workflows/Crossbow/'
+ 'https://github.com/{repo}/actions/workflows/crossbow.yml/'
'badge.svg?branch={branch}'
Review Comment:
oops, I see @kou just merged :)
there is an issue opened for it btw: https://github.com/apache/arrow/issues/37927
but again, I am not sure this solves the problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #37946: MINOR: [CI][Dev] Fix crossbow badge url
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #37946:
URL: https://github.com/apache/arrow/pull/37946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org