You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by hw...@apache.org on 2011/04/11 22:47:32 UTC

svn commit: r1091201 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

Author: hwright
Date: Mon Apr 11 20:47:32 2011
New Revision: 1091201

URL: http://svn.apache.org/viewvc?rev=1091201&view=rev
Log:
Remove a couple of redundant checks that we get in the DB for free.

* subversion/libsvn_wc/adm_ops.c
  (svn_wc_set_changelist2): As above.

Modified:
    subversion/trunk/subversion/libsvn_wc/adm_ops.c

Modified: subversion/trunk/subversion/libsvn_wc/adm_ops.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/adm_ops.c?rev=1091201&r1=1091200&r2=1091201&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_wc/adm_ops.c (original)
+++ subversion/trunk/subversion/libsvn_wc/adm_ops.c Mon Apr 11 20:47:32 2011
@@ -2186,21 +2186,6 @@ svn_wc_set_changelist2(svn_wc_context_t 
                              _("'%s' is a directory, and thus cannot"
                                " be a member of a changelist"), local_abspath);
 
-  /* If the path has no changelist and we're removing changelist, skip it.
-     ### the db actually does this check, too, but for notification's sake,
-     ### we add it here as well. */
-  if (! (changelist || existing_changelist))
-    return SVN_NO_ERROR;
-
-  /* If the path is already assigned to the changelist we're
-     trying to assign, skip it.
-     ### the db actually does this check, too, but for notification's sake,
-     ### we add it here as well. */
-  if (existing_changelist
-      && changelist
-      && strcmp(existing_changelist, changelist) == 0)
-    return SVN_NO_ERROR;
-
   /* Set the changelist. */
   SVN_ERR(svn_wc__db_op_set_changelist(wc_ctx->db, local_abspath, changelist,
                                        NULL, svn_depth_empty, scratch_pool));