[GitHub] rdhabalia commented on issue #900: Fix: fail create-ledger callback on ledgerId generation failure

[GitBox <gi...@apache.org>]

rdhabalia commented on issue #900: Fix: fail create-ledger callback on ledgerId generation failure
URL: https://github.com/apache/bookkeeper/pull/900#issuecomment-353236266
 
 
   > is it possible to write a simple test case for this?
   
   Actually, it will be little tricky to reach this code-path and little complicated to reproduce it by just shutting down zk because this thread first calls zk to check the [ledgerId-path](https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LongZkLedgerIdGenerator.java#L293) and if bk is not connected to zk then it fails there itself before reaching to this place for id-generation.
   In our production env, we have seen 90% exceptions while [checking ledgerId-path](https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LongZkLedgerIdGenerator.java#L293) which worked as expected and rest of them failed with this bug.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services