You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/05/21 08:19:06 UTC

[GitHub] [iotdb] Alima777 commented on a change in pull request #3246: [IOTDB-1387] [To rel/0.12] Fix Without Null ALL doesn't take effect in align by device clause

Alima777 commented on a change in pull request #3246:
URL: https://github.com/apache/iotdb/pull/3246#discussion_r636728828



##########
File path: server/src/main/java/org/apache/iotdb/db/query/dataset/AlignByDeviceDataSet.java
##########
@@ -235,6 +235,7 @@ public RowRecord nextWithoutConstraint() throws IOException {
     Field deviceField = new Field(TSDataType.TEXT);
     deviceField.setBinaryV(new Binary(currentDevice.getFullPath()));
     rowRecord.addField(deviceField);
+    rowRecord.resetNullFlag();

Review comment:
       Add comment please




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org