You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/06/07 05:22:37 UTC

Review Request 70799: Added a wrapper struct for quota guarantees and limits.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70799/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-9807
    https://issues.apache.org/jira/browse/MESOS-9807


Repository: mesos


Description
-------

This struct is temporarily named to `Quota2` to differentiate
with the existing `Quota` struct. It will replace all `Quota`
and rename to `Quota`.


Diffs
-----

  include/mesos/quota/quota.hpp b028e1286920d43fddfc2234b03290c98a51b5b7 
  src/master/quota.cpp 001c240772e72975468c930d30a90aaa62cdce53 


Diff: https://reviews.apache.org/r/70799/diff/1/


Testing
-------

make check


Thanks,

Meng Zhu


Re: Review Request 70799: Added a wrapper struct for quota guarantees and limits.

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70799/#review215813
-----------------------------------------------------------


Ship it!




- Benjamin Mahler


On June 7, 2019, 5:22 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70799/
> -----------------------------------------------------------
> 
> (Updated June 7, 2019, 5:22 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9807
>     https://issues.apache.org/jira/browse/MESOS-9807
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This struct is temporarily named to `Quota2` to differentiate
> with the existing `Quota` struct. It will replace all `Quota`
> and rename to `Quota`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.hpp b028e1286920d43fddfc2234b03290c98a51b5b7 
>   src/master/quota.cpp 001c240772e72975468c930d30a90aaa62cdce53 
> 
> 
> Diff: https://reviews.apache.org/r/70799/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>