You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/12/22 15:24:58 UTC
[GitHub] [maven-resolver] cstamas opened a new pull request, #231: [MRESOLVER-308] HTTP transport showdown.
cstamas opened a new pull request, #231:
URL: https://github.com/apache/maven-resolver/pull/231
Introduces 3 new transport: Jetty HttpClient 10.x, OkHttp 4.x and Java 11 HttpClient based ones. These are all HTTP/2 capable transports.
Also, some reshuffle around HTTP tests, made them reusable to be able to use them in all HTTP based transports.
---
https://issues.apache.org/jira/browse/MRESOLVER-308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] kwin commented on pull request #231: [MRESOLVER-308] HTTP transport showdown.
Posted by GitBox <gi...@apache.org>.
kwin commented on PR #231:
URL: https://github.com/apache/maven-resolver/pull/231#issuecomment-1364419753
Do we really want to keep maintaining that many resolver transport modules? If there is a clear winner performance wise, why not dropping the other modules? I fail to see the advantage of providing that many options...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a diff in pull request #231: [MRESOLVER-308] HTTP transport showdown.
Posted by GitBox <gi...@apache.org>.
cstamas commented on code in PR #231:
URL: https://github.com/apache/maven-resolver/pull/231#discussion_r1057309024
##########
maven-resolver-transport-jetty/src/main/java/org/eclipse/aether/transport/jetty/JettyTransporter.java:
##########
@@ -0,0 +1,539 @@
+package org.eclipse.aether.transport.jetty;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.net.ssl.SSLContext;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.URI;
+import java.net.URISyntaxException;
+import java.nio.file.Files;
+import java.nio.file.StandardCopyOption;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.TimeUnit;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import org.eclipse.aether.ConfigurationProperties;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.repository.AuthenticationContext;
+import org.eclipse.aether.repository.RemoteRepository;
+import org.eclipse.aether.spi.connector.transport.AbstractTransporter;
+import org.eclipse.aether.spi.connector.transport.GetTask;
+import org.eclipse.aether.spi.connector.transport.PeekTask;
+import org.eclipse.aether.spi.connector.transport.PutTask;
+import org.eclipse.aether.spi.connector.transport.TransportTask;
+import org.eclipse.aether.transfer.NoTransporterException;
+import org.eclipse.aether.util.ConfigUtils;
+import org.eclipse.aether.util.FileUtils;
+import org.eclipse.jetty.client.HttpClient;
+import org.eclipse.jetty.client.HttpProxy;
+import org.eclipse.jetty.client.api.Authentication;
+import org.eclipse.jetty.client.api.Request;
+import org.eclipse.jetty.client.api.Response;
+import org.eclipse.jetty.client.dynamic.HttpClientTransportDynamic;
+import org.eclipse.jetty.client.http.HttpClientConnectionFactory;
+import org.eclipse.jetty.client.util.BasicAuthentication;
+import org.eclipse.jetty.client.util.InputStreamResponseListener;
+import org.eclipse.jetty.client.util.PathRequestContent;
+import org.eclipse.jetty.http.HttpHeader;
+import org.eclipse.jetty.http2.client.HTTP2Client;
+import org.eclipse.jetty.http2.client.http.ClientConnectionFactoryOverHTTP2;
+import org.eclipse.jetty.io.ClientConnector;
+import org.eclipse.jetty.util.ssl.SslContextFactory;
+
+/**
+ * A transporter for HTTP/HTTPS.
+ */
+final class JettyTransporter
+ extends AbstractTransporter
+{
+ private static final int MULTIPLE_CHOICES = 300;
+
+ private static final int NOT_FOUND = 404;
+
+ private static final int PRECONDITION_FAILED = 412;
+
+ private static final long MODIFICATION_THRESHOLD = 60L * 1000L;
+
+ private static final String ACCEPT_ENCODING = "Accept-Encoding";
+
+ private static final String CONTENT_LENGTH = "Content-Length";
+
+ private static final String CONTENT_RANGE = "Content-Range";
+
+ private static final String IF_UNMODIFIED_SINCE = "If-Unmodified-Since";
+
+ private static final String RANGE = "Range";
+
+ private static final String USER_AGENT = "User-Agent";
+
+ private static final Pattern CONTENT_RANGE_PATTERN =
+ Pattern.compile( "\\s*bytes\\s+([0-9]+)\\s*-\\s*([0-9]+)\\s*/.*" );
+
+ private final URI baseUri;
+
+ private final HttpClient client;
+
+ private final int requestTimeout;
+
+ private final Map<String, String> headers;
+
+ JettyTransporter( RepositorySystemSession session, RemoteRepository repository ) throws NoTransporterException
+ {
+ try
+ {
+ URI uri = new URI( repository.getUrl() ).parseServerAuthority();
+ if ( uri.isOpaque() )
+ {
+ throw new URISyntaxException( repository.getUrl(), "URL must not be opaque" );
+ }
+ if ( uri.getRawFragment() != null || uri.getRawQuery() != null )
+ {
+ throw new URISyntaxException( repository.getUrl(), "URL must not have fragment or query" );
+ }
+ String path = uri.getPath();
+ if ( path == null )
+ {
+ path = "/";
+ }
+ if ( !path.startsWith( "/" ) )
+ {
+ path = "/" + path;
+ }
+ if ( !path.endsWith( "/" ) )
+ {
+ path = path + "/";
+ }
+ this.baseUri = URI.create( uri.getScheme() + "://" + uri.getRawAuthority() + path );
+ }
+ catch ( URISyntaxException e )
+ {
+ throw new NoTransporterException( repository, e.getMessage(), e );
+ }
+
+ HashMap<String, String> headers = new HashMap<>();
+ String userAgent = ConfigUtils.getString( session,
+ ConfigurationProperties.DEFAULT_USER_AGENT,
+ ConfigurationProperties.USER_AGENT );
+ if ( userAgent != null )
+ {
+ headers.put( USER_AGENT, userAgent );
+ }
+ @SuppressWarnings( "unchecked" )
+ Map<Object, Object> configuredHeaders =
+ (Map<Object, Object>) ConfigUtils.getMap( session, Collections.emptyMap(),
+ ConfigurationProperties.HTTP_HEADERS + "." + repository.getId(),
+ ConfigurationProperties.HTTP_HEADERS );
+ if ( configuredHeaders != null )
+ {
+ configuredHeaders.forEach(
+ ( k, v ) -> headers.put( String.valueOf( k ), v != null ? String.valueOf( v ) : null ) );
+ }
+
+ this.headers = headers;
+
+ this.requestTimeout = ConfigUtils.getInteger( session,
+ ConfigurationProperties.DEFAULT_REQUEST_TIMEOUT,
+ ConfigurationProperties.REQUEST_TIMEOUT + "." + repository.getId(),
+ ConfigurationProperties.REQUEST_TIMEOUT );
+
+ this.client = getOrCreateClient( session, repository );
+ }
+
+ private URI resolve( TransportTask task )
+ {
+ return baseUri.resolve( task.getLocation() );
+ }
+
+ @Override
+ public int classify( Throwable error )
+ {
+ if ( error instanceof JettyException
+ && ( (JettyException) error ).getStatusCode() == NOT_FOUND )
+ {
+ return ERROR_NOT_FOUND;
+ }
+ return ERROR_OTHER;
+ }
+
+ @Override
+ protected void implPeek( PeekTask task )
+ throws Exception
+ {
+ Request request = client.newRequest( resolve( task ) )
+ .timeout( requestTimeout, TimeUnit.MILLISECONDS )
+ .method( "HEAD" );
+ request.headers( m -> headers.forEach( m::add ) );
+ Response response = request.send();
+ if ( response.getStatus() >= MULTIPLE_CHOICES )
+ {
+ throw new JettyException( response.getStatus() );
+ }
+ }
+
+ @Override
+ protected void implGet( GetTask task )
+ throws Exception
+ {
+ boolean resume = task.getResumeOffset() > 0L && task.getDataFile() != null;
+ Response response;
+ InputStreamResponseListener listener;
+
+ while ( true )
+ {
+ Request request = client.newRequest( resolve( task ) )
+ .timeout( requestTimeout, TimeUnit.MILLISECONDS )
+ .method( "GET" );
+ request.headers( m -> headers.forEach( m::add ) );
+
+ if ( resume )
+ {
+ long resumeOffset = task.getResumeOffset();
+ request.headers( h ->
+ {
+ h.add( RANGE, "bytes=" + resumeOffset + '-' );
+ h.addDateField( IF_UNMODIFIED_SINCE,
+ task.getDataFile().lastModified() - MODIFICATION_THRESHOLD );
+ h.remove( HttpHeader.ACCEPT_ENCODING );
+ h.add( ACCEPT_ENCODING, "identity" );
+ } );
+ }
+
+ listener = new InputStreamResponseListener();
+ request.send( listener );
+ try
+ {
+ response = listener.get( requestTimeout, TimeUnit.MILLISECONDS );
+ }
+ catch ( ExecutionException e )
+ {
+ Throwable t = e.getCause();
+ if ( t instanceof Exception )
+ {
+ throw (Exception) t;
+ }
+ else
+ {
+ throw new RuntimeException( t );
+ }
+ }
+ if ( response.getStatus() >= MULTIPLE_CHOICES )
+ {
+ if ( resume && response.getStatus() == PRECONDITION_FAILED )
+ {
+ resume = false;
+ continue;
+ }
+ throw new JettyException( response.getStatus() );
+ }
+ break;
+ }
+
+ long offset = 0L, length = response.getHeaders().getLongField( CONTENT_LENGTH );
+ if ( resume )
+ {
+ String range = response.getHeaders().get( CONTENT_RANGE );
+ if ( range != null )
+ {
+ Matcher m = CONTENT_RANGE_PATTERN.matcher( range );
+ if ( !m.matches() )
+ {
+ throw new IOException( "Invalid Content-Range header for partial download: " + range );
+ }
+ offset = Long.parseLong( m.group( 1 ) );
+ length = Long.parseLong( m.group( 2 ) ) + 1L;
+ if ( offset < 0L || offset >= length || ( offset > 0L && offset != task.getResumeOffset() ) )
+ {
+ throw new IOException( "Invalid Content-Range header for partial download from offset "
+ + task.getResumeOffset() + ": " + range );
+ }
+ }
+ }
+
+ final boolean downloadResumed = offset > 0L;
+ final File dataFile = task.getDataFile();
+ if ( dataFile == null )
+ {
+ try ( InputStream is = listener.getInputStream() )
+ {
+ utilGet( task, is, true, length, downloadResumed );
+ }
+ }
+ else
+ {
+ try ( FileUtils.CollocatedTempFile tempFile = FileUtils.newTempFile( dataFile.toPath() ) )
+ {
+ task.setDataFile( tempFile.getPath().toFile(), downloadResumed );
+ if ( downloadResumed && Files.isRegularFile( dataFile.toPath() ) )
+ {
+ try ( InputStream inputStream = Files.newInputStream( dataFile.toPath() ) )
+ {
+ Files.copy( inputStream, tempFile.getPath(), StandardCopyOption.REPLACE_EXISTING );
+ }
+ }
+ try ( InputStream is = listener.getInputStream() )
+ {
+ utilGet( task, is, true, length, downloadResumed );
+ }
+ tempFile.move();
+ }
+ finally
+ {
+ task.setDataFile( dataFile );
+ }
+ }
+ Map<String, String> checksums = extractXChecksums( response );
+ if ( checksums != null )
+ {
+ checksums.forEach( task::setChecksum );
+ return;
+ }
+ checksums = extractNexus2Checksums( response );
+ if ( checksums != null )
+ {
+ checksums.forEach( task::setChecksum );
+ }
+ }
+
+ private static Map<String, String> extractXChecksums( Response response )
+ {
+ String value;
+ HashMap<String, String> result = new HashMap<>();
+ // Central style: x-checksum-sha1: c74edb60ca2a0b57ef88d9a7da28f591e3d4ce7b
+ value = response.getHeaders().get( "x-checksum-sha1" );
+ if ( value != null )
+ {
+ result.put( "SHA-1", value );
+ }
+ // Central style: x-checksum-md5: 9ad0d8e3482767c122e85f83567b8ce6
+ value = response.getHeaders().get( "x-checksum-md5" );
+ if ( value != null )
+ {
+ result.put( "MD5", value );
+ }
+ if ( !result.isEmpty() )
+ {
+ return result;
+ }
+ // Google style: x-goog-meta-checksum-sha1: c74edb60ca2a0b57ef88d9a7da28f591e3d4ce7b
+ value = response.getHeaders().get( "x-goog-meta-checksum-sha1" );
+ if ( value != null )
+ {
+ result.put( "SHA-1", value );
+ }
+ // Central style: x-goog-meta-checksum-sha1: 9ad0d8e3482767c122e85f83567b8ce6
+ value = response.getHeaders().get( "x-goog-meta-checksum-md5" );
+ if ( value != null )
+ {
+ result.put( "MD5", value );
+ }
+
+ return result.isEmpty() ? null : result;
+ }
+
+ private static Map<String, String> extractNexus2Checksums( Response response )
+ {
+ // Nexus-style, ETag: "{SHA1{d40d68ba1f88d8e9b0040f175a6ff41928abd5e7}}"
+ String etag = response.getHeaders().get( "ETag" );
+ if ( etag != null )
+ {
+ int start = etag.indexOf( "SHA1{" ), end = etag.indexOf( "}", start + 5 );
+ if ( start >= 0 && end > start )
+ {
+ return Collections.singletonMap( "SHA-1", etag.substring( start + 5, end ) );
+ }
+ }
+ return null;
+ }
+
+ @Override
+ protected void implPut( PutTask task )
+ throws Exception
+ {
+ Request request = client.newRequest( resolve( task ) ).method( "PUT" )
+ .timeout( requestTimeout, TimeUnit.MILLISECONDS );
+ request.headers( m -> headers.forEach( m::add ) );
+ try ( FileUtils.TempFile tempFile = FileUtils.newTempFile() )
+ {
+ utilPut( task, Files.newOutputStream( tempFile.getPath() ), true );
+ request.body( new PathRequestContent( tempFile.getPath() ) );
+
+ Response response;
+ try
+ {
+ response = request.send();
+ }
+ catch ( ExecutionException e )
+ {
+ Throwable t = e.getCause();
+ if ( t instanceof Exception )
+ {
+ throw (Exception) t;
+ }
+ else
+ {
+ throw new RuntimeException( t );
+ }
+ }
+ if ( response.getStatus() >= MULTIPLE_CHOICES )
+ {
+ throw new JettyException( response.getStatus() );
+ }
+ }
+ }
+
+ @Override
+ protected void implClose()
+ {
+ // noop
+ }
+
+ /**
+ * Visible for testing.
+ */
+ static final String JETTY_INSTANCE_KEY_PREFIX = JettyTransporterFactory.class.getName() + ".jetty.";
+
+ @SuppressWarnings( "checkstyle:methodlength" )
+ private static HttpClient getOrCreateClient( RepositorySystemSession session, RemoteRepository repository )
+ throws NoTransporterException
+ {
+
+ final String instanceKey = JETTY_INSTANCE_KEY_PREFIX + repository.getId();
+
+ try
+ {
+ return (HttpClient) session.getData().computeIfAbsent( instanceKey, () ->
+ {
+ SSLContext sslContext = null;
+ BasicAuthentication basicAuthentication = null;
+ try
+ {
+ try ( AuthenticationContext repoAuthContext = AuthenticationContext.forRepository( session,
+ repository ) )
+ {
+ if ( repoAuthContext != null )
+ {
+ sslContext = repoAuthContext.get( AuthenticationContext.SSL_CONTEXT, SSLContext.class );
+
+ String username = repoAuthContext.get( AuthenticationContext.USERNAME );
+ String password = repoAuthContext.get( AuthenticationContext.PASSWORD );
+
+ basicAuthentication =
+ new BasicAuthentication( URI.create( repository.getUrl() ),
+ Authentication.ANY_REALM, username, password );
+ }
+ }
+
+ if ( sslContext == null )
+ {
+ sslContext = SSLContext.getDefault();
+ }
+
+ int connectTimeout = ConfigUtils.getInteger( session,
+ ConfigurationProperties.DEFAULT_CONNECT_TIMEOUT,
+ ConfigurationProperties.CONNECT_TIMEOUT + "." + repository.getId(),
+ ConfigurationProperties.CONNECT_TIMEOUT );
+
+ SslContextFactory.Client sslContextFactory = new SslContextFactory.Client();
+ sslContextFactory.setSslContext( sslContext );
+
+ ClientConnector clientConnector = new ClientConnector();
+ clientConnector.setSslContextFactory( sslContextFactory );
+
+ HTTP2Client http2Client = new HTTP2Client( clientConnector );
+ ClientConnectionFactoryOverHTTP2.HTTP2 http2 =
+ new ClientConnectionFactoryOverHTTP2.HTTP2( http2Client );
+
+ HttpClientTransportDynamic transport;
+ if ( "https".equalsIgnoreCase( repository.getProtocol() ) )
+ {
+ transport = new HttpClientTransportDynamic( clientConnector,
+ http2, HttpClientConnectionFactory.HTTP11 ); // HTTPS, prefer H2
+ }
+ else
+ {
+ transport = new HttpClientTransportDynamic( clientConnector,
+ HttpClientConnectionFactory.HTTP11, http2 ); // plaintext HTTP, H2 cannot be used
+ }
+
+ HttpClient httpClient = new HttpClient( transport );
+ httpClient.setConnectTimeout( connectTimeout );
+ httpClient.setFollowRedirects( true );
+ httpClient.setMaxRedirects( 2 );
+
+ httpClient.setUserAgentField( null ); // we manage it
+
+ if ( basicAuthentication != null )
+ {
+ httpClient.getAuthenticationStore().addAuthentication( basicAuthentication );
+ }
+
+ if ( repository.getProxy() != null )
+ {
+ HttpProxy proxy =
+ new HttpProxy( repository.getProxy().getHost(), repository.getProxy().getPort() );
+
+ httpClient.getProxyConfiguration().addProxy( proxy );
+ try ( AuthenticationContext proxyAuthContext = AuthenticationContext.forProxy( session,
+ repository ) )
+ {
+ if ( proxyAuthContext != null )
+ {
+ String username = proxyAuthContext.get( AuthenticationContext.USERNAME );
+ String password = proxyAuthContext.get( AuthenticationContext.PASSWORD );
+
+ BasicAuthentication proxyAuthentication =
+ new BasicAuthentication( proxy.getURI(), Authentication.ANY_REALM,
+ username, password );
+
+ httpClient.getAuthenticationStore().addAuthentication( proxyAuthentication );
+ }
+ }
+ }
+ httpClient.start();
Review Comment:
Yes, stopping the client is missing, as noted in "Important notes" (3rd bullet). Client is created per-session, per-remote repository.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #231: [MRESOLVER-308] HTTP transport showdown.
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #231:
URL: https://github.com/apache/maven-resolver/pull/231#issuecomment-1366610210
As nobody objected, am dropping okhttp transport, so lowering this PR to addition of 2 transports (java11 and Jetty).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] kwin commented on pull request #231: [MRESOLVER-308] HTTP transport showdown.
Posted by GitBox <gi...@apache.org>.
kwin commented on PR #231:
URL: https://github.com/apache/maven-resolver/pull/231#issuecomment-1366125656
> We just need a small decent set.
Exactly, for me shipping 5 transport modules is too much. That also makes the decision for consumers much harder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MRESOLVER-308] HTTP transport showdown. [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas closed pull request #231: [MRESOLVER-308] HTTP transport showdown.
URL: https://github.com/apache/maven-resolver/pull/231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #231: [MRESOLVER-308] HTTP transport showdown.
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #231:
URL: https://github.com/apache/maven-resolver/pull/231#issuecomment-1366609532
> This should bump the version to 1.10 due to the build requirement change.
I agree, but let's make it in different change (as we have currently 2 PRs overlapping somewhat, this and onSessionClose). So let's make the 1.10.0 bump change in separate commit (and update JIRA)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] rmannibucau commented on pull request #231: [MRESOLVER-308] HTTP transport showdown.
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on PR #231:
URL: https://github.com/apache/maven-resolver/pull/231#issuecomment-1366137758
My 2cts would be that `Java 11 HttpClient` is really worth it since it will, ultimately, enable to almost drop the resolver transitive stack when we'll be java >= 11 and go reactive (not need 256 threads to download 256 deps at the same time) but for the same reason we don't care anymore of WebDAV we shouldn't care much of http client impls (all but apache one actually?) while we have one impl which works well enough - even if it requires some system properties, we have all we need to make it work - I think it is more than sufficient and will particularly avoid the "don't use in prod until you used it and saw it was working" which does motivate much to use that.
That said, fact it does not work with `mvnd` should maybe be considered as a blocker - I consider mvnd as a deliverable of maven so anything targetting mvn should also target mvnd IMHO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on pull request #231: [MRESOLVER-308] HTTP transport showdown.
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #231:
URL: https://github.com/apache/maven-resolver/pull/231#issuecomment-1364570706
> Do we really want to keep maintaining that many resolver transport modules? If there is a clear winner performance wise, why not dropping the other modules? I fail to see the advantage of providing that many options...
There can never be a clear winner since every client is different and every environment is different. We just need a small decent set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #231: [MRESOLVER-308] HTTP transport showdown.
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #231:
URL: https://github.com/apache/maven-resolver/pull/231#issuecomment-1362976250
The shared test is "lifted" from existing "native" (Apache HttpClient) tests, and it is strictly blocking, so assertions happens that body is not touched, while new clients do some things "ahead" to optimize, so still remains how to settle these (IMHO minor) differences, but to not loose any notable information. All 3 new transport UT passes when these fine grained assertions are removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #231: [MRESOLVER-308] HTTP transport showdown.
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #231:
URL: https://github.com/apache/maven-resolver/pull/231#issuecomment-1366133370
Just to clear up: the fact we have here 5 (7 to be exact) transports, that does not mean we need to deliver all these with Maven. Or in other words, transport-http, transport-file and transport-classpath was present since day 0 (of resolver existence), but _no Maven included it so far_. Maven 3.9/4.0 will be the first that will include transport-http.
There are 4 transports already (file, http, wagon, classpath), and this PR adds 3 new modules. But, the thing is, these are all for HTTP protocol (when protocol of remote repository is HTTP/HTTPS). These are the "old" ones:
* wagon
* http (aka "native")
While these are new:
* java11
* jetty
* okhttp
New ones are all HTTP/2 capable. Personally, from new ones, I'd remove okhttp (cons: pulls in kotlin runtime and is slowest H2 client). Java11 and Jetty were really close to each other.
In short: the fact a transport is present here, does not mean _we must ship it_, as the case of transport-classpath and transport-http shows (they were present since day 0 of resolver, but never shipped).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] olamy commented on a diff in pull request #231: [MRESOLVER-308] HTTP transport showdown.
Posted by GitBox <gi...@apache.org>.
olamy commented on code in PR #231:
URL: https://github.com/apache/maven-resolver/pull/231#discussion_r1056884304
##########
maven-resolver-transport-jetty/src/main/java/org/eclipse/aether/transport/jetty/JettyTransporter.java:
##########
@@ -0,0 +1,539 @@
+package org.eclipse.aether.transport.jetty;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.net.ssl.SSLContext;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.URI;
+import java.net.URISyntaxException;
+import java.nio.file.Files;
+import java.nio.file.StandardCopyOption;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.TimeUnit;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import org.eclipse.aether.ConfigurationProperties;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.repository.AuthenticationContext;
+import org.eclipse.aether.repository.RemoteRepository;
+import org.eclipse.aether.spi.connector.transport.AbstractTransporter;
+import org.eclipse.aether.spi.connector.transport.GetTask;
+import org.eclipse.aether.spi.connector.transport.PeekTask;
+import org.eclipse.aether.spi.connector.transport.PutTask;
+import org.eclipse.aether.spi.connector.transport.TransportTask;
+import org.eclipse.aether.transfer.NoTransporterException;
+import org.eclipse.aether.util.ConfigUtils;
+import org.eclipse.aether.util.FileUtils;
+import org.eclipse.jetty.client.HttpClient;
+import org.eclipse.jetty.client.HttpProxy;
+import org.eclipse.jetty.client.api.Authentication;
+import org.eclipse.jetty.client.api.Request;
+import org.eclipse.jetty.client.api.Response;
+import org.eclipse.jetty.client.dynamic.HttpClientTransportDynamic;
+import org.eclipse.jetty.client.http.HttpClientConnectionFactory;
+import org.eclipse.jetty.client.util.BasicAuthentication;
+import org.eclipse.jetty.client.util.InputStreamResponseListener;
+import org.eclipse.jetty.client.util.PathRequestContent;
+import org.eclipse.jetty.http.HttpHeader;
+import org.eclipse.jetty.http2.client.HTTP2Client;
+import org.eclipse.jetty.http2.client.http.ClientConnectionFactoryOverHTTP2;
+import org.eclipse.jetty.io.ClientConnector;
+import org.eclipse.jetty.util.ssl.SslContextFactory;
+
+/**
+ * A transporter for HTTP/HTTPS.
+ */
+final class JettyTransporter
+ extends AbstractTransporter
+{
+ private static final int MULTIPLE_CHOICES = 300;
+
+ private static final int NOT_FOUND = 404;
+
+ private static final int PRECONDITION_FAILED = 412;
+
+ private static final long MODIFICATION_THRESHOLD = 60L * 1000L;
+
+ private static final String ACCEPT_ENCODING = "Accept-Encoding";
+
+ private static final String CONTENT_LENGTH = "Content-Length";
+
+ private static final String CONTENT_RANGE = "Content-Range";
+
+ private static final String IF_UNMODIFIED_SINCE = "If-Unmodified-Since";
+
+ private static final String RANGE = "Range";
+
+ private static final String USER_AGENT = "User-Agent";
+
+ private static final Pattern CONTENT_RANGE_PATTERN =
+ Pattern.compile( "\\s*bytes\\s+([0-9]+)\\s*-\\s*([0-9]+)\\s*/.*" );
+
+ private final URI baseUri;
+
+ private final HttpClient client;
+
+ private final int requestTimeout;
+
+ private final Map<String, String> headers;
+
+ JettyTransporter( RepositorySystemSession session, RemoteRepository repository ) throws NoTransporterException
+ {
+ try
+ {
+ URI uri = new URI( repository.getUrl() ).parseServerAuthority();
+ if ( uri.isOpaque() )
+ {
+ throw new URISyntaxException( repository.getUrl(), "URL must not be opaque" );
+ }
+ if ( uri.getRawFragment() != null || uri.getRawQuery() != null )
+ {
+ throw new URISyntaxException( repository.getUrl(), "URL must not have fragment or query" );
+ }
+ String path = uri.getPath();
+ if ( path == null )
+ {
+ path = "/";
+ }
+ if ( !path.startsWith( "/" ) )
+ {
+ path = "/" + path;
+ }
+ if ( !path.endsWith( "/" ) )
+ {
+ path = path + "/";
+ }
+ this.baseUri = URI.create( uri.getScheme() + "://" + uri.getRawAuthority() + path );
+ }
+ catch ( URISyntaxException e )
+ {
+ throw new NoTransporterException( repository, e.getMessage(), e );
+ }
+
+ HashMap<String, String> headers = new HashMap<>();
+ String userAgent = ConfigUtils.getString( session,
+ ConfigurationProperties.DEFAULT_USER_AGENT,
+ ConfigurationProperties.USER_AGENT );
+ if ( userAgent != null )
+ {
+ headers.put( USER_AGENT, userAgent );
+ }
+ @SuppressWarnings( "unchecked" )
+ Map<Object, Object> configuredHeaders =
+ (Map<Object, Object>) ConfigUtils.getMap( session, Collections.emptyMap(),
+ ConfigurationProperties.HTTP_HEADERS + "." + repository.getId(),
+ ConfigurationProperties.HTTP_HEADERS );
+ if ( configuredHeaders != null )
+ {
+ configuredHeaders.forEach(
+ ( k, v ) -> headers.put( String.valueOf( k ), v != null ? String.valueOf( v ) : null ) );
+ }
+
+ this.headers = headers;
+
+ this.requestTimeout = ConfigUtils.getInteger( session,
+ ConfigurationProperties.DEFAULT_REQUEST_TIMEOUT,
+ ConfigurationProperties.REQUEST_TIMEOUT + "." + repository.getId(),
+ ConfigurationProperties.REQUEST_TIMEOUT );
+
+ this.client = getOrCreateClient( session, repository );
+ }
+
+ private URI resolve( TransportTask task )
+ {
+ return baseUri.resolve( task.getLocation() );
+ }
+
+ @Override
+ public int classify( Throwable error )
+ {
+ if ( error instanceof JettyException
+ && ( (JettyException) error ).getStatusCode() == NOT_FOUND )
+ {
+ return ERROR_NOT_FOUND;
+ }
+ return ERROR_OTHER;
+ }
+
+ @Override
+ protected void implPeek( PeekTask task )
+ throws Exception
+ {
+ Request request = client.newRequest( resolve( task ) )
+ .timeout( requestTimeout, TimeUnit.MILLISECONDS )
+ .method( "HEAD" );
+ request.headers( m -> headers.forEach( m::add ) );
+ Response response = request.send();
+ if ( response.getStatus() >= MULTIPLE_CHOICES )
+ {
+ throw new JettyException( response.getStatus() );
+ }
+ }
+
+ @Override
+ protected void implGet( GetTask task )
+ throws Exception
+ {
+ boolean resume = task.getResumeOffset() > 0L && task.getDataFile() != null;
+ Response response;
+ InputStreamResponseListener listener;
+
+ while ( true )
+ {
+ Request request = client.newRequest( resolve( task ) )
+ .timeout( requestTimeout, TimeUnit.MILLISECONDS )
+ .method( "GET" );
+ request.headers( m -> headers.forEach( m::add ) );
+
+ if ( resume )
+ {
+ long resumeOffset = task.getResumeOffset();
+ request.headers( h ->
+ {
+ h.add( RANGE, "bytes=" + resumeOffset + '-' );
+ h.addDateField( IF_UNMODIFIED_SINCE,
+ task.getDataFile().lastModified() - MODIFICATION_THRESHOLD );
+ h.remove( HttpHeader.ACCEPT_ENCODING );
+ h.add( ACCEPT_ENCODING, "identity" );
+ } );
+ }
+
+ listener = new InputStreamResponseListener();
+ request.send( listener );
+ try
+ {
+ response = listener.get( requestTimeout, TimeUnit.MILLISECONDS );
+ }
+ catch ( ExecutionException e )
+ {
+ Throwable t = e.getCause();
+ if ( t instanceof Exception )
+ {
+ throw (Exception) t;
+ }
+ else
+ {
+ throw new RuntimeException( t );
+ }
+ }
+ if ( response.getStatus() >= MULTIPLE_CHOICES )
+ {
+ if ( resume && response.getStatus() == PRECONDITION_FAILED )
+ {
+ resume = false;
+ continue;
+ }
+ throw new JettyException( response.getStatus() );
+ }
+ break;
+ }
+
+ long offset = 0L, length = response.getHeaders().getLongField( CONTENT_LENGTH );
+ if ( resume )
+ {
+ String range = response.getHeaders().get( CONTENT_RANGE );
+ if ( range != null )
+ {
+ Matcher m = CONTENT_RANGE_PATTERN.matcher( range );
+ if ( !m.matches() )
+ {
+ throw new IOException( "Invalid Content-Range header for partial download: " + range );
+ }
+ offset = Long.parseLong( m.group( 1 ) );
+ length = Long.parseLong( m.group( 2 ) ) + 1L;
+ if ( offset < 0L || offset >= length || ( offset > 0L && offset != task.getResumeOffset() ) )
+ {
+ throw new IOException( "Invalid Content-Range header for partial download from offset "
+ + task.getResumeOffset() + ": " + range );
+ }
+ }
+ }
+
+ final boolean downloadResumed = offset > 0L;
+ final File dataFile = task.getDataFile();
+ if ( dataFile == null )
+ {
+ try ( InputStream is = listener.getInputStream() )
+ {
+ utilGet( task, is, true, length, downloadResumed );
+ }
+ }
+ else
+ {
+ try ( FileUtils.CollocatedTempFile tempFile = FileUtils.newTempFile( dataFile.toPath() ) )
+ {
+ task.setDataFile( tempFile.getPath().toFile(), downloadResumed );
+ if ( downloadResumed && Files.isRegularFile( dataFile.toPath() ) )
+ {
+ try ( InputStream inputStream = Files.newInputStream( dataFile.toPath() ) )
+ {
+ Files.copy( inputStream, tempFile.getPath(), StandardCopyOption.REPLACE_EXISTING );
+ }
+ }
+ try ( InputStream is = listener.getInputStream() )
+ {
+ utilGet( task, is, true, length, downloadResumed );
+ }
+ tempFile.move();
+ }
+ finally
+ {
+ task.setDataFile( dataFile );
+ }
+ }
+ Map<String, String> checksums = extractXChecksums( response );
+ if ( checksums != null )
+ {
+ checksums.forEach( task::setChecksum );
+ return;
+ }
+ checksums = extractNexus2Checksums( response );
+ if ( checksums != null )
+ {
+ checksums.forEach( task::setChecksum );
+ }
+ }
+
+ private static Map<String, String> extractXChecksums( Response response )
+ {
+ String value;
+ HashMap<String, String> result = new HashMap<>();
+ // Central style: x-checksum-sha1: c74edb60ca2a0b57ef88d9a7da28f591e3d4ce7b
+ value = response.getHeaders().get( "x-checksum-sha1" );
+ if ( value != null )
+ {
+ result.put( "SHA-1", value );
+ }
+ // Central style: x-checksum-md5: 9ad0d8e3482767c122e85f83567b8ce6
+ value = response.getHeaders().get( "x-checksum-md5" );
+ if ( value != null )
+ {
+ result.put( "MD5", value );
+ }
+ if ( !result.isEmpty() )
+ {
+ return result;
+ }
+ // Google style: x-goog-meta-checksum-sha1: c74edb60ca2a0b57ef88d9a7da28f591e3d4ce7b
+ value = response.getHeaders().get( "x-goog-meta-checksum-sha1" );
+ if ( value != null )
+ {
+ result.put( "SHA-1", value );
+ }
+ // Central style: x-goog-meta-checksum-sha1: 9ad0d8e3482767c122e85f83567b8ce6
+ value = response.getHeaders().get( "x-goog-meta-checksum-md5" );
+ if ( value != null )
+ {
+ result.put( "MD5", value );
+ }
+
+ return result.isEmpty() ? null : result;
+ }
+
+ private static Map<String, String> extractNexus2Checksums( Response response )
+ {
+ // Nexus-style, ETag: "{SHA1{d40d68ba1f88d8e9b0040f175a6ff41928abd5e7}}"
+ String etag = response.getHeaders().get( "ETag" );
+ if ( etag != null )
+ {
+ int start = etag.indexOf( "SHA1{" ), end = etag.indexOf( "}", start + 5 );
+ if ( start >= 0 && end > start )
+ {
+ return Collections.singletonMap( "SHA-1", etag.substring( start + 5, end ) );
+ }
+ }
+ return null;
+ }
+
+ @Override
+ protected void implPut( PutTask task )
+ throws Exception
+ {
+ Request request = client.newRequest( resolve( task ) ).method( "PUT" )
+ .timeout( requestTimeout, TimeUnit.MILLISECONDS );
+ request.headers( m -> headers.forEach( m::add ) );
+ try ( FileUtils.TempFile tempFile = FileUtils.newTempFile() )
+ {
+ utilPut( task, Files.newOutputStream( tempFile.getPath() ), true );
+ request.body( new PathRequestContent( tempFile.getPath() ) );
+
+ Response response;
+ try
+ {
+ response = request.send();
+ }
+ catch ( ExecutionException e )
+ {
+ Throwable t = e.getCause();
+ if ( t instanceof Exception )
+ {
+ throw (Exception) t;
+ }
+ else
+ {
+ throw new RuntimeException( t );
+ }
+ }
+ if ( response.getStatus() >= MULTIPLE_CHOICES )
+ {
+ throw new JettyException( response.getStatus() );
+ }
+ }
+ }
+
+ @Override
+ protected void implClose()
+ {
+ // noop
+ }
+
+ /**
+ * Visible for testing.
+ */
+ static final String JETTY_INSTANCE_KEY_PREFIX = JettyTransporterFactory.class.getName() + ".jetty.";
+
+ @SuppressWarnings( "checkstyle:methodlength" )
+ private static HttpClient getOrCreateClient( RepositorySystemSession session, RemoteRepository repository )
+ throws NoTransporterException
+ {
+
+ final String instanceKey = JETTY_INSTANCE_KEY_PREFIX + repository.getId();
+
+ try
+ {
+ return (HttpClient) session.getData().computeIfAbsent( instanceKey, () ->
+ {
+ SSLContext sslContext = null;
+ BasicAuthentication basicAuthentication = null;
+ try
+ {
+ try ( AuthenticationContext repoAuthContext = AuthenticationContext.forRepository( session,
+ repository ) )
+ {
+ if ( repoAuthContext != null )
+ {
+ sslContext = repoAuthContext.get( AuthenticationContext.SSL_CONTEXT, SSLContext.class );
+
+ String username = repoAuthContext.get( AuthenticationContext.USERNAME );
+ String password = repoAuthContext.get( AuthenticationContext.PASSWORD );
+
+ basicAuthentication =
+ new BasicAuthentication( URI.create( repository.getUrl() ),
+ Authentication.ANY_REALM, username, password );
+ }
+ }
+
+ if ( sslContext == null )
+ {
+ sslContext = SSLContext.getDefault();
+ }
+
+ int connectTimeout = ConfigUtils.getInteger( session,
+ ConfigurationProperties.DEFAULT_CONNECT_TIMEOUT,
+ ConfigurationProperties.CONNECT_TIMEOUT + "." + repository.getId(),
+ ConfigurationProperties.CONNECT_TIMEOUT );
+
+ SslContextFactory.Client sslContextFactory = new SslContextFactory.Client();
+ sslContextFactory.setSslContext( sslContext );
+
+ ClientConnector clientConnector = new ClientConnector();
+ clientConnector.setSslContextFactory( sslContextFactory );
+
+ HTTP2Client http2Client = new HTTP2Client( clientConnector );
+ ClientConnectionFactoryOverHTTP2.HTTP2 http2 =
+ new ClientConnectionFactoryOverHTTP2.HTTP2( http2Client );
+
+ HttpClientTransportDynamic transport;
+ if ( "https".equalsIgnoreCase( repository.getProtocol() ) )
+ {
+ transport = new HttpClientTransportDynamic( clientConnector,
+ http2, HttpClientConnectionFactory.HTTP11 ); // HTTPS, prefer H2
+ }
+ else
+ {
+ transport = new HttpClientTransportDynamic( clientConnector,
+ HttpClientConnectionFactory.HTTP11, http2 ); // plaintext HTTP, H2 cannot be used
+ }
+
+ HttpClient httpClient = new HttpClient( transport );
+ httpClient.setConnectTimeout( connectTimeout );
+ httpClient.setFollowRedirects( true );
+ httpClient.setMaxRedirects( 2 );
+
+ httpClient.setUserAgentField( null ); // we manage it
+
+ if ( basicAuthentication != null )
+ {
+ httpClient.getAuthenticationStore().addAuthentication( basicAuthentication );
+ }
+
+ if ( repository.getProxy() != null )
+ {
+ HttpProxy proxy =
+ new HttpProxy( repository.getProxy().getHost(), repository.getProxy().getPort() );
+
+ httpClient.getProxyConfiguration().addProxy( proxy );
+ try ( AuthenticationContext proxyAuthContext = AuthenticationContext.forProxy( session,
+ repository ) )
+ {
+ if ( proxyAuthContext != null )
+ {
+ String username = proxyAuthContext.get( AuthenticationContext.USERNAME );
+ String password = proxyAuthContext.get( AuthenticationContext.PASSWORD );
+
+ BasicAuthentication proxyAuthentication =
+ new BasicAuthentication( proxy.getURI(), Authentication.ANY_REALM,
+ username, password );
+
+ httpClient.getAuthenticationStore().addAuthentication( proxyAuthentication );
+ }
+ }
+ }
+ httpClient.start();
Review Comment:
is there any call to `stop()` to cleanup?
Shouldn't be a problem for `mvn` as jvm is stopped but for `mvnd`?
But my understanding of the code there is only one per repo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MRESOLVER-308] HTTP transport showdown. [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #231:
URL: https://github.com/apache/maven-resolver/pull/231#issuecomment-1849874520
We are past this, so no reason to keep it anymore, closing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] kwin commented on pull request #231: [MRESOLVER-308] HTTP transport showdown.
Posted by GitBox <gi...@apache.org>.
kwin commented on PR #231:
URL: https://github.com/apache/maven-resolver/pull/231#issuecomment-1366135447
Whether we ship with Maven or not is completely orthogonal to me. If they are part of resolver releases we should make sure they work properly and I don't see the capacity to maintain that many modules (nor the need TBH)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #231: [MRESOLVER-308] HTTP transport showdown.
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #231:
URL: https://github.com/apache/maven-resolver/pull/231#issuecomment-1366150231
It does not work _currently_, but https://github.com/apache/maven-resolver/pull/232 is here to solve that bit as well (naturally, once that is merged, this PR will need changes: to hook into those). also see https://github.com/apache/maven/pull/941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MRESOLVER-308] HTTP transport showdown. [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #231:
URL: https://github.com/apache/maven-resolver/pull/231#issuecomment-1802485551
Removed this PR from 2.0.0 milestone, but am keeping it, as while main code is already on master, there may be some test related bits we will need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org