You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by "Tilman Hausherr (Jira)" <ji...@apache.org> on 2021/03/09 07:01:00 UTC

[jira] [Comment Edited] (PDFBOX-5124) Improperly declared OS2WindowsMetricsTable version (v0 table declard as v3) in embedded font stops parsing with EOFException

    [ https://issues.apache.org/jira/browse/PDFBOX-5124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17297866#comment-17297866 ] 

Tilman Hausherr edited comment on PDFBOX-5124 at 3/9/21, 7:00 AM:
------------------------------------------------------------------

I did a quick test with this change (the real change will do proper logging and use EOF)
{code}
        if (version >= 0)
        {
            try
            {
                codePageRange1 = data.readUnsignedInt();
                codePageRange2 = data.readUnsignedInt();
            }
            catch (IOException ex)
            {
                version = 1;
                ex.printStackTrace();
                return;
            }
        }
{code}
Text extraction has no differences, rendering has a slight glyph difference. Were you expecting more than this?


was (Author: tilman):
I did a quick test with this change (the real change will do proper logging and use EOF)
{code}
        if (version >= 1)
        {
            try
            {
                codePageRange1 = data.readUnsignedInt();
                codePageRange2 = data.readUnsignedInt();
            }
            catch (IOException ex)
            {
                version = 1;
                ex.printStackTrace();
                return;
            }
        }
{code}
Text extraction has no differences, rendering has a slight glyph difference. Were you expecting more than this?

> Improperly declared OS2WindowsMetricsTable version (v0 table declard as v3) in embedded font stops parsing with EOFException
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: PDFBOX-5124
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-5124
>             Project: PDFBox
>          Issue Type: Bug
>          Components: FontBox
>    Affects Versions: 2.0.22
>            Reporter: Gábor Stefanik
>            Priority: Major
>         Attachments: PDFBOX-5124-new.txt, PDFBOX-5124-old.txt, PDFBOX-5124.pdf-1-new.png, PDFBOX-5124.pdf-1-old.png, SZAMLA-20190417-20190012706-ININET-BroadBitHungary-11646-HUF.pdf
>
>
> The attached document contains an incorrectly versioned OS2WindowsMetricsTable. It's a version 0 table, but claims to be version 3. Due to this, when we try to parse the new fields introduced in newer versions, we hit an EOFException.
> Since this issue does occur in the wild, PDFBox should tolerate it, e.g. by catching the EOFException and resetting the "version" variable to the highest version that doesn't have the missing fields. (Note that the version constants PDFBox checks against are wrong, but that's PDFBOX-5123.)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org