You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/19 09:46:07 UTC

[GitHub] [flink] zentol opened a new pull request #11132: [FLINK-16164][build] Disable maven-site-plugin

zentol opened a new pull request #11132: [FLINK-16164][build] Disable maven-site-plugin
URL: https://github.com/apache/flink/pull/11132
 
 
   The maven-site-plugin can be used to generate a site for the project, like the sites used by various maven modules.
   We inherit an execution for this plugin, but don't actually use it.
   
   This PR disables the execution to remove some noise from the build.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11132: [FLINK-16164][build] Disable maven-site-plugin

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11132: [FLINK-16164][build] Disable maven-site-plugin
URL: https://github.com/apache/flink/pull/11132#issuecomment-588143489
 
 
   <!--
   Meta data
   Hash:0e171258e4aa6e35dd4d685fff401ce49c829094 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:0e171258e4aa6e35dd4d685fff401ce49c829094
   -->
   ## CI report:
   
   * 0e171258e4aa6e35dd4d685fff401ce49c829094 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11132: [FLINK-16164][build] Disable maven-site-plugin

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11132: [FLINK-16164][build] Disable maven-site-plugin
URL: https://github.com/apache/flink/pull/11132#issuecomment-588143489
 
 
   <!--
   Meta data
   Hash:0e171258e4aa6e35dd4d685fff401ce49c829094 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5305 TriggerType:PUSH TriggerID:0e171258e4aa6e35dd4d685fff401ce49c829094
   Hash:0e171258e4aa6e35dd4d685fff401ce49c829094 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149602147 TriggerType:PUSH TriggerID:0e171258e4aa6e35dd4d685fff401ce49c829094
   -->
   ## CI report:
   
   * 0e171258e4aa6e35dd4d685fff401ce49c829094 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149602147) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5305) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11132: [FLINK-16164][build] Disable maven-site-plugin

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11132: [FLINK-16164][build] Disable maven-site-plugin
URL: https://github.com/apache/flink/pull/11132#issuecomment-588130350
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 0e171258e4aa6e35dd4d685fff401ce49c829094 (Wed Feb 19 09:49:55 UTC 2020)
   
   **Warnings:**
    * **1 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] tillrohrmann commented on a change in pull request #11132: [FLINK-16164][build] Disable maven-site-plugin

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11132: [FLINK-16164][build] Disable maven-site-plugin
URL: https://github.com/apache/flink/pull/11132#discussion_r381381416
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -1699,6 +1699,18 @@ under the License.
 					</configuration>
 				</plugin>
 
+				<plugin>
+					<!-- Imherited from Apache parent, but not actually used. Disable to reduce noise. -->
 
 Review comment:
   ```suggestion
   					<!-- Inherited from Apache parent, but not actually used. Disable to reduce noise. -->
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11132: [FLINK-16164][build] Disable maven-site-plugin

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11132: [FLINK-16164][build] Disable maven-site-plugin
URL: https://github.com/apache/flink/pull/11132#issuecomment-588143489
 
 
   <!--
   Meta data
   Hash:0e171258e4aa6e35dd4d685fff401ce49c829094 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5305 TriggerType:PUSH TriggerID:0e171258e4aa6e35dd4d685fff401ce49c829094
   Hash:0e171258e4aa6e35dd4d685fff401ce49c829094 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149602147 TriggerType:PUSH TriggerID:0e171258e4aa6e35dd4d685fff401ce49c829094
   -->
   ## CI report:
   
   * 0e171258e4aa6e35dd4d685fff401ce49c829094 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149602147) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5305) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol merged pull request #11132: [FLINK-16164][build] Disable maven-site-plugin

Posted by GitBox <gi...@apache.org>.
zentol merged pull request #11132: [FLINK-16164][build] Disable maven-site-plugin
URL: https://github.com/apache/flink/pull/11132
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services