You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oodt.apache.org by "Brian Foster (JIRA)" <ji...@apache.org> on 2010/12/02 20:34:10 UTC
[jira] Created: (OODT-66) Allow Filemgr XML-RPC connection retries
and retry interval to be configurable
Allow Filemgr XML-RPC connection retries and retry interval to be configurable
------------------------------------------------------------------------------
Key: OODT-66
URL: https://issues.apache.org/jira/browse/OODT-66
Project: OODT
Issue Type: Improvement
Components: file manager
Affects Versions: 0.1-incubating
Environment: none
Reporter: Brian Foster
Assignee: Brian Foster
Priority: Minor
Fix For: 0.2
- XML-RPC's default retry, when server connection is denied because of server overload, is that the client will retry 3 times with 0 time interval between each retry . . . this should be configurable
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OODT-66) Allow Filemgr XML-RPC connection
retries and retry interval to be configurable
Posted by "Chris A. Mattmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12967280#action_12967280 ]
Chris A. Mattmann commented on OODT-66:
---------------------------------------
+1, looks good to commit! Thanks dude!
> Allow Filemgr XML-RPC connection retries and retry interval to be configurable
> ------------------------------------------------------------------------------
>
> Key: OODT-66
> URL: https://issues.apache.org/jira/browse/OODT-66
> Project: OODT
> Issue Type: Improvement
> Components: file manager
> Affects Versions: 0.1-incubating
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.2
>
> Attachments: FileManagerRetry.2010-12-02.patch.txt, FileManagerRetry.2010-12-06.patch.txt
>
>
> - XML-RPC's default retry, when server connection is denied because of server overload, is that the client will retry 3 times with 0 time interval between each retry . . . this should be configurable
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OODT-66) Allow Filemgr XML-RPC connection retries
and retry interval to be configurable
Posted by "Brian Foster (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Foster updated OODT-66:
-----------------------------
Attachment: FileManagerRetry.2010-12-02.patch.txt
- attached proposed patch
> Allow Filemgr XML-RPC connection retries and retry interval to be configurable
> ------------------------------------------------------------------------------
>
> Key: OODT-66
> URL: https://issues.apache.org/jira/browse/OODT-66
> Project: OODT
> Issue Type: Improvement
> Components: file manager
> Affects Versions: 0.1-incubating
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.2
>
> Attachments: FileManagerRetry.2010-12-02.patch.txt
>
>
> - XML-RPC's default retry, when server connection is denied because of server overload, is that the client will retry 3 times with 0 time interval between each retry . . . this should be configurable
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OODT-66) Allow Filemgr XML-RPC connection
retries and retry interval to be configurable
Posted by "Brian Foster (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12967256#action_12967256 ]
Brian Foster commented on OODT-66:
----------------------------------
- if i changed the indenting for this file, more changes than just the patch will go in
- it appears most of the file uses 4 space indent, but some of the file uses only 2 (i.e. the refreshConfigAndPolicy method)
. . . . since most of the file is 4 spaced indented, i will not change the formatting for the rest of the file and just add my patch with 4 space indenting . . . sound cool?
> Allow Filemgr XML-RPC connection retries and retry interval to be configurable
> ------------------------------------------------------------------------------
>
> Key: OODT-66
> URL: https://issues.apache.org/jira/browse/OODT-66
> Project: OODT
> Issue Type: Improvement
> Components: file manager
> Affects Versions: 0.1-incubating
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.2
>
> Attachments: FileManagerRetry.2010-12-02.patch.txt
>
>
> - XML-RPC's default retry, when server connection is denied because of server overload, is that the client will retry 3 times with 0 time interval between each retry . . . this should be configurable
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OODT-66) Allow Filemgr XML-RPC connection retries
and retry interval to be configurable
Posted by "Brian Foster (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Foster updated OODT-66:
-----------------------------
Attachment: FileManagerRetry.2010-12-06.patch.txt
- reattached patch . . . per comment above
> Allow Filemgr XML-RPC connection retries and retry interval to be configurable
> ------------------------------------------------------------------------------
>
> Key: OODT-66
> URL: https://issues.apache.org/jira/browse/OODT-66
> Project: OODT
> Issue Type: Improvement
> Components: file manager
> Affects Versions: 0.1-incubating
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.2
>
> Attachments: FileManagerRetry.2010-12-02.patch.txt, FileManagerRetry.2010-12-06.patch.txt
>
>
> - XML-RPC's default retry, when server connection is denied because of server overload, is that the client will retry 3 times with 0 time interval between each retry . . . this should be configurable
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (OODT-66) Allow Filemgr XML-RPC connection retries
and retry interval to be configurable
Posted by "Brian Foster (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Foster resolved OODT-66.
------------------------------
Resolution: Fixed
fixed in r1042744
> Allow Filemgr XML-RPC connection retries and retry interval to be configurable
> ------------------------------------------------------------------------------
>
> Key: OODT-66
> URL: https://issues.apache.org/jira/browse/OODT-66
> Project: OODT
> Issue Type: Improvement
> Components: file manager
> Affects Versions: 0.1-incubating
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.2
>
> Attachments: FileManagerRetry.2010-12-02.patch.txt, FileManagerRetry.2010-12-06.patch.txt
>
>
> - XML-RPC's default retry, when server connection is denied because of server overload, is that the client will retry 3 times with 0 time interval between each retry . . . this should be configurable
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OODT-66) Allow Filemgr XML-RPC connection retries
and retry interval to be configurable
Posted by "Brian Foster (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Foster updated OODT-66:
-----------------------------
Attachment: (was: FileManagerRetry.2010-12-06.patch.txt)
> Allow Filemgr XML-RPC connection retries and retry interval to be configurable
> ------------------------------------------------------------------------------
>
> Key: OODT-66
> URL: https://issues.apache.org/jira/browse/OODT-66
> Project: OODT
> Issue Type: Improvement
> Components: file manager
> Affects Versions: 0.1-incubating
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.2
>
> Attachments: FileManagerRetry.2010-12-02.patch.txt
>
>
> - XML-RPC's default retry, when server connection is denied because of server overload, is that the client will retry 3 times with 0 time interval between each retry . . . this should be configurable
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OODT-66) Allow Filemgr XML-RPC connection
retries and retry interval to be configurable
Posted by "Chris A. Mattmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12967263#action_12967263 ]
Chris A. Mattmann commented on OODT-66:
---------------------------------------
Hey Brian,
patch looks good on formatting, but you missed the parts about updating filemgr.properties in the src/main/resources directory and adding the entry to CHANGES.txt? Can you add those?
Cheers,
Chris
> Allow Filemgr XML-RPC connection retries and retry interval to be configurable
> ------------------------------------------------------------------------------
>
> Key: OODT-66
> URL: https://issues.apache.org/jira/browse/OODT-66
> Project: OODT
> Issue Type: Improvement
> Components: file manager
> Affects Versions: 0.1-incubating
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.2
>
> Attachments: FileManagerRetry.2010-12-02.patch.txt, FileManagerRetry.2010-12-06.patch.txt
>
>
> - XML-RPC's default retry, when server connection is denied because of server overload, is that the client will retry 3 times with 0 time interval between each retry . . . this should be configurable
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OODT-66) Allow Filemgr XML-RPC connection retries
and retry interval to be configurable
Posted by "Brian Foster (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Foster updated OODT-66:
-----------------------------
Attachment: FileManagerRetry.2010-12-06.patch.txt
- reattached with filemgr.properties change included
> Allow Filemgr XML-RPC connection retries and retry interval to be configurable
> ------------------------------------------------------------------------------
>
> Key: OODT-66
> URL: https://issues.apache.org/jira/browse/OODT-66
> Project: OODT
> Issue Type: Improvement
> Components: file manager
> Affects Versions: 0.1-incubating
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.2
>
> Attachments: FileManagerRetry.2010-12-02.patch.txt, FileManagerRetry.2010-12-06.patch.txt
>
>
> - XML-RPC's default retry, when server connection is denied because of server overload, is that the client will retry 3 times with 0 time interval between each retry . . . this should be configurable
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OODT-66) Allow Filemgr XML-RPC connection
retries and retry interval to be configurable
Posted by "Chris A. Mattmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966332#action_12966332 ]
Chris A. Mattmann commented on OODT-66:
---------------------------------------
Hey Brian, your patch looks great! One comment though: the spacing. Is it at 4 spaces or a tab? Can we cut it down to 2 spaces for the indenting? We should probably come up with a real policy on this but haven't yet I know. It just looks odd since it looks like the rest of the code is 2 spaced.
+1 for the overall patch though (if you get a chance please update the spacing). Thanks!
> Allow Filemgr XML-RPC connection retries and retry interval to be configurable
> ------------------------------------------------------------------------------
>
> Key: OODT-66
> URL: https://issues.apache.org/jira/browse/OODT-66
> Project: OODT
> Issue Type: Improvement
> Components: file manager
> Affects Versions: 0.1-incubating
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.2
>
> Attachments: FileManagerRetry.2010-12-02.patch.txt
>
>
> - XML-RPC's default retry, when server connection is denied because of server overload, is that the client will retry 3 times with 0 time interval between each retry . . . this should be configurable
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OODT-66) Allow Filemgr XML-RPC connection
retries and retry interval to be configurable
Posted by "Brian Foster (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12967266#action_12967266 ]
Brian Foster commented on OODT-66:
----------------------------------
- i will updated CHANGES.txt in the commit . . . the mvn eclipse:eclipse plugin only works at project level, so i don't have the CHANGES.txt open in eclipse when using Team->Create Patch...
> Allow Filemgr XML-RPC connection retries and retry interval to be configurable
> ------------------------------------------------------------------------------
>
> Key: OODT-66
> URL: https://issues.apache.org/jira/browse/OODT-66
> Project: OODT
> Issue Type: Improvement
> Components: file manager
> Affects Versions: 0.1-incubating
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.2
>
> Attachments: FileManagerRetry.2010-12-02.patch.txt, FileManagerRetry.2010-12-06.patch.txt
>
>
> - XML-RPC's default retry, when server connection is denied because of server overload, is that the client will retry 3 times with 0 time interval between each retry . . . this should be configurable
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OODT-66) Allow Filemgr XML-RPC connection
retries and retry interval to be configurable
Posted by "Chris A. Mattmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966397#action_12966397 ]
Chris A. Mattmann commented on OODT-66:
---------------------------------------
Hi Brian: 2 other things real quick:
1. can you update filemgr.properties in the src/main/resources/ directory and add the new property as an example (with # prefixed documentation saying what it does and with default values)
2. can you make sure to update CHANGES.txt too?
Thanks bud!
> Allow Filemgr XML-RPC connection retries and retry interval to be configurable
> ------------------------------------------------------------------------------
>
> Key: OODT-66
> URL: https://issues.apache.org/jira/browse/OODT-66
> Project: OODT
> Issue Type: Improvement
> Components: file manager
> Affects Versions: 0.1-incubating
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.2
>
> Attachments: FileManagerRetry.2010-12-02.patch.txt
>
>
> - XML-RPC's default retry, when server connection is denied because of server overload, is that the client will retry 3 times with 0 time interval between each retry . . . this should be configurable
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.