You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jimmy Xiang (JIRA)" <ji...@apache.org> on 2012/05/07 22:14:49 UTC
[jira] [Created] (HBASE-5952) Sync hardcoded default flush size and
max file size with hbase-default.xml
Jimmy Xiang created HBASE-5952:
----------------------------------
Summary: Sync hardcoded default flush size and max file size with hbase-default.xml
Key: HBASE-5952
URL: https://issues.apache.org/jira/browse/HBASE-5952
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.2
Reporter: Jimmy Xiang
Assignee: Jimmy Xiang
Priority: Minor
Fix For: 0.92.2
Since the hardcoded default flush size is 64MB, but the default in hbase-default.xml is 128MB, if the client does set it to 64MB,
the actual flush size will be 128MB instead, due to the way HRegion get the flush size. We can change how HRegion get the flush size,
but it is clean and simple to sync up the defaults.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5952) Sync hardcoded default flush size
and max file size with hbase-default.xml
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269995#comment-13269995 ]
Zhihong Yu commented on HBASE-5952:
-----------------------------------
Patch makes sense.
There was a conflict in HTableDescriptor.java:
{code}
***************
*** 164,170 ****
* Constant that denotes the maximum default size of the memstore after which
* the contents are flushed to the store files
*/
- public static final long DEFAULT_MEMSTORE_FLUSH_SIZE = 1024*1024*64L;
private volatile Boolean meta = null;
private volatile Boolean root = null;
--- 164,170 ----
* Constant that denotes the maximum default size of the memstore after which
* the contents are flushed to the store files
*/
+ public static final long DEFAULT_MEMSTORE_FLUSH_SIZE = 1024*1024*128L;
private volatile Boolean meta = null;
private volatile Boolean root = null;
{code}
> Sync hardcoded default flush size and max file size with hbase-default.xml
> --------------------------------------------------------------------------
>
> Key: HBASE-5952
> URL: https://issues.apache.org/jira/browse/HBASE-5952
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Fix For: 0.92.2
>
> Attachments: hbase-5952.patch
>
>
> Since the hardcoded default flush size is 64MB, but the default in hbase-default.xml is 128MB, if the client does set it to 64MB,
> the actual flush size will be 128MB instead, due to the way HRegion get the flush size. We can change how HRegion get the flush size,
> but it is clean and simple to sync up the defaults.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5952) Sync hardcoded default flush size
and max file size with hbase-default.xml
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269971#comment-13269971 ]
Hadoop QA commented on HBASE-5952:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12525920/hbase-5952.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1792//console
This message is automatically generated.
> Sync hardcoded default flush size and max file size with hbase-default.xml
> --------------------------------------------------------------------------
>
> Key: HBASE-5952
> URL: https://issues.apache.org/jira/browse/HBASE-5952
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Fix For: 0.92.2
>
> Attachments: hbase-5952.patch
>
>
> Since the hardcoded default flush size is 64MB, but the default in hbase-default.xml is 128MB, if the client does set it to 64MB,
> the actual flush size will be 128MB instead, due to the way HRegion get the flush size. We can change how HRegion get the flush size,
> but it is clean and simple to sync up the defaults.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5952) Sync hardcoded default flush size
and max file size with hbase-default.xml
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270009#comment-13270009 ]
Jimmy Xiang commented on HBASE-5952:
------------------------------------
@Ted, this patch is just for 0.92. Trunk and 0.94 don't have this problem.
This patch applies well for me on my 0.92 branch. Probably git is out of sync with svn again.
> Sync hardcoded default flush size and max file size with hbase-default.xml
> --------------------------------------------------------------------------
>
> Key: HBASE-5952
> URL: https://issues.apache.org/jira/browse/HBASE-5952
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Fix For: 0.92.2
>
> Attachments: hbase-5952.patch
>
>
> Since the hardcoded default flush size is 64MB, but the default in hbase-default.xml is 128MB, if the client does set it to 64MB,
> the actual flush size will be 128MB instead, due to the way HRegion get the flush size. We can change how HRegion get the flush size,
> but it is clean and simple to sync up the defaults.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5952) Sync hardcoded default flush size and
max file size with hbase-default.xml
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-5952:
-------------------------------
Attachment: hbase-5952.patch
> Sync hardcoded default flush size and max file size with hbase-default.xml
> --------------------------------------------------------------------------
>
> Key: HBASE-5952
> URL: https://issues.apache.org/jira/browse/HBASE-5952
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Fix For: 0.92.2
>
> Attachments: hbase-5952.patch
>
>
> Since the hardcoded default flush size is 64MB, but the default in hbase-default.xml is 128MB, if the client does set it to 64MB,
> the actual flush size will be 128MB instead, due to the way HRegion get the flush size. We can change how HRegion get the flush size,
> but it is clean and simple to sync up the defaults.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5952) Sync hardcoded default flush size and
max file size with hbase-default.xml
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-5952:
-------------------------------
Status: Patch Available (was: Open)
> Sync hardcoded default flush size and max file size with hbase-default.xml
> --------------------------------------------------------------------------
>
> Key: HBASE-5952
> URL: https://issues.apache.org/jira/browse/HBASE-5952
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Fix For: 0.92.2
>
> Attachments: hbase-5952.patch
>
>
> Since the hardcoded default flush size is 64MB, but the default in hbase-default.xml is 128MB, if the client does set it to 64MB,
> the actual flush size will be 128MB instead, due to the way HRegion get the flush size. We can change how HRegion get the flush size,
> but it is clean and simple to sync up the defaults.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5952) Sync hardcoded default flush size and
max file size with hbase-default.xml
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5952:
-------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to 0.92 branch. Thanks for the patch Jimmy.
> Sync hardcoded default flush size and max file size with hbase-default.xml
> --------------------------------------------------------------------------
>
> Key: HBASE-5952
> URL: https://issues.apache.org/jira/browse/HBASE-5952
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Fix For: 0.92.2
>
> Attachments: hbase-5952.patch
>
>
> Since the hardcoded default flush size is 64MB, but the default in hbase-default.xml is 128MB, if the client does set it to 64MB,
> the actual flush size will be 128MB instead, due to the way HRegion get the flush size. We can change how HRegion get the flush size,
> but it is clean and simple to sync up the defaults.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5952) Sync hardcoded default flush size
and max file size with hbase-default.xml
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270014#comment-13270014 ]
Jimmy Xiang commented on HBASE-5952:
------------------------------------
@Stack, thanks for review and commit it.
> Sync hardcoded default flush size and max file size with hbase-default.xml
> --------------------------------------------------------------------------
>
> Key: HBASE-5952
> URL: https://issues.apache.org/jira/browse/HBASE-5952
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.2
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Fix For: 0.92.2
>
> Attachments: hbase-5952.patch
>
>
> Since the hardcoded default flush size is 64MB, but the default in hbase-default.xml is 128MB, if the client does set it to 64MB,
> the actual flush size will be 128MB instead, due to the way HRegion get the flush size. We can change how HRegion get the flush size,
> but it is clean and simple to sync up the defaults.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira