You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "lostluck (via GitHub)" <gi...@apache.org> on 2023/06/15 19:47:18 UTC
[GitHub] [beam] lostluck opened a new pull request, #27144: [prism] UI improvements.
lostluck opened a new pull request, #27144:
URL: https://github.com/apache/beam/pull/27144
Does a number of things to improve the Prism runner UI experience.
* Allows the UI to be pointed to any JobManagement instance, where it will render the information it gets.
* Improve the JobDetails page with topologically sorted transforms, and the input and output pcollection element counts.
* Have the state included in the details page.
* Include basic instructions on using the stand alone prism command.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #27144: [prism] UI improvements.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck merged PR #27144:
URL: https://github.com/apache/beam/pull/27144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #27144: [prism] UI improvements.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #27144:
URL: https://github.com/apache/beam/pull/27144#issuecomment-1600653061
Thank you kindly for that! Meant yo merge this a bit earlier but vacation is vacation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on pull request #27144: [prism] UI improvements.
Posted by "riteshghorse (via GitHub)" <gi...@apache.org>.
riteshghorse commented on PR #27144:
URL: https://github.com/apache/beam/pull/27144#issuecomment-1595028029
Run GoPortable PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #27144: [prism] UI improvements.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #27144:
URL: https://github.com/apache/beam/pull/27144#issuecomment-1594155723
Run Go Precommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on pull request #27144: [prism] UI improvements.
Posted by "riteshghorse (via GitHub)" <gi...@apache.org>.
riteshghorse commented on PR #27144:
URL: https://github.com/apache/beam/pull/27144#issuecomment-1595124486
Run Whitespace PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on pull request #27144: [prism] UI improvements.
Posted by "riteshghorse (via GitHub)" <gi...@apache.org>.
riteshghorse commented on PR #27144:
URL: https://github.com/apache/beam/pull/27144#issuecomment-1595124375
Run RAT PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27144: [prism] UI improvements.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27144:
URL: https://github.com/apache/beam/pull/27144#issuecomment-1593691433
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @riteshghorse for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #27144: [prism] UI improvements.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #27144:
URL: https://github.com/apache/beam/pull/27144#issuecomment-1593644829
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/27144?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#27144](https://app.codecov.io/gh/apache/beam/pull/27144?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8c00c5d) into [master](https://app.codecov.io/gh/apache/beam/commit/644f5399dce646ba9b6b0146b44ff7778fc0a8c1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (644f539) will **decrease** coverage by `0.03%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #27144 +/- ##
==========================================
- Coverage 71.61% 71.59% -0.03%
==========================================
Files 854 854
Lines 104123 104134 +11
==========================================
- Hits 74571 74550 -21
- Misses 28004 28035 +31
- Partials 1548 1549 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `53.66% <0.00%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/beam/pull/27144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...m/runners/prism/internal/jobservices/management.go](https://app.codecov.io/gh/apache/beam/pull/27144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL3ByaXNtL2ludGVybmFsL2pvYnNlcnZpY2VzL21hbmFnZW1lbnQuZ28=) | `63.81% <0.00%> (-3.74%)` | :arrow_down: |
... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/27144/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #27144: [prism] UI improvements.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #27144:
URL: https://github.com/apache/beam/pull/27144#issuecomment-1593676510
The next PR in this space is going to re-factor and test the various sub bits of the web server, since that coverage number bothers me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on pull request #27144: [prism] UI improvements.
Posted by "riteshghorse (via GitHub)" <gi...@apache.org>.
riteshghorse commented on PR #27144:
URL: https://github.com/apache/beam/pull/27144#issuecomment-1599442179
There were a couple of whitespace lint. I went ahead and did it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org