You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/09/26 08:05:25 UTC
[PR] Refactor openGauss WAL loop high-frequency annotation scope [shardingsphere]
terrymanu opened a new pull request, #39965:
URL: https://github.com/apache/shardingsphere/pull/39965
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor openGauss WAL loop high-frequency annotation scope [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39965:
URL: https://github.com/apache/shardingsphere/pull/39965#issuecomment-5844476071
### Result
**Review Result: Mergeable**
The local candidate meets the requested extraction and annotation scope.
### Evidence
- The 14-line WAL `while` loop changed only in indentation. Polling, decoding, event handling, and position updates remain in the same order.
- `runBlocking()` still retries `SQLException`; `InterruptedException` still propagates through the original call chain; and the `finally` cleanup structure is unchanged.
- `OpenGaussIncrementalDumperTest`: 5 tests passed. Targeted Spotless: 1 file passed. Checkstyle: 0 violations.
- `git diff --check` passed when run with the repository’s indented-blank-line convention.
### Coverage
- Standalone local candidate. The baseline is the working tree at the start of the task. The task change is limited to extracting the loop and adjusting the annotation in `OpenGaussIncrementalDumper.java`.
- Behavior paths, contracts and impact, tests, and resource lifecycle were reviewed. No unresolved issues remain.
- This is a code-scope conclusion; CI was not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor openGauss WAL loop high-frequency annotation scope [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39965:
URL: https://github.com/apache/shardingsphere/pull/39965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org