[index] Should MergePolicy.MergeSpecification be Cloneable

[Nathan Beyer <nd...@apache.org>]

The inner class org.apache.lucene.index.MergePolicy.MergeSpecification
implements the Cloneable tag interface, but doesn't actually implement
a clone method. Should this class really be cloneable? Based on the
fact that MergeSpecification maintains a list of OneMerge objects,
which aren't cloneable, I'm guessing cloneable isn't desired.

I can whip up a patch either way, though removing Cloneable wouldn't
be much of a patch. Let me know.

-nathan

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org

Re: [index] Should MergePolicy.MergeSpecification be Cloneable

["Michael (Lucene) McCandless" <lu...@mikemccandless.com>]

Indeed, it should not be!  I'll remove it...thanks!

Mike

<nd...@apache.org> wrote:
> The inner class org.apache.lucene.index.MergePolicy.MergeSpecification
> implements the Cloneable tag interface, but doesn't actually implement
> a clone method. Should this class really be cloneable? Based on the
> fact that MergeSpecification maintains a list of OneMerge objects,
> which aren't cloneable, I'm guessing cloneable isn't desired.
>
> I can whip up a patch either way, though removing Cloneable wouldn't
> be much of a patch. Let me know.
>
> -nathan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org