[GitHub] eolivelli commented on a change in pull request #1186: Propogate exception when bookie shutdown fails

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #1186: Propogate exception when bookie shutdown fails
URL: https://github.com/apache/bookkeeper/pull/1186#discussion_r169305604
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/server/Main.java
 ##########
 @@ -211,13 +211,14 @@ static int doMain(String[] args) {
         }
 
         // 2. start the server
-        CountDownLatch aliveLatch = new CountDownLatch(1);
-        ComponentStarter.startComponent(server, aliveLatch);
         try {
-            aliveLatch.await();
+            ComponentStarter.startComponent(server).get();
         } catch (InterruptedException ie) {
             // the server is interrupted
             log.info("Bookie server is interrupted. Exiting ...");
+        } catch (ExecutionException ee) {
+            log.error("Error in bookie shutdown", ee);
 
 Review comment:
   Better to log ee.getCause() ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services