You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/10/02 03:20:00 UTC

[GitHub] [incubator-gobblin] arjun4084346 commented on a change in pull request #2747: [GOBBLIN-892] reverting back bad changes done in PR 2720

arjun4084346 commented on a change in pull request #2747: [GOBBLIN-892] reverting back bad changes done in PR 2720
URL: https://github.com/apache/incubator-gobblin/pull/2747#discussion_r330358289
 
 

 ##########
 File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/SafeDatasetCommit.java
 ##########
 @@ -326,11 +326,6 @@ private void finalizeDatasetStateBeforeCommit(JobState.DatasetState datasetState
         // The dataset state is set to FAILED if any task failed and COMMIT_ON_FULL_SUCCESS is used
         datasetState.setState(JobState.RunningState.FAILED);
         datasetState.incrementJobFailures();
-        Optional<String> taskStateException = taskState.getTaskFailureException();
-        String errMsg = "At least one task did not committed successfully. Setting dataset state to FAILED. "
-            + (taskStateException.isPresent() ? taskStateException.get() : "Exception not set.");
-        log.warn(errMsg);
 
 Review comment:
   I am quite sure this warning must have got in the original-place-of-failure. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services