You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/06 14:53:55 UTC
[GitHub] [flink] libenchao opened a new pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
libenchao opened a new pull request #13081:
URL: https://github.com/apache/flink/pull/13081
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Support JSON deserializes json array to multi records.
## Brief change log
Support JSON deserializes json array to multi records.
## Verifying this change
This change added tests and can be verified as follows:
- JsonRowDataSerDeSchemaTest#testJsonArrayToMultiRecords
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13081:
URL: https://github.com/apache/flink/pull/13081#issuecomment-669992819
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c40e55a11ae4f9fc5a5c31aa6963f461a7ae70d0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5255",
"triggerID" : "c40e55a11ae4f9fc5a5c31aa6963f461a7ae70d0",
"triggerType" : "PUSH"
}, {
"hash" : "c7fb5b2d797825ff3b76733529fad8508d967002",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8225",
"triggerID" : "c7fb5b2d797825ff3b76733529fad8508d967002",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c7fb5b2d797825ff3b76733529fad8508d967002 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8225)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #13081:
URL: https://github.com/apache/flink/pull/13081#discussion_r512397979
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDataDeserializationSchema.java
##########
@@ -130,6 +133,39 @@ public RowData deserialize(byte[] message) throws IOException {
}
}
+ @Override
Review comment:
Could you create an issue for this and add comment in the `deserialize(byte[] message)` method?
I think the problem is that some connector doesn't migrate to `deserialize(byte[] message, Collector<RowData> out)` yet, for example, Kinesis. If we remove the implementation of `deserialize(byte[] message)`, the upcoming Kinesis SQL connector will not support JSON format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on pull request #13081:
URL: https://github.com/apache/flink/pull/13081#issuecomment-1018272859
@poan0508 this PR is looking for someone to finalize it. Wanna take a crack at it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] libenchao commented on pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
Posted by GitBox <gi...@apache.org>.
libenchao commented on pull request #13081:
URL: https://github.com/apache/flink/pull/13081#issuecomment-715921192
@wuchong Sorry for the lateness. I've addressed most of your comments, could you have another look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on pull request #13081:
URL: https://github.com/apache/flink/pull/13081#issuecomment-924865986
Hi @libenchao are you still interested in working on this issue? Can you rebase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #13081:
URL: https://github.com/apache/flink/pull/13081#discussion_r512399078
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDataDeserializationSchema.java
##########
@@ -130,6 +133,39 @@ public RowData deserialize(byte[] message) throws IOException {
}
}
+ @Override
Review comment:
I still prefer to only keep one implementation, otherwise it's hard to maintain in the future. We should update the json tests to use collector methods to have full test coverage.
The Kinesis should migrate to collector method ASAP, rather than hacking JSON format for Kinesis. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13081:
URL: https://github.com/apache/flink/pull/13081#issuecomment-669992819
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c40e55a11ae4f9fc5a5c31aa6963f461a7ae70d0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c40e55a11ae4f9fc5a5c31aa6963f461a7ae70d0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c40e55a11ae4f9fc5a5c31aa6963f461a7ae70d0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13081:
URL: https://github.com/apache/flink/pull/13081#issuecomment-669992819
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c40e55a11ae4f9fc5a5c31aa6963f461a7ae70d0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5255",
"triggerID" : "c40e55a11ae4f9fc5a5c31aa6963f461a7ae70d0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c40e55a11ae4f9fc5a5c31aa6963f461a7ae70d0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5255)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13081:
URL: https://github.com/apache/flink/pull/13081#issuecomment-669980140
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c40e55a11ae4f9fc5a5c31aa6963f461a7ae70d0 (Thu Aug 06 14:56:47 UTC 2020)
**Warnings:**
* Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13081:
URL: https://github.com/apache/flink/pull/13081#issuecomment-669992819
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c40e55a11ae4f9fc5a5c31aa6963f461a7ae70d0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5255",
"triggerID" : "c40e55a11ae4f9fc5a5c31aa6963f461a7ae70d0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c40e55a11ae4f9fc5a5c31aa6963f461a7ae70d0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5255)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13081:
URL: https://github.com/apache/flink/pull/13081#issuecomment-669992819
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c40e55a11ae4f9fc5a5c31aa6963f461a7ae70d0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5255",
"triggerID" : "c40e55a11ae4f9fc5a5c31aa6963f461a7ae70d0",
"triggerType" : "PUSH"
}, {
"hash" : "c7fb5b2d797825ff3b76733529fad8508d967002",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c7fb5b2d797825ff3b76733529fad8508d967002",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c40e55a11ae4f9fc5a5c31aa6963f461a7ae70d0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5255)
* c7fb5b2d797825ff3b76733529fad8508d967002 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #13081:
URL: https://github.com/apache/flink/pull/13081#discussion_r467729328
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDataDeserializationSchema.java
##########
@@ -130,6 +133,39 @@ public RowData deserialize(byte[] message) throws IOException {
}
}
+ @Override
Review comment:
Remove the implementation of `deserialize(byte[] message)`, because it is never used now.
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDataDeserializationSchema.java
##########
@@ -130,6 +133,39 @@ public RowData deserialize(byte[] message) throws IOException {
}
}
+ @Override
+ public void deserialize(byte[] message, Collector<RowData> out) throws IOException {
+ try {
+ final JsonNode root = objectMapper.readTree(message);
+
+ if (root.isArray()) {
+ List<RowData> rowDataList = new ArrayList<>();
+ ArrayNode arrayNode = (ArrayNode) root;
+ for (int i = 0; i < arrayNode.size(); ++i) {
+ RowData result = (RowData) runtimeConverter.convert(arrayNode.get(i));
+ if (result != null) {
+ rowDataList.add(result);
+ }
+ }
+
+ // collect final results in a separate for-loop in case of parse errors.
Review comment:
I think the parse errors can still be catched if we collect each parsed row eagerly.
##########
File path: docs/dev/table/connectors/formats/json.md
##########
@@ -212,6 +212,53 @@ The following table lists the type mapping from Flink type to JSON type.
</tbody>
</table>
+How is json string converted to Flink SQL Row
Review comment:
Could you add this under a "Features" section like other pages?
Besides, we can use "Allow top-level JSON Arrays" as the sub-section title.
##########
File path: docs/dev/table/connectors/formats/json.md
##########
@@ -212,6 +212,53 @@ The following table lists the type mapping from Flink type to JSON type.
</tbody>
</table>
+How is json string converted to Flink SQL Row
+----------------
+Usually, we assume the outer most of json string is a json object. Then the json object is converted to one SQL row.
+
Review comment:
remove emtpy line
##########
File path: docs/dev/table/connectors/formats/json.md
##########
@@ -212,6 +212,53 @@ The following table lists the type mapping from Flink type to JSON type.
</tbody>
</table>
+How is json string converted to Flink SQL Row
+----------------
+Usually, we assume the outer most of json string is a json object. Then the json object is converted to one SQL row.
+
+
+There are some cases that, the outer most of json string is a json array, and we want to explode the array to
+multiple records, each one of the array is a json object which is converted to one row. Flink JSON Format supports
+read such data implicitly.
+
+For example, for the following SQL DDL:
+<div class="codetabs" markdown="1">
+<div data-lang="SQL" markdown="1">
+{% highlight sql %}
+CREATE TABLE user_behavior (
+ col1 BIGINT,
+ col2 DOUBLE,
+ col3 VARCHAR,
+ col4 BOOLEAN
+) WITH (
+ 'format' = 'json',
+ ...
+)
+{% endhighlight %}
+</div>
+</div>
+and with following json string:
+<div class="codetabs" markdown="1">
+<div data-lang="JSON" markdown="1">
+{% highlight json %}
+[
+ {
+ "col1": 123,
+ "col2": 12.34,
+ "col3": "str1",
+ "col4": true
+ },
+ {
+ "col1": 456,
+ "col2": 45.67,
+ "col3": "str2",
+ "col4": false
+ },
+]
+{% endhighlight %}
+</div>
+</div>
+Flink JSON Format will produce 2 records.
Review comment:
```suggestion
Flink JSON Format will produce 2 rows `(123, "a")` and `(456, "b")` with both of following two json string.
The top-level is JSON Array:
{% highlight json %}
[{"col1": 123, "col2": "a"}, {"col1": 456, "col2": "b"}]
{% endhighlight %}
The top-level is JSON Object:
{% highlight json %}
{"col1": 123, "col2": "a"}
{"col1": 456, "col2": "b"}
{% endhighlight %}
```
We can simplify the example with 2 columns, but with the result example.
##########
File path: docs/dev/table/connectors/formats/json.md
##########
@@ -212,6 +212,53 @@ The following table lists the type mapping from Flink type to JSON type.
</tbody>
</table>
+How is json string converted to Flink SQL Row
+----------------
+Usually, we assume the outer most of json string is a json object. Then the json object is converted to one SQL row.
Review comment:
outer most -> top-level
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on pull request #13081:
URL: https://github.com/apache/flink/pull/13081#issuecomment-925547477
Perfect! Once you're done, let me know and I'll review it. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] libenchao commented on pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
Posted by GitBox <gi...@apache.org>.
libenchao commented on pull request #13081:
URL: https://github.com/apache/flink/pull/13081#issuecomment-925459467
@slinkydeveloper Thanks for your interest, I'll rebase this pr and let's move forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13081:
URL: https://github.com/apache/flink/pull/13081#issuecomment-669992819
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c40e55a11ae4f9fc5a5c31aa6963f461a7ae70d0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5255",
"triggerID" : "c40e55a11ae4f9fc5a5c31aa6963f461a7ae70d0",
"triggerType" : "PUSH"
}, {
"hash" : "c7fb5b2d797825ff3b76733529fad8508d967002",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8225",
"triggerID" : "c7fb5b2d797825ff3b76733529fad8508d967002",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c40e55a11ae4f9fc5a5c31aa6963f461a7ae70d0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5255)
* c7fb5b2d797825ff3b76733529fad8508d967002 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8225)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] libenchao commented on pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
Posted by GitBox <gi...@apache.org>.
libenchao commented on pull request #13081:
URL: https://github.com/apache/flink/pull/13081#issuecomment-670486025
the ci failure is not relevant with this pr, it's passing on my private ci: https://dev.azure.com/libenchao/flink.benchao/_build/results?buildId=32&view=results
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] libenchao commented on a change in pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
Posted by GitBox <gi...@apache.org>.
libenchao commented on a change in pull request #13081:
URL: https://github.com/apache/flink/pull/13081#discussion_r511467564
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDataDeserializationSchema.java
##########
@@ -130,6 +133,39 @@ public RowData deserialize(byte[] message) throws IOException {
}
}
+ @Override
Review comment:
I agree that we should remove this method for json format. However there are many places that still call this method. We can do this work in one separate issue, WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13081:
URL: https://github.com/apache/flink/pull/13081#issuecomment-669992819
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c40e55a11ae4f9fc5a5c31aa6963f461a7ae70d0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5255",
"triggerID" : "c40e55a11ae4f9fc5a5c31aa6963f461a7ae70d0",
"triggerType" : "PUSH"
}, {
"hash" : "c7fb5b2d797825ff3b76733529fad8508d967002",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8225",
"triggerID" : "c7fb5b2d797825ff3b76733529fad8508d967002",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c7fb5b2d797825ff3b76733529fad8508d967002 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8225)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] poan0508 commented on pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
Posted by GitBox <gi...@apache.org>.
poan0508 commented on pull request #13081:
URL: https://github.com/apache/flink/pull/13081#issuecomment-1018136571
Hi ,we also have this kind issue ,when can done it ? Is there some plan ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org