You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/06/16 22:02:20 UTC
[GitHub] [iceberg] Fokko opened a new pull request, #5066: Python: Renable pylint
Fokko opened a new pull request, #5066:
URL: https://github.com/apache/iceberg/pull/5066
For some reason, pylint fell through the cracks when migrating from tox to pre-commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] dramaticlly commented on a diff in pull request #5066: Python: Renable pylint
Posted by GitBox <gi...@apache.org>.
dramaticlly commented on code in PR #5066:
URL: https://github.com/apache/iceberg/pull/5066#discussion_r900372196
##########
python/tests/io/test_pyarrow.py:
##########
@@ -14,6 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+# pylint: disable=W0212,W0613
Review Comment:
Nit: curious on how pylint update its code to warning mapping, from understanding perspective, it's easier to read `disable=protected-access`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #5066: Python: Renable pylint
Posted by GitBox <gi...@apache.org>.
Fokko commented on PR #5066:
URL: https://github.com/apache/iceberg/pull/5066#issuecomment-1158702003
I've removed the spellcheck because it relies on a C lib enchant that doesn't play very well with virtual-env. It can't find the binding anymore. I spend quite some time to get it to work, but no luck. Also looking at https://github.com/apache/iceberg/pull/4818 I've removed it for now since it is also not very friendly for new people to ask them to install system packages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on a diff in pull request #5066: Python: Renable pylint
Posted by GitBox <gi...@apache.org>.
Fokko commented on code in PR #5066:
URL: https://github.com/apache/iceberg/pull/5066#discussion_r901142072
##########
python/tests/io/test_pyarrow.py:
##########
@@ -14,6 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+# pylint: disable=W0212,W0613
Review Comment:
Thanks, I like that a lot. Just updated the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] danielcweeks merged pull request #5066: Python: Renable pylint
Posted by GitBox <gi...@apache.org>.
danielcweeks merged PR #5066:
URL: https://github.com/apache/iceberg/pull/5066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] dramaticlly commented on a diff in pull request #5066: Python: Renable pylint
Posted by GitBox <gi...@apache.org>.
dramaticlly commented on code in PR #5066:
URL: https://github.com/apache/iceberg/pull/5066#discussion_r900372196
##########
python/tests/io/test_pyarrow.py:
##########
@@ -14,6 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+# pylint: disable=W0212,W0613
Review Comment:
Nit: curious on how pylint update its code to warning mapping, from understanding perspective, it's easier to read `disable=protected-access` per https://pylint.pycqa.org/en/latest/user_guide/messages/warning/protected-access.html?highlight=W0212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org