You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@myfaces.apache.org by we...@apache.org on 2008/01/16 18:08:53 UTC

svn commit: r612518 - /myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/taglib/extension/LabelExtensionTag.java

Author: weber
Date: Wed Jan 16 09:08:49 2008
New Revision: 612518

URL: http://svn.apache.org/viewvc?rev=612518&view=rev
Log:
(TOBAGO-598) el in labelWidth did not work in tx:* tags
<http://issues.apache.org/jira/browse/TOBAGO-598>

Modified:
    myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/taglib/extension/LabelExtensionTag.java

Modified: myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/taglib/extension/LabelExtensionTag.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/taglib/extension/LabelExtensionTag.java?rev=612518&r1=612517&r2=612518&view=diff
==============================================================================
--- myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/taglib/extension/LabelExtensionTag.java (original)
+++ myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/taglib/extension/LabelExtensionTag.java Wed Jan 16 09:08:49 2008
@@ -30,6 +30,7 @@
 import org.apache.myfaces.tobago.util.LayoutUtil;
 
 import javax.faces.webapp.FacetTag;
+import javax.faces.webapp.UIComponentTag;
 import javax.servlet.jsp.JspException;
 import javax.servlet.jsp.tagext.BodyTagSupport;
 
@@ -123,7 +124,7 @@
   }
 
   void setColumns(String columns) {
-    if (!LayoutUtil.checkTokens(columns)) {
+    if (!(UIComponentTag.isValueReference(columns) || LayoutUtil.checkTokens(columns))) {
       LOG.warn("Illegal value for columns = \"" + columns + "\" replacing with default: \"" + DEFAULT_COLUMNS + "\"");
       this.columns = DEFAULT_COLUMNS;
     } else {