You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2026/04/02 11:14:34 UTC
[PR] CI: Remove GraalVM job [netbeans]
mbien opened a new pull request, #9319:
URL: https://github.com/apache/netbeans/pull/9319
as discussed in https://github.com/apache/netbeans/pull/9302, the GraalVM job became somewhat redundant
- the tests can run on regular JDKs, GraalVM's polyglot features became dependencies in past (e.g 9931c15)
- the modules are already covered by the java, debugger, ide, profiler and platform jobs (only the nashorn module needed to be moved)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] CI: Remove GraalVM job [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #9319:
URL: https://github.com/apache/netbeans/pull/9319#issuecomment-4190348364
thanks for the review, will merge to reduce the PR count a little.
another thing we could do as followup is to update the graalvm dependencies which had the same version for 2 years:
https://github.com/apache/netbeans/blob/8cc2feb75cb748c7a31b315052970ecee147fd77/ide/libs.graalsdk.system/external/binaries-list#L17-L23
https://github.com/apache/netbeans/blob/8cc2feb75cb748c7a31b315052970ecee147fd77/ide/libs.graalsdk/external/binaries-list#L17-L23
https://github.com/apache/netbeans/blob/8cc2feb75cb748c7a31b315052970ecee147fd77/ide/libs.truffleapi/external/binaries-list#L17-L19
https://github.com/apache/netbeans/blob/8cc2feb75cb748c7a31b315052970ecee147fd77/webcommon/libs.graaljs/external/binaries-list#L17-L21
I checked and 25.x would still use JDK 17 as baseline - so we would be good there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] CI: Remove GraalVM job [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #9319:
URL: https://github.com/apache/netbeans/pull/9319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] CI: Remove GraalVM job [netbeans]
Posted by "jtulach (via GitHub)" <gi...@apache.org>.
jtulach commented on code in PR #9319:
URL: https://github.com/apache/netbeans/pull/9319#discussion_r3036442614
##########
.github/workflows/main.yml:
##########
@@ -2543,66 +2543,6 @@ jobs:
paths: "./*/*/build/test/*/results/TEST-*.xml"
- graalvm-test:
- name: GraalVM ${{ matrix.graal }} Tests
- # equals env.test_graalvm == 'true'
- if: ${{ contains(github.event.pull_request.labels.*.name, 'GraalVM') || contains(github.event.pull_request.labels.*.name, 'ci:all-tests') || github.event_name != 'pull_request' }}
- needs: base-build
- runs-on: ubuntu-latest
- timeout-minutes: 60
- strategy:
- matrix:
- graal: [ '21.0.2' ]
- fail-fast: false
-
- steps:
- - name: Setup Xvfb
- run: |
- echo "DISPLAY=:99.0" >> $GITHUB_ENV
- Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
-
- - name: Download Build
- uses: actions/download-artifact@v8
- with:
- name: build.tar.zst
-
- - name: Extract
- run: tar --zstd -xf build.tar.zst
-
- - name: Setup GraalVM ${{ matrix.graal }}
- run: |
- URL=https://github.com/graalvm/graalvm-ce-builds/releases/download/jdk-${{ matrix.graal }}/graalvm-community-jdk-${{ matrix.graal }}_linux-x64_bin.tar.gz
- curl -L $URL | tar -xz
- GRAALVM=$(realpath graalvm-community-openjdk-*)
- echo "JAVA_HOME=$GRAALVM" >> $GITHUB_ENV
-
- - name: platform/core.network
Review Comment:
This module is using Graal.js to process proxy configuration files. They are executed once and running at any JDK21+ is going to be fast enough.
##########
.github/workflows/main.yml:
##########
@@ -2543,66 +2543,6 @@ jobs:
paths: "./*/*/build/test/*/results/TEST-*.xml"
- graalvm-test:
- name: GraalVM ${{ matrix.graal }} Tests
- # equals env.test_graalvm == 'true'
- if: ${{ contains(github.event.pull_request.labels.*.name, 'GraalVM') || contains(github.event.pull_request.labels.*.name, 'ci:all-tests') || github.event_name != 'pull_request' }}
- needs: base-build
- runs-on: ubuntu-latest
- timeout-minutes: 60
- strategy:
- matrix:
- graal: [ '21.0.2' ]
- fail-fast: false
-
- steps:
- - name: Setup Xvfb
- run: |
- echo "DISPLAY=:99.0" >> $GITHUB_ENV
- Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
-
- - name: Download Build
- uses: actions/download-artifact@v8
- with:
- name: build.tar.zst
-
- - name: Extract
- run: tar --zstd -xf build.tar.zst
-
- - name: Setup GraalVM ${{ matrix.graal }}
- run: |
- URL=https://github.com/graalvm/graalvm-ce-builds/releases/download/jdk-${{ matrix.graal }}/graalvm-community-jdk-${{ matrix.graal }}_linux-x64_bin.tar.gz
- curl -L $URL | tar -xz
- GRAALVM=$(realpath graalvm-community-openjdk-*)
- echo "JAVA_HOME=$GRAALVM" >> $GITHUB_ENV
-
- - name: platform/core.network
- run: ant $OPTS -f platform/core.network test
-
- - name: platform/api.scripting
- run: ant $OPTS -f platform/api.scripting test
-
- - name: ide/libs.graalsdk
- run: ant $OPTS -f ide/libs.graalsdk test
-
- - name: webcommon/libs.graaljs
- run: ant $OPTS -f webcommon/libs.graaljs test
-
- - name: profiler/profiler.oql
- run: ant $OPTS -f profiler/profiler.oql test
-
- - name: java/nashorn.execution
- run: ant $OPTS -f java/nashorn.execution test
-
- - name: java/debugger.jpda.truffle
- run: .github/retry.sh ant $OPTS -f java/debugger.jpda.truffle test
Review Comment:
- thanks to recent work of @lahodaj in #9302
- these tests can run on OpenJDK and I am very thankful for that
##########
.github/workflows/main.yml:
##########
@@ -2543,66 +2543,6 @@ jobs:
paths: "./*/*/build/test/*/results/TEST-*.xml"
- graalvm-test:
- name: GraalVM ${{ matrix.graal }} Tests
- # equals env.test_graalvm == 'true'
- if: ${{ contains(github.event.pull_request.labels.*.name, 'GraalVM') || contains(github.event.pull_request.labels.*.name, 'ci:all-tests') || github.event_name != 'pull_request' }}
- needs: base-build
- runs-on: ubuntu-latest
- timeout-minutes: 60
- strategy:
- matrix:
- graal: [ '21.0.2' ]
- fail-fast: false
-
- steps:
- - name: Setup Xvfb
- run: |
- echo "DISPLAY=:99.0" >> $GITHUB_ENV
- Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
-
- - name: Download Build
- uses: actions/download-artifact@v8
- with:
- name: build.tar.zst
-
- - name: Extract
- run: tar --zstd -xf build.tar.zst
-
- - name: Setup GraalVM ${{ matrix.graal }}
- run: |
- URL=https://github.com/graalvm/graalvm-ce-builds/releases/download/jdk-${{ matrix.graal }}/graalvm-community-jdk-${{ matrix.graal }}_linux-x64_bin.tar.gz
- curl -L $URL | tar -xz
- GRAALVM=$(realpath graalvm-community-openjdk-*)
- echo "JAVA_HOME=$GRAALVM" >> $GITHUB_ENV
-
- - name: platform/core.network
- run: ant $OPTS -f platform/core.network test
-
- - name: platform/api.scripting
- run: ant $OPTS -f platform/api.scripting test
Review Comment:
- Graal.js is no longer part of GraalVM
- it is a normal Maven library
- hence testing this module on any OpenJDK21+ is enough
##########
.github/workflows/main.yml:
##########
@@ -2543,66 +2543,6 @@ jobs:
paths: "./*/*/build/test/*/results/TEST-*.xml"
- graalvm-test:
- name: GraalVM ${{ matrix.graal }} Tests
- # equals env.test_graalvm == 'true'
- if: ${{ contains(github.event.pull_request.labels.*.name, 'GraalVM') || contains(github.event.pull_request.labels.*.name, 'ci:all-tests') || github.event_name != 'pull_request' }}
- needs: base-build
- runs-on: ubuntu-latest
- timeout-minutes: 60
- strategy:
- matrix:
- graal: [ '21.0.2' ]
- fail-fast: false
-
- steps:
- - name: Setup Xvfb
- run: |
- echo "DISPLAY=:99.0" >> $GITHUB_ENV
- Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
-
- - name: Download Build
- uses: actions/download-artifact@v8
- with:
- name: build.tar.zst
-
- - name: Extract
- run: tar --zstd -xf build.tar.zst
-
- - name: Setup GraalVM ${{ matrix.graal }}
Review Comment:
Yeah, since GraalVM for JDK 21+ there is no difference between OpenJDK and GraalVM with respect to Graal.js except speed (peak performance of JavaScript). NetBeans don't need peak performance of JavaScript for the usecases tested here-in...
##########
.github/workflows/main.yml:
##########
@@ -2543,66 +2543,6 @@ jobs:
paths: "./*/*/build/test/*/results/TEST-*.xml"
- graalvm-test:
- name: GraalVM ${{ matrix.graal }} Tests
- # equals env.test_graalvm == 'true'
- if: ${{ contains(github.event.pull_request.labels.*.name, 'GraalVM') || contains(github.event.pull_request.labels.*.name, 'ci:all-tests') || github.event_name != 'pull_request' }}
- needs: base-build
- runs-on: ubuntu-latest
- timeout-minutes: 60
- strategy:
- matrix:
- graal: [ '21.0.2' ]
- fail-fast: false
-
- steps:
- - name: Setup Xvfb
- run: |
- echo "DISPLAY=:99.0" >> $GITHUB_ENV
- Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
-
- - name: Download Build
- uses: actions/download-artifact@v8
- with:
- name: build.tar.zst
-
- - name: Extract
- run: tar --zstd -xf build.tar.zst
-
- - name: Setup GraalVM ${{ matrix.graal }}
- run: |
- URL=https://github.com/graalvm/graalvm-ce-builds/releases/download/jdk-${{ matrix.graal }}/graalvm-community-jdk-${{ matrix.graal }}_linux-x64_bin.tar.gz
- curl -L $URL | tar -xz
- GRAALVM=$(realpath graalvm-community-openjdk-*)
- echo "JAVA_HOME=$GRAALVM" >> $GITHUB_ENV
-
- - name: platform/core.network
- run: ant $OPTS -f platform/core.network test
-
- - name: platform/api.scripting
- run: ant $OPTS -f platform/api.scripting test
-
- - name: ide/libs.graalsdk
- run: ant $OPTS -f ide/libs.graalsdk test
-
- - name: webcommon/libs.graaljs
- run: ant $OPTS -f webcommon/libs.graaljs test
-
- - name: profiler/profiler.oql
- run: ant $OPTS -f profiler/profiler.oql test
Review Comment:
- profilier is using some JavaScript integration
- as Graal.js is no longer distributed as part of GraalVM
- testing on any OpenJDK21+ is enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] CI: Remove GraalVM job [netbeans]
Posted by "jtulach (via GitHub)" <gi...@apache.org>.
jtulach commented on PR #9319:
URL: https://github.com/apache/netbeans/pull/9319#issuecomment-4190547217
> I checked and 25.x would still use JDK 17 as baseline - so we would be good there.
Some upgrade is certainly possible. But which version still supports OpenJDK21 and which runs only on OpenJDK25?
<img width="1164" height="818" alt="image" src="https://github.com/user-attachments/assets/ba3987f0-daf8-446b-8d98-eae7654c4243" />
I saw some matrix of versions at GraalVM Summit in autumn, but I cannot find it. I guess it is best to ask the expert: Andreas @woess, what would be your recommended version to upgrade to if NetBeans want to run Graal.js on OpenJDK21? Thanks for your advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] CI: Remove GraalVM job [netbeans]
Posted by "woess (via GitHub)" <gi...@apache.org>.
woess commented on PR #9319:
URL: https://github.com/apache/netbeans/pull/9319#issuecomment-4214626119
@jtulach Graal.js **25.0**.x still supports (open)jdk21, so I would recommend that.
I don't know why tests fail, so I can't comment on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] CI: Remove GraalVM job [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #9319:
URL: https://github.com/apache/netbeans/pull/9319#issuecomment-4191707174
here is a wip branch https://github.com/mbien/netbeans/tree/graal2502, unfortunately the tests fail. I haven't looked at the migration guide since I ran out of time. Appears to be CL related (e.g GraalJSTest fails when ran via the project, while GraalJSTest2 works when invoked directly via IDE).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists