[jira] [Commented] (AIRFLOW-3178) `airflow run` config doens't cope with % in config values.

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742020#comment-16742020 ] 

ASF subversion and git services commented on AIRFLOW-3178:
----------------------------------------------------------

Commit c3dc3b4f8610d852f99cdae9a5614025de279c46 in airflow's branch refs/heads/dont-bake-env-into-tmp-config from Ash Berlin-Taylor
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=c3dc3b4 ]

[AIRFLOW-3178] Don't bake ENV and _cmd into tmp config for non-sudo

If we are running tasks via sudo then AIRFLOW__ config env vars won't be
visible anymore (without them showing up in `ps`) and we likely might
not have permission to run the _cmd's specified to find the passwords.

But if we are running as the same user then there is no need to "bake"
those options in to the temporary config file -- if the operator decided
they didn't want those values appearing in a config file on disk, then
lets do our best to respect that.

This also removes a possible race condition that would make temporary
config file be readable by more than the airflow or run-as user
The exact behaviour would depend on the umask we run under, and the
primary group of our user, likely this would mean the file was readably
by members of the airflow group (which in most cases would be just the
airflow user). To remove any such possibility set the umask before we
write anything to the file.


> `airflow run` config doens't cope with % in config values.
> ----------------------------------------------------------
>
>                 Key: AIRFLOW-3178
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3178
>             Project: Apache Airflow
>          Issue Type: Bug
>    Affects Versions: 1.10.0
>            Reporter: Ash Berlin-Taylor
>            Assignee: Ash Berlin-Taylor
>            Priority: Major
>             Fix For: 1.10.1
>
>
> ConfigParser uses %-signs for interpolation, so if you need a literal % in airflow.cfg it needs to be  escaped in by specifying them as {{%%}}), but by the time they are written out to the temporary config that is passed to `airflow run` they escaping is lost.
> This is also true for configuration via environment variables, where {{%}} doesn't need to be escaped at all, but is included (sometimes needlessly) in the config un-escaped.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)