You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Manjula Kutty (JIRA)" <ji...@apache.org> on 2007/02/08 23:29:05 UTC
[jira] Created: (DERBY-2313) create backup directory relative to
the current working dir while running the system test
create backup directory relative to the current working dir while running the system test
-----------------------------------------------------------------------------------------
Key: DERBY-2313
URL: https://issues.apache.org/jira/browse/DERBY-2313
Project: Derby
Issue Type: Sub-task
Components: Test
Affects Versions: 10.3.0.0
Reporter: Manjula Kutty
Assigned To: Manjula Kutty
create backup directory relative to the current working dir
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (DERBY-2313) create backup directory relative to the current working dir while running the system test
Posted by Manjula Kutty <ma...@gmail.com>.
If the patch looks good can any one please commit this small patch?
On 2/28/07, Manjula Kutty (JIRA) <ji...@apache.org> wrote:
>
>
> [
> https://issues.apache.org/jira/browse/DERBY-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Manjula Kutty updated DERBY-2313:
> ---------------------------------
>
> Derby Info: [Patch Available]
>
> > create backup directory relative to the current working dir while
> running the system test
> >
> -----------------------------------------------------------------------------------------
> >
> > Key: DERBY-2313
> > URL: https://issues.apache.org/jira/browse/DERBY-2313
> > Project: Derby
> > Issue Type: Sub-task
> > Components: Test
> > Affects Versions: 10.3.0.0
> > Reporter: Manjula Kutty
> > Assigned To: Manjula Kutty
> > Attachments: DERBY-2313_diff.txt, DERBY-2313_patch2_diff.txt
> >
> >
> > create backup directory relative to the current working dir
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Commented: (DERBY-2313) create backup directory relative to
the current working dir while running the system test
Posted by "Mamta A. Satoor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473621 ]
Mamta A. Satoor commented on DERBY-2313:
----------------------------------------
Manjula, while going through the patch, I noticed following line
+ cs.setString(1, "." + File.separator + "mailbackup");
Use of "." for current directory will not work acorss platforms and I think it should be replaced with something portable.
> create backup directory relative to the current working dir while running the system test
> -----------------------------------------------------------------------------------------
>
> Key: DERBY-2313
> URL: https://issues.apache.org/jira/browse/DERBY-2313
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Manjula Kutty
> Assigned To: Manjula Kutty
> Attachments: DERBY-2313_diff.txt
>
>
> create backup directory relative to the current working dir
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2313) create backup directory relative to
the current working dir while running the system test
Posted by "Manjula Kutty (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Manjula Kutty updated DERBY-2313:
---------------------------------
Derby Info: [Patch Available]
> create backup directory relative to the current working dir while running the system test
> -----------------------------------------------------------------------------------------
>
> Key: DERBY-2313
> URL: https://issues.apache.org/jira/browse/DERBY-2313
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Manjula Kutty
> Assigned To: Manjula Kutty
> Attachments: DERBY-2313_diff.txt, DERBY-2313_patch2_diff.txt
>
>
> create backup directory relative to the current working dir
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2313) create backup directory relative to
the current working dir while running the system test
Posted by "Manjula Kutty (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Manjula Kutty updated DERBY-2313:
---------------------------------
Comment: was deleted
> create backup directory relative to the current working dir while running the system test
> -----------------------------------------------------------------------------------------
>
> Key: DERBY-2313
> URL: https://issues.apache.org/jira/browse/DERBY-2313
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Manjula Kutty
> Assigned To: Manjula Kutty
> Attachments: DERBY-2313_diff.txt, DERBY-2313_diff2.txt, DERBY-2313_patch2_diff.txt
>
>
> create backup directory relative to the current working dir
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2313) create backup directory relative to
the current working dir while running the system test
Posted by "Andrew McIntyre (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477546 ]
Andrew McIntyre commented on DERBY-2313:
----------------------------------------
There are still a lot of whitespace diffs in the patch, and it appears that some printlns have been added, as well as some removed, although it does appear to have condensed the overall output. I'll assume this is intentional and commit this patch shortly unless I hear otherwise.
> create backup directory relative to the current working dir while running the system test
> -----------------------------------------------------------------------------------------
>
> Key: DERBY-2313
> URL: https://issues.apache.org/jira/browse/DERBY-2313
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Manjula Kutty
> Assigned To: Manjula Kutty
> Attachments: DERBY-2313_diff.txt, DERBY-2313_diff2.txt, DERBY-2313_patch2_diff.txt
>
>
> create backup directory relative to the current working dir
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2313) create backup directory relative to
the current working dir while running the system test
Posted by "Manjula Kutty (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Manjula Kutty updated DERBY-2313:
---------------------------------
Attachment: DERBY-2313_diff2.txt
Attaching the patch with only backup directory change. Please review and commit
> create backup directory relative to the current working dir while running the system test
> -----------------------------------------------------------------------------------------
>
> Key: DERBY-2313
> URL: https://issues.apache.org/jira/browse/DERBY-2313
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Manjula Kutty
> Assigned To: Manjula Kutty
> Attachments: DERBY-2313_diff.txt, DERBY-2313_diff2.txt, DERBY-2313_patch2_diff.txt
>
>
> create backup directory relative to the current working dir
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2313) create backup directory relative to
the current working dir while running the system test
Posted by "Manjula Kutty (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Manjula Kutty updated DERBY-2313:
---------------------------------
Attachment: DERBY-2312_diff_ver3.txt
Attaching the new patch after fixing the merge conflict
> create backup directory relative to the current working dir while running the system test
> -----------------------------------------------------------------------------------------
>
> Key: DERBY-2313
> URL: https://issues.apache.org/jira/browse/DERBY-2313
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Manjula Kutty
> Assigned To: Manjula Kutty
> Attachments: DERBY-2313_diff.txt, DERBY-2313_diff2.txt, DERBY-2313_patch2_diff.txt
>
>
> create backup directory relative to the current working dir
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2313) create backup directory relative to
the current working dir while running the system test
Posted by "Manjula Kutty (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Manjula Kutty updated DERBY-2313:
---------------------------------
Attachment: (was: DERBY-2312_diff_ver3.txt)
> create backup directory relative to the current working dir while running the system test
> -----------------------------------------------------------------------------------------
>
> Key: DERBY-2313
> URL: https://issues.apache.org/jira/browse/DERBY-2313
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Manjula Kutty
> Assigned To: Manjula Kutty
> Attachments: DERBY-2313_diff.txt, DERBY-2313_diff2.txt, DERBY-2313_patch2_diff.txt
>
>
> create backup directory relative to the current working dir
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-2313) create backup directory relative to
the current working dir while running the system test
Posted by "Manjula Kutty (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Manjula Kutty resolved DERBY-2313.
----------------------------------
Resolution: Fixed
Derby Info: (was: [Patch Available])
Got fixed with the commit to DERBY-2311
> create backup directory relative to the current working dir while running the system test
> -----------------------------------------------------------------------------------------
>
> Key: DERBY-2313
> URL: https://issues.apache.org/jira/browse/DERBY-2313
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Manjula Kutty
> Assigned To: Manjula Kutty
> Attachments: DERBY-2313_diff.txt, DERBY-2313_diff2.txt, DERBY-2313_patch2_diff.txt
>
>
> create backup directory relative to the current working dir
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2313) create backup directory relative to
the current working dir while running the system test
Posted by "Mamta A. Satoor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473881 ]
Mamta A. Satoor commented on DERBY-2313:
----------------------------------------
Manjula, thanks for taking care of "," in the new patch.
I also noticed that there are some changes related to how the size of the message is calculated. Maybe that is general cleanup work because I didn't understand how it was related to this Jira. If that is the case, do you want to remove the commented out code that was added as part of the patch? The commented out code is as follows.
+ //if(rs.getClob(1) != null){
+ //rs.getAsciiStream(1);
+ //size = rs.getClob(1).length();
> create backup directory relative to the current working dir while running the system test
> -----------------------------------------------------------------------------------------
>
> Key: DERBY-2313
> URL: https://issues.apache.org/jira/browse/DERBY-2313
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Manjula Kutty
> Assigned To: Manjula Kutty
> Attachments: DERBY-2313_diff.txt, DERBY-2313_patch2_diff.txt
>
>
> create backup directory relative to the current working dir
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2313) create backup directory relative to
the current working dir while running the system test
Posted by "Manjula Kutty (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474781 ]
Manjula Kutty commented on DERBY-2313:
--------------------------------------
Yes, those comments can be removed, they are part of another fix, which I will post soon. Thanks for looking in to my patch.
> create backup directory relative to the current working dir while running the system test
> -----------------------------------------------------------------------------------------
>
> Key: DERBY-2313
> URL: https://issues.apache.org/jira/browse/DERBY-2313
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Manjula Kutty
> Assigned To: Manjula Kutty
> Attachments: DERBY-2313_diff.txt, DERBY-2313_patch2_diff.txt
>
>
> create backup directory relative to the current working dir
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2313) create backup directory relative to
the current working dir while running the system test
Posted by "Manjula Kutty (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Manjula Kutty updated DERBY-2313:
---------------------------------
Attachment: DERBY-2313_patch2_diff.txt
Thanks Mamata for looking in to the patch and the suggestion. I have changed the use of "." for the current directory. Please find the attached patch which will fix this issue
> create backup directory relative to the current working dir while running the system test
> -----------------------------------------------------------------------------------------
>
> Key: DERBY-2313
> URL: https://issues.apache.org/jira/browse/DERBY-2313
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Manjula Kutty
> Assigned To: Manjula Kutty
> Attachments: DERBY-2313_diff.txt, DERBY-2313_patch2_diff.txt
>
>
> create backup directory relative to the current working dir
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2313) create backup directory relative to
the current working dir while running the system test
Posted by "Manjula Kutty (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Manjula Kutty updated DERBY-2313:
---------------------------------
Attachment: DERBY-2313_diff.txt
Attaching the patch which will make the test to create the backupdirectory "mailbackup" under the current working directory.
> create backup directory relative to the current working dir while running the system test
> -----------------------------------------------------------------------------------------
>
> Key: DERBY-2313
> URL: https://issues.apache.org/jira/browse/DERBY-2313
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Manjula Kutty
> Assigned To: Manjula Kutty
> Attachments: DERBY-2313_diff.txt
>
>
> create backup directory relative to the current working dir
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2313) create backup directory relative to
the current working dir while running the system test
Posted by "Daniel John Debrunner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476791 ]
Daniel John Debrunner commented on DERBY-2313:
----------------------------------------------
The patch seems to do far more than change the backup directory, so I'm not sure what those changes are for.
> create backup directory relative to the current working dir while running the system test
> -----------------------------------------------------------------------------------------
>
> Key: DERBY-2313
> URL: https://issues.apache.org/jira/browse/DERBY-2313
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Manjula Kutty
> Assigned To: Manjula Kutty
> Attachments: DERBY-2313_diff.txt, DERBY-2313_patch2_diff.txt
>
>
> create backup directory relative to the current working dir
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-2313) create backup directory relative to the
current working dir while running the system test
Posted by "Manjula Kutty (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Manjula Kutty closed DERBY-2313.
--------------------------------
> create backup directory relative to the current working dir while running the system test
> -----------------------------------------------------------------------------------------
>
> Key: DERBY-2313
> URL: https://issues.apache.org/jira/browse/DERBY-2313
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Manjula Kutty
> Assigned To: Manjula Kutty
> Attachments: DERBY-2313_diff.txt, DERBY-2313_diff2.txt, DERBY-2313_patch2_diff.txt
>
>
> create backup directory relative to the current working dir
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.