You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by Joern Kottmann <ko...@gmail.com> on 2015/04/01 15:05:17 UTC
Re: svn commit: r1670574 - /opennlp/trunk/opennlp-uima/src/main/java/opennlp/uima/namefind/NameFinder.java
The adaptive data is cleared in the documentDone method. The statement in
the issue that it is not cleared is not true afaik.
Jörn
On Wed, Apr 1, 2015 at 9:47 AM, <to...@apache.org> wrote:
> Author: tommaso
> Date: Wed Apr 1 07:47:41 2015
> New Revision: 1670574
>
> URL: http://svn.apache.org/r1670574
> Log:
> OPENNLP-764 - applied patch from Pablo Duboue, clearing adaptive data
> after doc processing
>
> Modified:
>
> opennlp/trunk/opennlp-uima/src/main/java/opennlp/uima/namefind/NameFinder.java
>
> Modified:
> opennlp/trunk/opennlp-uima/src/main/java/opennlp/uima/namefind/NameFinder.java
> URL:
> http://svn.apache.org/viewvc/opennlp/trunk/opennlp-uima/src/main/java/opennlp/uima/namefind/NameFinder.java?rev=1670574&r1=1670573&r2=1670574&view=diff
>
> ==============================================================================
> ---
> opennlp/trunk/opennlp-uima/src/main/java/opennlp/uima/namefind/NameFinder.java
> (original)
> +++
> opennlp/trunk/opennlp-uima/src/main/java/opennlp/uima/namefind/NameFinder.java
> Wed Apr 1 07:47:41 2015
> @@ -169,6 +169,8 @@ public final class NameFinder extends Ab
> documentConfidence.add(prob);
> }
>
> + mNameFinder.clearAdaptiveData();
> +
> return names;
> }
>
> @@ -210,4 +212,4 @@ public final class NameFinder extends Ab
> public void destroy() {
> mNameFinder = null;
> }
> -}
> \ No newline at end of file
> +}
>
>
>
Re: svn commit: r1670574 - /opennlp/trunk/opennlp-uima/src/main/java/opennlp/uima/namefind/NameFinder.java
Posted by Tommaso Teofili <to...@gmail.com>.
I think you're right, I'll revert it and solve OPENNLP-764 as not a
problem, sorry for the noise.
Tommaso
2015-04-01 15:05 GMT+02:00 Joern Kottmann <ko...@gmail.com>:
> The adaptive data is cleared in the documentDone method. The statement in
> the issue that it is not cleared is not true afaik.
>
> Jörn
>
> On Wed, Apr 1, 2015 at 9:47 AM, <to...@apache.org> wrote:
>
> > Author: tommaso
> > Date: Wed Apr 1 07:47:41 2015
> > New Revision: 1670574
> >
> > URL: http://svn.apache.org/r1670574
> > Log:
> > OPENNLP-764 - applied patch from Pablo Duboue, clearing adaptive data
> > after doc processing
> >
> > Modified:
> >
> >
> opennlp/trunk/opennlp-uima/src/main/java/opennlp/uima/namefind/NameFinder.java
> >
> > Modified:
> >
> opennlp/trunk/opennlp-uima/src/main/java/opennlp/uima/namefind/NameFinder.java
> > URL:
> >
> http://svn.apache.org/viewvc/opennlp/trunk/opennlp-uima/src/main/java/opennlp/uima/namefind/NameFinder.java?rev=1670574&r1=1670573&r2=1670574&view=diff
> >
> >
> ==============================================================================
> > ---
> >
> opennlp/trunk/opennlp-uima/src/main/java/opennlp/uima/namefind/NameFinder.java
> > (original)
> > +++
> >
> opennlp/trunk/opennlp-uima/src/main/java/opennlp/uima/namefind/NameFinder.java
> > Wed Apr 1 07:47:41 2015
> > @@ -169,6 +169,8 @@ public final class NameFinder extends Ab
> > documentConfidence.add(prob);
> > }
> >
> > + mNameFinder.clearAdaptiveData();
> > +
> > return names;
> > }
> >
> > @@ -210,4 +212,4 @@ public final class NameFinder extends Ab
> > public void destroy() {
> > mNameFinder = null;
> > }
> > -}
> > \ No newline at end of file
> > +}
> >
> >
> >
>