[GitHub] [kafka] tombentley commented on pull request #8311: KAFKA-9434: automated protocol for alterReplicaLogDirs

[GitBox <gi...@apache.org>]

tombentley commented on pull request #8311:
URL: https://github.com/apache/kafka/pull/8311#issuecomment-619986596


   Rebased for conflict.
   
   @dajac thanks for the review. I agree about the case of the unexpected partition. The only way it could happen would be a bug in either the client or the broker, but there's no need to force that onto the user to handle. A warning log should be enough for the bug to be reported eventually. So I've made this change.
   
   About the case of the client not getting a response for a partition: I agree that could happen (again, as a bug in the broker or client). It would be a bit harder to detect though; we'd be spending CPU cycles to detect and log a case which we don't think will ever happen in practice. Maybe that's OK since altering log dirs not something done frequently. But it strikes me that there are plenty of other RPCs in the admin client that don't do this kind of second-guessing of the results. If we're prepared to go to that effort here, why not elsewhere? So personally, I think it would OK to omit this check, but I can do it if you really think it should be done.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org