You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/03/03 18:28:51 UTC

[GitHub] [incubator-superset] john-bodley opened a new pull request #6971: [csv-upload] Fixing message encoding

john-bodley opened a new pull request #6971: [csv-upload] Fixing message encoding
URL: https://github.com/apache/incubator-superset/pull/6971
 
 
   This PR fixes an issue where if an error was thrown whilst trying to upload a CSV it would result in a 500 error with the following error, 
   ```
   builtins:TypeError: Object of type Exception is not JSON serializable
   ```
   which provided no context to the user what was invalid with their configuration. The reason for the error was the message which was being flashed was of type `Exception` (which is not JSON encodable) rather than `str`.
   
   to: @graceguo-supercat @michellethomas @mistercrunch @timifasubaa 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org