You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/19 08:35:48 UTC
[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #322: [doc] Doc cleanup and updates for 1.1.0 release
gyfora opened a new pull request, #322:
URL: https://github.com/apache/flink-kubernetes-operator/pull/322
## What is the purpose of the change
Doc updates for the upcoming release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #322: [doc] Doc cleanup and updates for 1.1.0 release
Posted by GitBox <gi...@apache.org>.
gyfora commented on code in PR #322:
URL: https://github.com/apache/flink-kubernetes-operator/pull/322#discussion_r924370709
##########
docs/content/docs/operations/metrics-logging.md:
##########
@@ -24,33 +24,26 @@ specific language governing permissions and limitations
under the License.
-->
-# Metrics
+# Metrics and Logging
-The Flink Kubernetes Operator (Operator) extends the [Flink Metric System](https://nightlies.apache.org/flink/flink-docs-master/docs/ops/metrics/) that allows gathering and exposing metrics to centralized monitoring solutions.
+## Metrics
-## Flink Resource Metrics
-The Operator gathers aggregates metrics about managed resources.
+The Flink Kubernetes Operator (Operator) extends the [Flink Metric System](https://nightlies.apache.org/flink/flink-docs-master/docs/ops/metrics/) that allows gathering and exposing metrics to centralized monitoring solutions.
-| Scope | Metrics | Description | Type |
-|------------------|-------------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-----------|
-| Namespace | FlinkDeployment/FlinkSessionJob.Count | Number of managed FlinkDeployment/SessionJob instances per namespace | Gauge |
-| Namespace | FlinkDeployment.JmDeploymentStatus.<Status>.Count | Number of managed FlinkDeployment resources per <Status> per namespace. <Status> can take values from: READY, DEPLOYED_NOT_READY, DEPLOYING, MISSING, ERROR | Gauge |
-| Namespace | FlinkDeployment/FlinkSessionJob.Lifecycle.State.<State>.Count | Number of managed resources currently in state <State> per namespace. <State> can take values from: CREATED, SUSPENDED, UPGRADING, DEPLOYED, STABLE, ROLLING_BACK, ROLLED_BACK, FAILED | Gauge |
-| System/Namespace | FlinkDeployment/FlinkSessionJob.Lifecycle.State.<State>.TimeSeconds | Time spent in state <State$gt for a given resource. <State> can take values from: CREATED, SUSPENDED, UPGRADING, DEPLOYED, STABLE, ROLLING_BACK, ROLLED_BACK, FAILED | Histogram |
-| System/Namespace | FlinkDeployment/FlinkSessionJob.Lifecycle.Transition.<Transition>.TimeSeconds | Time statistics for selected lifecycle state transitions. <Transition> can take values from: Resume, Upgrade, Suspend, Stabilization, Rollback, Submission | Histogram |
+### Flink Resource Metrics
+The Operator gathers aggregates metrics about managed resources.
-### Lifecycle metrics
+| Scope | Metrics | Description | Type |
+|--------------------|-------------------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-----------|
+| Namespace | FlinkDeployment/FlinkSessionJob.Count | Number of managed FlinkDeployment/SessionJob instances per namespace | Gauge |
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora merged pull request #322: [doc] Doc cleanup and updates for 1.1.0 release
Posted by GitBox <gi...@apache.org>.
gyfora merged PR #322:
URL: https://github.com/apache/flink-kubernetes-operator/pull/322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #322: [doc] Doc cleanup and updates for 1.1.0 release
Posted by GitBox <gi...@apache.org>.
morhidi commented on code in PR #322:
URL: https://github.com/apache/flink-kubernetes-operator/pull/322#discussion_r924353295
##########
docs/content/docs/operations/metrics-logging.md:
##########
@@ -63,7 +56,7 @@ In addition to the simple counts we further track a few selected state transitio
- Rollback : Time from deployed to rolled_back state if the resource was rolled back
- Submission: Flink resource submission time
-## Kubernetes Client Metrics
+### Kubernetes Client Metrics
The Operator gathers various metrics related to Kubernetes API server access. The Kubernetes client metrics can be enabled by the configuration `kubernetes.operator.kubernetes.client.metrics.enabled` (default: `true`).
Review Comment:
We could probably remove the property from here. (or add it everywhere :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #322: [doc] Doc cleanup and updates for 1.1.0 release
Posted by GitBox <gi...@apache.org>.
morhidi commented on code in PR #322:
URL: https://github.com/apache/flink-kubernetes-operator/pull/322#discussion_r924350918
##########
docs/content/docs/operations/metrics-logging.md:
##########
@@ -24,33 +24,26 @@ specific language governing permissions and limitations
under the License.
-->
-# Metrics
+# Metrics and Logging
-The Flink Kubernetes Operator (Operator) extends the [Flink Metric System](https://nightlies.apache.org/flink/flink-docs-master/docs/ops/metrics/) that allows gathering and exposing metrics to centralized monitoring solutions.
+## Metrics
-## Flink Resource Metrics
-The Operator gathers aggregates metrics about managed resources.
+The Flink Kubernetes Operator (Operator) extends the [Flink Metric System](https://nightlies.apache.org/flink/flink-docs-master/docs/ops/metrics/) that allows gathering and exposing metrics to centralized monitoring solutions.
-| Scope | Metrics | Description | Type |
-|------------------|-------------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-----------|
-| Namespace | FlinkDeployment/FlinkSessionJob.Count | Number of managed FlinkDeployment/SessionJob instances per namespace | Gauge |
-| Namespace | FlinkDeployment.JmDeploymentStatus.<Status>.Count | Number of managed FlinkDeployment resources per <Status> per namespace. <Status> can take values from: READY, DEPLOYED_NOT_READY, DEPLOYING, MISSING, ERROR | Gauge |
-| Namespace | FlinkDeployment/FlinkSessionJob.Lifecycle.State.<State>.Count | Number of managed resources currently in state <State> per namespace. <State> can take values from: CREATED, SUSPENDED, UPGRADING, DEPLOYED, STABLE, ROLLING_BACK, ROLLED_BACK, FAILED | Gauge |
-| System/Namespace | FlinkDeployment/FlinkSessionJob.Lifecycle.State.<State>.TimeSeconds | Time spent in state <State$gt for a given resource. <State> can take values from: CREATED, SUSPENDED, UPGRADING, DEPLOYED, STABLE, ROLLING_BACK, ROLLED_BACK, FAILED | Histogram |
-| System/Namespace | FlinkDeployment/FlinkSessionJob.Lifecycle.Transition.<Transition>.TimeSeconds | Time statistics for selected lifecycle state transitions. <Transition> can take values from: Resume, Upgrade, Suspend, Stabilization, Rollback, Submission | Histogram |
+### Flink Resource Metrics
+The Operator gathers aggregates metrics about managed resources.
-### Lifecycle metrics
+| Scope | Metrics | Description | Type |
+|--------------------|-------------------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-----------|
+| Namespace | FlinkDeployment/FlinkSessionJob.Count | Number of managed FlinkDeployment/SessionJob instances per namespace | Gauge |
Review Comment:
nit: FlinkDeployment/SessionJob->FlinkDeployment/FlinkSessionJob
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #322: [doc] Doc cleanup and updates for 1.1.0 release
Posted by GitBox <gi...@apache.org>.
gyfora commented on PR #322:
URL: https://github.com/apache/flink-kubernetes-operator/pull/322#issuecomment-1188763874
cc @morhidi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #322: [doc] Doc cleanup and updates for 1.1.0 release
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #322:
URL: https://github.com/apache/flink-kubernetes-operator/pull/322#issuecomment-1188910606
+1 LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #322: [doc] Doc cleanup and updates for 1.1.0 release
Posted by GitBox <gi...@apache.org>.
gyfora commented on code in PR #322:
URL: https://github.com/apache/flink-kubernetes-operator/pull/322#discussion_r924370973
##########
docs/content/docs/operations/metrics-logging.md:
##########
@@ -63,7 +56,7 @@ In addition to the simple counts we further track a few selected state transitio
- Rollback : Time from deployed to rolled_back state if the resource was rolled back
- Submission: Flink resource submission time
-## Kubernetes Client Metrics
+### Kubernetes Client Metrics
The Operator gathers various metrics related to Kubernetes API server access. The Kubernetes client metrics can be enabled by the configuration `kubernetes.operator.kubernetes.client.metrics.enabled` (default: `true`).
Review Comment:
I added a general note and a link to the general config section
##########
docs/content/docs/operations/metrics-logging.md:
##########
@@ -63,7 +56,7 @@ In addition to the simple counts we further track a few selected state transitio
- Rollback : Time from deployed to rolled_back state if the resource was rolled back
- Submission: Flink resource submission time
-## Kubernetes Client Metrics
+### Kubernetes Client Metrics
The Operator gathers various metrics related to Kubernetes API server access. The Kubernetes client metrics can be enabled by the configuration `kubernetes.operator.kubernetes.client.metrics.enabled` (default: `true`).
Review Comment:
I added a general note and a link to the metric config section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org