[GitHub] [ozone] devmadhuu commented on a diff in pull request #4440: HDDS-8127. Exclude deleted containers from Recon container count

["devmadhuu (via GitHub)" <gi...@apache.org>]

devmadhuu commented on code in PR #4440:
URL: https://github.com/apache/ozone/pull/4440#discussion_r1151440143


##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ClusterStateEndpoint.java:
##########
@@ -134,15 +150,19 @@ public Response getClusterState() {
       totalKeys += fileRecord.getValue();
     }
     builder.setKeys(totalKeys);
-
+    // Subtract deleted containers from total containers.
+    containerStateCounts.setTotalContainerCount(

Review Comment:
   @ArafatKhan2198 , pls call this setter method for total container count once at last for final value. You can remove the call from line no 95 above.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org