You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/27 06:17:00 UTC
[jira] [Commented] (CB-12955) npm-link fail after cordova-lib
folder refactor
[ https://issues.apache.org/jira/browse/CB-12955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064340#comment-16064340 ]
ASF GitHub Bot commented on CB-12955:
-------------------------------------
GitHub user halton opened a pull request:
https://github.com/apache/cordova-coho/pull/152
CB-12955: Update path for npm-link and tools-release-process.md
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
### What testing has been done on this change?
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/halton/cordova-coho npm-link-path
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-coho/pull/152.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #152
----
commit 4639f15a59edfac9d7ca1a69ad73a73c071c2d50
Author: Halton Huo <ha...@intel.com>
Date: 2017-06-27T06:12:24Z
CB-12955: Update path for npm-link and tools-release-process.md
----
> npm-link fail after cordova-lib folder refactor
> -----------------------------------------------
>
> Key: CB-12955
> URL: https://issues.apache.org/jira/browse/CB-12955
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-coho
> Environment: According the change https://github.com/apache/cordova-lib/commit/fc72293c77e3a72ec248fbc0b37fe5cc2b517fdf, the cordova-common, cordova-serve and cordova-fetch is moved out folder of cordova-lib.
> So npm-link should be updated as well
> Reporter: Haitao Huo
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org