You are viewing a plain text version of this content. The canonical link for it is here.
Posted to modperl-cvs@perl.apache.org by do...@hyperreal.org on 1999/01/21 01:03:17 UTC
cvs commit: modperl/t/net/perl module.pl
dougm 99/01/20 16:03:17
Modified: . Changes ToDo
File File.pm
t/net/perl module.pl
Log:
untaint Apache::File->tmpfile (if $ENV{TMPDIR,TEMP} are used)
skip module.t unless mod_{include,access} are configured
Revision Changes Path
1.251 +3 -0 modperl/Changes
Index: Changes
===================================================================
RCS file: /export/home/cvs/modperl/Changes,v
retrieving revision 1.250
retrieving revision 1.251
diff -u -r1.250 -r1.251
--- Changes 1999/01/20 23:16:25 1.250
+++ Changes 1999/01/21 00:03:14 1.251
@@ -9,11 +9,14 @@
=item 1.17_01-dev
+untaint Apache::File->tmpfile (if $ENV{TMPDIR,TEMP} are used)
+
'make test' fixups:
-for when other modules (e.g. auth, dirindex, type)
come before mod_perl in the module list
-exit graceful if LWP is still not installed
+ -skip module.t unless mod_{include,access} are configured
loose @ISA 'DynaLoader' to avoid inheriting AutoLoader::AUTOLOAD
1.150 +0 -4 modperl/ToDo
Index: ToDo
===================================================================
RCS file: /export/home/cvs/modperl/ToDo,v
retrieving revision 1.149
retrieving revision 1.150
diff -u -r1.149 -r1.150
--- ToDo 1999/01/20 18:35:18 1.149
+++ ToDo 1999/01/21 00:03:14 1.150
@@ -3,15 +3,11 @@
(well, close to it anyhow)
---------------------------------------------------------------------------
-- revisit Apache::File::tmpfile
-
- PerlRun undef &subroutine bug
- @PerlSetVar core dumps outside of %Location (Ask)
- turn of strip of httpd in Apache's install.sh
-
-- Perl{Set,Pass}Env tainted, should they not be? (Vivek)
- at .../perl/Apache/SIG.pm line 30 (Mark Downing, Ron Hawkins)
1.3 +1 -0 modperl/File/File.pm
Index: File.pm
===================================================================
RCS file: /export/home/cvs/modperl/File/File.pm,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- File.pm 1999/01/20 18:35:21 1.2
+++ File.pm 1999/01/21 00:03:16 1.3
@@ -12,6 +12,7 @@
my $TMPNAM = 'aaaaaa';
my $TMPDIR = $ENV{'TMPDIR'} || $ENV{'TEMP'} || '/tmp';
+($TMPDIR) = $TMPDIR =~ /^([^<>|;*]+)$/; #untaint
my $Mode = Fcntl::O_WRONLY()|Fcntl::O_EXCL()|Fcntl::O_CREAT();
my $Perms = 0600;
1.2 +4 -1 modperl/t/net/perl/module.pl
Index: module.pl
===================================================================
RCS file: /export/home/cvs/modperl/t/net/perl/module.pl,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- module.pl 1998/10/23 00:24:54 1.1
+++ module.pl 1999/01/21 00:03:16 1.2
@@ -4,7 +4,10 @@
my $r = shift;
$r->send_http_header('text/plain');
-unless(have_module "Apache::Module", '0.10') {
+unless(have_module "Apache::Module", '0.10' and
+ Apache->module('mod_include.c') and
+ Apache->module('mod_access.c'))
+{
print "1..0\n";
return;
}