[2/3] kudu git commit: Fix flakiness in ts_recovery-itest TestCrashBeforeWriteLogSegmentHeader

[to...@apache.org]

Fix flakiness in ts_recovery-itest TestCrashBeforeWriteLogSegmentHeader

TestCrashBeforeWriteLogSegmentHeader injects server faults during a
write workload before writing the log segment header. In a stressed test
environment, writes may take longer, and workloads may time out before
even communicating with the server. If the workload never successfully
writes to the server for this reason, and never makes it to the
fault-injection-site, the test will fail.

This is resolved by bumping the timeout allowed by the workload,
ensuring there is enough time to get the table locations and insert data
to them.

With the bumped timeout, this passes 500/500 runs in TSAN with
--stress_cpu_threads=8, rather than failing ~75%.

Change-Id: I382bb1109ef12c23d6f191b64d97bcaa6ec96d6a
Reviewed-on: http://gerrit.cloudera.org:8080/7838
Reviewed-by: Todd Lipcon <to...@apache.org>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/a07d01ea
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/a07d01ea
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/a07d01ea

Branch: refs/heads/master
Commit: a07d01ea54876b7ceea63edf9b6a9859cead84d9
Parents: bde730f
Author: Andrew Wong <aw...@cloudera.com>
Authored: Fri Aug 25 12:27:19 2017 -0700
Committer: Todd Lipcon <to...@apache.org>
Committed: Sat Aug 26 01:26:24 2017 +0000

----------------------------------------------------------------------
 src/kudu/integration-tests/ts_recovery-itest.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/a07d01ea/src/kudu/integration-tests/ts_recovery-itest.cc
----------------------------------------------------------------------
diff --git a/src/kudu/integration-tests/ts_recovery-itest.cc b/src/kudu/integration-tests/ts_recovery-itest.cc
index 4edfbf8..a70a3ec 100644
--- a/src/kudu/integration-tests/ts_recovery-itest.cc
+++ b/src/kudu/integration-tests/ts_recovery-itest.cc
@@ -273,7 +273,7 @@ TEST_P(TsRecoveryITest, TestCrashBeforeWriteLogSegmentHeader) {
   NO_FATALS(StartClusterOneTs(extra_tserver_flags_));
   TestWorkload work(cluster_.get());
   work.set_num_replicas(1);
-  work.set_write_timeout_millis(100);
+  work.set_write_timeout_millis(1000);
   work.set_timeout_allowed(true);
   work.set_payload_bytes(10000); // make logs roll without needing lots of ops.
   work.Setup();