You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by nathanejohnson <gi...@git.apache.org> on 2017/03/12 01:20:31 UTC
[GitHub] cloudstack pull request #2001: CLOUDSTACK-9830 Fix DST bug in QuotaAlertMana...
GitHub user nathanejohnson opened a pull request:
https://github.com/apache/cloudstack/pull/2001
CLOUDSTACK-9830 Fix DST bug in QuotaAlertManagerTest
Replace the use of joda with Calendar, set explicitly to UTC when
doing date manipulation.
This fixes an issue where when running this test on a machine set to a local timezone that is about to switch to DST, the difference returns 0 versus 1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/myENA/cloudstack CLOUDSTACK-9830
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/2001.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2001
----
commit 58877ecac2db7c1601c354d219777d394a316abf
Author: Nathan Johnson <nj...@ena.com>
Date: 2017-03-12T01:17:22Z
CLOUDSTACK-9830 Fix DST bug in QuotaAlertManagerTest
Replace the use of joda with Calendar, set explicitly to UTC when
doing date manipulation.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2001: CLOUDSTACK-9830 Fix DST bug in QuotaAlertManagerTest
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/2001
LGTM. @abhinandanprateek ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2001: CLOUDSTACK-9830 Fix DST bug in QuotaAlertManagerTest
Posted by nathanejohnson <gi...@git.apache.org>.
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/2001
@rthyd I'm not sure if this was a joda time bug or (more likely) misuse of joda time. I'm not even sure how best to verify that. All I know is that when using the java data methods the issue went away.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2001: CLOUDSTACK-9830 Fix DST bug in QuotaAlertManagerTest
Posted by abhinandanprateek <gi...@git.apache.org>.
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/2001
@LGTM on code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2001: CLOUDSTACK-9830 Fix DST bug in QuotaAlertManagerTest
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/2001
@nathanejohnson can we continue to use jodatime but you can fix your issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---