You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by tabish121 <gi...@git.apache.org> on 2018/06/29 19:23:30 UTC
[GitHub] activemq-artemis pull request #2168: RTEMIS-1941 Preserve AMQP body section ...
GitHub user tabish121 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2168
RTEMIS-1941 Preserve AMQP body section type on "large" messages
When "large" messages are converted to / from core in order to be stored
in the large message store the type of the AMQP body section is being
lost and reconstituted incorrectly in some cases. The message needs to
be annotated with the original AMQP type for the body and that used to
manage the conversion back to AMQP from Core.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-1941
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2168.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2168
----
commit 9780b275ea03e4c587a6e808e4e5214ff7bb2548
Author: Timothy Bish <ta...@...>
Date: 2018-06-29T19:22:05Z
ARTEMIS-1941 Preserve AMQP body section type on "large" messages
When "large" messages are converted to / from core in order to be stored
in the large message store the type of the AMQP body section is being
lost and reconstituted incorrectly in some cases. The message needs to
be annotated with the original AMQP type for the body and that used to
manage the conversion back to AMQP from Core.
----
---
[GitHub] activemq-artemis issue #2168: RTEMIS-1941 Preserve AMQP body section type on...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2168
I took for granted that the checkstyle issues were the only problems. However, there were 4 tests failing. I've sent #2174 to deal with them, but I'm not 100% certain they are correct. Could you review, @tabish121?
---
[GitHub] activemq-artemis issue #2168: RTEMIS-1941 Preserve AMQP body section type on...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2168
What I had planned for large messages in amqp was to not convert them at all. What would make this moot.
---
[GitHub] activemq-artemis issue #2168: RTEMIS-1941 Preserve AMQP body section type on...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2168
I forgot the merge commit so you will have to close this PR manually.
---
[GitHub] activemq-artemis pull request #2168: RTEMIS-1941 Preserve AMQP body section ...
Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2168
---
[GitHub] activemq-artemis issue #2168: RTEMIS-1941 Preserve AMQP body section type on...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2168
Checkstyle violations in JMSMappingOutboundTransformerTest.
---
[GitHub] activemq-artemis issue #2168: RTEMIS-1941 Preserve AMQP body section type on...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2168
I went ahead and fixed the checkstyle issues and pushed.
---