You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by gu...@apache.org on 2020/04/19 19:33:06 UTC
[kafka] branch trunk updated: HOTFIX: fix checkstyle error of
RocksDBStoreTest and flaky
RocksDBTimestampedStoreTest.shouldOpenExistingStoreInRegularMode (#8515)
This is an automated email from the ASF dual-hosted git repository.
guozhang pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new cfea096 HOTFIX: fix checkstyle error of RocksDBStoreTest and flaky RocksDBTimestampedStoreTest.shouldOpenExistingStoreInRegularMode (#8515)
cfea096 is described below
commit cfea096a8dc0036c0993d9be7948298a5f8f0001
Author: Chia-Ping Tsai <ch...@gmail.com>
AuthorDate: Mon Apr 20 03:32:25 2020 +0800
HOTFIX: fix checkstyle error of RocksDBStoreTest and flaky RocksDBTimestampedStoreTest.shouldOpenExistingStoreInRegularMode (#8515)
1. Fix broken build
2. Fix flaky RocksDBTimestampedStoreTest.shouldOpenExistingStoreInRegularMode
Reviewers: Guozhang Wang <wa...@gmail.com>
---
.../org/apache/kafka/streams/state/internals/RocksDBStoreTest.java | 3 +--
.../kafka/streams/state/internals/RocksDBTimestampedStoreTest.java | 1 +
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java b/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java
index b1ee48f..833bae1 100644
--- a/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java
+++ b/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java
@@ -31,7 +31,6 @@ import org.apache.kafka.common.utils.Utils;
import org.apache.kafka.streams.KeyValue;
import org.apache.kafka.streams.StreamsConfig;
import org.apache.kafka.streams.errors.ProcessorStateException;
-import org.apache.kafka.streams.processor.ProcessorContext;
import org.apache.kafka.streams.processor.StateRestoreListener;
import org.apache.kafka.streams.processor.TaskId;
import org.apache.kafka.streams.processor.internals.metrics.StreamsMetricsImpl;
@@ -160,7 +159,7 @@ public class RocksDBStoreTest {
@Test
public void shouldNotAddStatisticsToInjectedMetricsRecorderWhenRecordingLevelIsInfo() {
- rocksDBStore= getRocksDBStoreWithRocksDBMetricsRecorder();
+ rocksDBStore = getRocksDBStoreWithRocksDBMetricsRecorder();
context = getProcessorContext(RecordingLevel.INFO);
reset(metricsRecorder);
replay(metricsRecorder);
diff --git a/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStoreTest.java b/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStoreTest.java
index fdfb6a2..a51eb18 100644
--- a/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStoreTest.java
+++ b/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStoreTest.java
@@ -74,6 +74,7 @@ public class RocksDBTimestampedStoreTest extends RocksDBStoreTest {
rocksDBStore.init(context, rocksDBStore);
assertThat(appender.getMessages(), hasItem("Opening store " + DB_NAME + " in regular mode"));
LogCaptureAppender.unregister(appender);
+ rocksDBStore.close();
// verify store
final DBOptions dbOptions = new DBOptions();