[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on a diff in pull request #10: Add property API

[GitBox <gi...@apache.org>]

wu-sheng commented on code in PR #10:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/10#discussion_r851236244


##########
src/main/java/org/apache/skywalking/banyandb/v1/client/BanyanDBClient.java:
##########
@@ -314,6 +317,38 @@ public void define(Measure measure) throws BanyanDBException {
         MetadataCache.INSTANCE.register(measure);
     }
 
+    /**
+     * Create or update the property
+     *
+     * @param property the property to be stored in the BanyanBD
+     */
+    public void save(Property property) throws BanyanDBException {

Review Comment:
   I think you miss `delete`, is this on purpose?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org