You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ah...@apache.org on 2019/11/29 05:45:09 UTC
[royale-compiler] branch develop updated: Revert
"MXMLClassReferenceNodeBase: fixed issue where an MXML child element could
be incorrectly resolved as a property/style/event,
even if it had a different XML namespace prefix from its parent (closes
#101)"
This is an automated email from the ASF dual-hosted git repository.
aharui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git
The following commit(s) were added to refs/heads/develop by this push:
new d807f89 Revert "MXMLClassReferenceNodeBase: fixed issue where an MXML child element could be incorrectly resolved as a property/style/event, even if it had a different XML namespace prefix from its parent (closes #101)"
d807f89 is described below
commit d807f89ed363faf98e56197540811a87906795e8
Author: Alex Harui <ah...@apache.org>
AuthorDate: Thu Nov 28 21:44:03 2019 -0800
Revert "MXMLClassReferenceNodeBase: fixed issue where an MXML child element could be incorrectly resolved as a property/style/event, even if it had a different XML namespace prefix from its parent (closes #101)"
We want to match Flex Compiler's behavior and this change seems more restrictive. Further investigation is needed.
This reverts commit ea3b7d904adbf25177ed9f1d5a7cfc1da249f6a8.
---
.../compiler/internal/tree/mxml/MXMLClassReferenceNodeBase.java | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/compiler/src/main/java/org/apache/royale/compiler/internal/tree/mxml/MXMLClassReferenceNodeBase.java b/compiler/src/main/java/org/apache/royale/compiler/internal/tree/mxml/MXMLClassReferenceNodeBase.java
index bc5d7bd..4c66aa4 100644
--- a/compiler/src/main/java/org/apache/royale/compiler/internal/tree/mxml/MXMLClassReferenceNodeBase.java
+++ b/compiler/src/main/java/org/apache/royale/compiler/internal/tree/mxml/MXMLClassReferenceNodeBase.java
@@ -436,13 +436,7 @@ abstract class MXMLClassReferenceNodeBase extends MXMLNodeBase implements IMXMLC
RoyaleProject project = builder.getProject();
// Handle child tags that are property/style/event specifiers.
- MXMLSpecifierNodeBase childNode = null;
- // ...but only if the child has the same prefix as the parent -JT
- // apache/royale-compiler#101
- if(tag.getPrefix().equals(childTag.getPrefix()))
- {
- childNode = createSpecifierNode(builder, childTag.getShortName());
- }
+ MXMLSpecifierNodeBase childNode = createSpecifierNode(builder, childTag.getShortName());
if (childNode != null)
{
// This tag is not part of the default property value.