You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/14 07:55:10 UTC
[GitHub] [spark] LuciferYang opened a new pull request #35507: [SPARK-38199][SQL] Delete the unused `dataType` specified in the definition of `IntervalColumnAccessor`
LuciferYang opened a new pull request #35507:
URL: https://github.com/apache/spark/pull/35507
### What changes were proposed in this pull request?
SPARK-30066 introduce `IntervalColumnAccessor` and it accepts 2 constructor parameters: `buffer` and `dataType`, but the `dataType` was ignored because the parameter passed to `BasicColumnAccessor` is alway `CALENDAR_INTERVAL`, to this pr delete the unused `dataType`.
### Why are the changes needed?
Clear class definition of `IntervalColumnAccessor`.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #35507: [SPARK-38199][SQL] Delete the unused `dataType` specified in the definition of `IntervalColumnAccessor`
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #35507:
URL: https://github.com/apache/spark/pull/35507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35507: [SPARK-38199][SQL] Delete the unused `dataType` specified in the definition of `IntervalColumnAccessor`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35507:
URL: https://github.com/apache/spark/pull/35507#issuecomment-1040070901
> dfaf187
it's my bad, [dfaf187](https://github.com/apache/spark/pull/35507/commits/dfaf187d9b92e6f2032b8c8121be6c3b7a502a9c) should fix this failure, I will pay attention to whether GA passes, thanks @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #35507: [SPARK-38199][SQL] Delete the unused `dataType` specified in the definition of `IntervalColumnAccessor`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #35507:
URL: https://github.com/apache/spark/pull/35507#issuecomment-1040226276
+1, LGTM. Merging to master.
Thank you, @LuciferYang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35507: [SPARK-38199][SQL] Delete the unused `dataType` specified in the definition of `IntervalColumnAccessor`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35507:
URL: https://github.com/apache/spark/pull/35507#issuecomment-1040052643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #35507: [SPARK-38199][SQL] Delete the unused `dataType` specified in the definition of `IntervalColumnAccessor`
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #35507:
URL: https://github.com/apache/spark/pull/35507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35507: [SPARK-38199][SQL] Delete the unused `dataType` specified in the definition of `IntervalColumnAccessor`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35507:
URL: https://github.com/apache/spark/pull/35507#issuecomment-1040231559
thanks @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #35507: [SPARK-38199][SQL] Delete the unused `dataType` specified in the definition of `IntervalColumnAccessor`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #35507:
URL: https://github.com/apache/spark/pull/35507#issuecomment-1040226276
+1, LGTM. Merging to master.
Thank you, @LuciferYang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35507: [SPARK-38199][SQL] Delete the unused `dataType` specified in the definition of `IntervalColumnAccessor`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35507:
URL: https://github.com/apache/spark/pull/35507#issuecomment-1040189834
GA passed @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #35507: [SPARK-38199][SQL] Delete the unused `dataType` specified in the definition of `IntervalColumnAccessor`
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #35507:
URL: https://github.com/apache/spark/pull/35507#issuecomment-1040070901
> Seems the failure is related to the changes:
>
> ```
> [info] - cache supports for intervals *** FAILED *** (330 milliseconds)
> [info] org.apache.spark.SparkException: Job aborted due to stage failure: Task 1 in stage 357.0 failed 1 times, most recent failure: Lost task 1.0 in stage 357.0 (TID 530) (localhost executor driver): java.util.concurrent.ExecutionException: org.codehaus.commons.compiler.CompileException: File 'generated.java', Line 58, Column 26: failed to compile: org.codehaus.commons.compiler.CompileException: File 'generated.java', Line 58, Column 26: No applicable constructor/method found for actual parameters "java.nio.ByteBuffer, org.apache.spark.sql.types.CalendarIntervalType$"; candidates are: "org.apache.spark.sql.execution.columnar.IntervalColumnAccessor(java.nio.ByteBuffer)"
> ```
it's my bad, [dfaf187](https://github.com/apache/spark/pull/35507/commits/dfaf187d9b92e6f2032b8c8121be6c3b7a502a9c) should fix this failure, I will pay attention to whether GA passes, thanks @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #35507: [SPARK-38199][SQL] Delete the unused `dataType` specified in the definition of `IntervalColumnAccessor`
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #35507:
URL: https://github.com/apache/spark/pull/35507#issuecomment-1040070901
> Seems the failure is related to the changes:
>
> ```
> [info] - cache supports for intervals *** FAILED *** (330 milliseconds)
> [info] org.apache.spark.SparkException: Job aborted due to stage failure: Task 1 in stage 357.0 failed 1 times, most recent failure: Lost task 1.0 in stage 357.0 (TID 530) (localhost executor driver): java.util.concurrent.ExecutionException: org.codehaus.commons.compiler.CompileException: File 'generated.java', Line 58, Column 26: failed to compile: org.codehaus.commons.compiler.CompileException: File 'generated.java', Line 58, Column 26: No applicable constructor/method found for actual parameters "java.nio.ByteBuffer, org.apache.spark.sql.types.CalendarIntervalType$"; candidates are: "org.apache.spark.sql.execution.columnar.IntervalColumnAccessor(java.nio.ByteBuffer)"
> ```
it's my bad, [dfaf187](https://github.com/apache/spark/pull/35507/commits/dfaf187d9b92e6f2032b8c8121be6c3b7a502a9c) should fix this failure, I will pay attention to whether GA passes, thanks @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35507: [SPARK-38199][SQL] Delete the unused `dataType` specified in the definition of `IntervalColumnAccessor`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35507:
URL: https://github.com/apache/spark/pull/35507#issuecomment-1040052643
> Seems the failure is related to the changes:
>
> ```
> [info] - cache supports for intervals *** FAILED *** (330 milliseconds)
> [info] org.apache.spark.SparkException: Job aborted due to stage failure: Task 1 in stage 357.0 failed 1 times, most recent failure: Lost task 1.0 in stage 357.0 (TID 530) (localhost executor driver): java.util.concurrent.ExecutionException: org.codehaus.commons.compiler.CompileException: File 'generated.java', Line 58, Column 26: failed to compile: org.codehaus.commons.compiler.CompileException: File 'generated.java', Line 58, Column 26: No applicable constructor/method found for actual parameters "java.nio.ByteBuffer, org.apache.spark.sql.types.CalendarIntervalType$"; candidates are: "org.apache.spark.sql.execution.columnar.IntervalColumnAccessor(java.nio.ByteBuffer)"
> ```
Let me check this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org